Skip to content
  1. Nov 14, 2018
  2. Nov 13, 2018
  3. Nov 12, 2018
  4. Nov 10, 2018
  5. Nov 09, 2018
  6. Nov 08, 2018
  7. Nov 07, 2018
  8. Nov 05, 2018
  9. Nov 04, 2018
    • Benjamin Kaduk's avatar
      Restore sensible "sess_accept" counter tracking · 33a37a61
      Benjamin Kaduk authored
      Commit 9ef9088c
      
       switched the SSL/SSL_CTX
      statistics counters to using Thread-Sanitizer-friendly primitives.
      However, it erroneously converted an addition of -1
      (for s->session_ctx->stats.sess_accept) to an addition of +1, since that
      is the only counter API provided by the internal tsan_assist.h header
      until the previous commit.  This means that for each accepted (initial)
      connection, the session_ctx's counter would get doubly incremented, and the
      (switched) ctx's counter would also get incremented.
      
      Restore the counter decrement so that each accepted connection increments
      exactly one counter exactly once (in net effect).
      
      Reviewed-by: default avatarPaul Dale <paul.dale@oracle.com>
      (Merged from https://github.com/openssl/openssl/pull/7464)
      
      (cherry picked from commit 2aaa0b146b967397a6e61fa8df969e7847f82086)
      33a37a61