- 30 Sep, 2017 1 commit
-
-
David Benjamin authored
This guards against the name constraints check consuming large amounts of CPU time when certificates in the presented chain contain an excessive number of names (specifically subject email names or subject alternative DNS names) and/or name constraints. Name constraints checking compares the names presented in a certificate against the name constraints included in a certificate higher up in the chain using two nested for loops. Move the name constraints check so that it happens after signature verification so peers cannot exploit this using a chain with invalid signatures. Also impose a hard limit on the number of name constraints check loop iterations to further mitigate the issue. Thanks to NCC for finding this issue. Fix written by Martin Kreichgauer. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4411) (cherry picked from commit 8545051c) Resolved conflicts: crypto/x509v3/v3_ncons.c test/recipes/25-test_verify.t
-
- 29 Sep, 2017 2 commits
-
-
Samuel Weiser authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
-
Hubert Kario authored
BN_new() and BN_secure_new() not only allocate memory, but also initialise it to deterministic value - 0. Document that behaviour to make it explicit backport from #4438 Reviewed-by:
-
- 27 Sep, 2017 3 commits
-
-
David Benjamin authored
The pub_key field for DH isn't actually used in DH_compute_key at all. (Note the peer public key is passed in as as BIGNUM.) It's mostly there so the caller may extract it from DH_generate_key. It doesn't particularly need to be present if filling in a DH from external parameters. The check in DH_set0_key conflicts with adding OpenSSL 1.1.0 to Node. Their public API is a thin wrapper over the old OpenSSL one: https://nodejs.org/api/crypto.html#crypto_class_diffiehellman They have separate setPrivateKey and setPublicKey methods, so the public key may be set last or not at all. In 1.0.2, either worked fine since operations on DH objects generally didn't use the public key. (Like with OpenSSL, Node's setPublicKey method is also largely a no-op, but so it goes.) In 1.1.0, DH_set0_key prevents create a private-key-only DH object. (cherry picked from commit d58ad9a2a287d1c0bc99ba63c997eed88cc161b5) Reviewed-by:
Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/4425)
-
Samuel Weiser authored
Reviewed-by:
Paul Dale <paul.dale@oracle.com> Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4377) (cherry picked from commit 9f944291)
-
Samuel Weiser authored
Fixed error in propagating BN_FLG_CONSTTIME flag through BN_MONT_CTX_set, which could lead to information disclosure on RSA primes p and q. Reviewed-by:
-
- 26 Sep, 2017 1 commit
-
-
Richard Levitte authored
Fixes #4419 Reviewed-by:
Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4420) (cherry picked from commit 4881d849)
-
- 23 Sep, 2017 2 commits
-
-
Pichulin Dmitrii authored
Reviewed-by:
Stephen Henson <steve@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4405) (cherry picked from commit 75c445e4)
-
Dr. Stephen Henson authored
Avoid duplicate assertion by removing dhparam from SSL_CONF parameter list: dhparam is handled manually by s_server. Reviewed-by:
-
- 21 Sep, 2017 1 commit
-
-
Benjamin Kaduk authored
This option was lost when converting to a table-driven option parser in commit 7e1b7485 . Reviewed-by:
-
- 19 Sep, 2017 1 commit
-
-
David Benjamin authored
c2i_ASN1_BIT_STRING takes length as a long but uses it as an int. Check bounds before doing so. Previously, excessively large inputs to the function could write a single byte outside the target buffer. (This is unreachable as asn1_ex_c2i already uses int for the length.) Thanks to NCC for finding this issue. Fix written by Martin Kreichgauer. Reviewed-by:
-
- 17 Sep, 2017 1 commit
-
-
Pauli authored
Address coverity report of null pointer being dereferenced. Reviewed-by:
-
- 15 Sep, 2017 2 commits
-
-
Christian Heimes authored
OpenSSL 1.1.0 made SSL_CTX and SSL structs opaque and introduced a new API to set the minimum and maximum protocol version for SSL_CTX with TLS_method(). Add getters to introspect the configured versions: int SSL_CTX_get_min_proto_version(SSL_CTX *ctx); int SSL_CTX_get_max_proto_version(SSL_CTX *ctx); int SSL_get_min_proto_version(SSL *ssl); int SSL_get_max_proto_version(SSL *ssl); NOTE: The getters do not resolv the version in case when the minimum or maxium version are configured as '0' (meaning auto-select lowest and highst version number). Signed-off-by:
Christian Heimes <christian@python.org> Reviewed-by:
Ben Kaduk <kaduk@mit.edu> (cherry picked from commit 3edabd3c) Updated for new manual page location and TLS 1.3. (Merged from https://github.com/openssl/openssl/pull/4376)
-
Benjamin Kaduk authored
If the result of a SSL_{CTX_,}set_{min,max}_proto_version() call leaves the min and max version identical, and support for that version is compiled out of the library, return an error. Such an object has no hope of successfully completing a handshake, and this error may be easier to decipher than the resulting handshake failure. Reviewed-by:
-
- 12 Sep, 2017 1 commit
-
-
Richard Levitte authored
crypto/rand/rand_egd.c makes extensive use of stdio functions. When they are disabled, it makes sense to disable egd as well. Reviewed-by:
-
- 11 Sep, 2017 1 commit
-
-
multics authored
Fixes the typo CLA: trivial Reviewed-by:
-
- 08 Sep, 2017 1 commit
-
-
Matt Caswell authored
If an alert gets sent and then we close the connection immediately with data still in the input buffer then a TCP-RST gets sent. Some OSs immediately abandon data in their input buffer if a TCP-RST is received - meaning the alert data itself gets ditched. Sending a TCP-FIN before the TCP-RST seems to avoid this. This was causing test failures in MSYS2 builds. Reviewed-by:
-
- 07 Sep, 2017 1 commit
-
-
Rich Salz authored
Reviewed-by:
-
- 06 Sep, 2017 1 commit
-
-
Rich Salz authored
Reviewed-by:
-
- 01 Sep, 2017 3 commits
-
-
Richard Levitte authored
Reviewed-by:
-
Andy Polyakov authored
The commit subject is a bit misleading in sense that decisions affect only gcc and gcc-alikes, like clang, recent icc... This is back-port of 54cf3b98 , GH#4281. Reviewed-by:
-
Andy Polyakov authored
OPENSSL_ia32cap.pod discusses possibility to disable operations on XMM register bank. This formally means that this flag has to be checked in combination with other flags. But it customarily isn't. But instead of chasing all the cases we can flip more bits together with FXSR one. Reviewed-by:
-
- 31 Aug, 2017 2 commits
-
-
Richard Levitte authored
When parsing the header files, mkdef.pl didn't clear the line terminator properly. In most cases, this didn't matter, but there were moments when this caused parsing errors (such as CRLFs in certain cases). Fixes #4267 Reviewed-by:
-
Zhu Qun-Ying authored
CLA: trivial Reviewed-by:
-
- 28 Aug, 2017 1 commit
-
-
Rich Salz authored
Fixes CVE 2017-3735 Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/4276) (cherry picked from commit b2317174)
-
- 26 Aug, 2017 1 commit
-
-
Rich Salz authored
Reviewed-by:
-
- 25 Aug, 2017 4 commits
-
-
Bernd Edlinger authored
Reviewed-by:
-
Richard Levitte authored
This is a vestige from pre-1.1.0 OpenSSL Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
- 24 Aug, 2017 1 commit
-
-
Matt Caswell authored
Reviewed-by:
-
- 23 Aug, 2017 2 commits
-
-
Dr. Stephen Henson authored
Fix GCM documentation: the tag does not have to be supplied before decrypting any data any more. Reviewed-by:
-
Rich Salz authored
Reviewed-by:
-
- 21 Aug, 2017 3 commits
-
-
Pauli authored
Cast arguments to the various ctype functions to unsigned char to match their documentation. Reviewed-by:
-
Nicola Tuveri authored
Reviewed-by:
-
Nicola Tuveri authored
Reviewed-by:
-
- 18 Aug, 2017 4 commits
-
-
Balaji Marisetti authored
CLA: trivial Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
Richard Levitte authored
We changed directory to the wrong directory. This change also separates the preparation phase from the tarball building phase. Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
