- 22 Nov, 2018 1 commit
-
-
Tobias Hintze authored
Delays stripping of trailing dots to after resolving the hostname. Fixes #3022 Closes #3222
-
- 21 Nov, 2018 5 commits
-
-
UnknownShadow200 authored
Closes #3295
-
Daniel Gustafsson authored
-
Michael Kaufmann authored
Session resumption information is not available immediately after a TLS 1.3 handshake. The client must wait until the server has sent a session ticket. Use OpenSSL's "new session" callback to get the session information and put it into curl's session cache. For TLS 1.3 sessions, this callback will be invoked after the server has sent a session ticket. The "new session" callback is invoked only if OpenSSL's session cache is enabled, so enable it and use the "external storage" mode which lets curl manage the contents of the session cache. A pointer to the connection data and the sockindex are now saved as "SSL extra data" to make them available to the callback. This approach also works for old SSL/TLS versions and old OpenSSL versions. Reviewed-by:
Daniel Stenberg <daniel@haxx.se> Fixes #3202 Closes #3271
-
Michael Kaufmann authored
- ENGINE_cleanup() was used without including "openssl/engine.h" - enable engine support for OpenSSL 0.9.7 Closes #3266
-
Daniel Stenberg authored
Since we're close to feature freeze, this change disables this feature with an #ifdef. Define ALLOW_RENEG at build-time to enable. This could be converted to a bit for CURLOPT_SSL_OPTIONS to let applications opt-in this. Concern-raised-by: David Benjamin Fixes #3283 Closes #3293
-
- 20 Nov, 2018 4 commits
-
-
Romain Fliedel authored
When using c-ares for asyn dns, the dns socket fd was silently closed by c-ares without curl being aware. curl would then 'realize' the fd has been removed at next call of Curl_resolver_getsock, and only then notify the CURLMOPT_SOCKETFUNCTION to remove fd from its poll set with CURL_POLL_REMOVE. At this point the fd is already closed. By using ares socket state callback (ARES_OPT_SOCK_STATE_CB), this patch allows curl to be notified that the fd is not longer needed for neither for write nor read. At this point by calling Curl_multi_closed we are able to notify multi with CURL_POLL_REMOVE before the fd is actually closed by ares. In asyn-ares.c Curl_resolver_duphandle we can't use ares_dup anymore since it does not allow passing a different sock_state_cb_data Closes #3238
-
Romain Fliedel authored
-
pkubaj authored
lib/curl_ntlm.c had code that read as follows: #ifdef USE_OPENSSL # ifdef USE_OPENSSL # else # .. # endif #endif Remove the redundant USE_OPENSSL along with #else (it's not possible to reach it anyway). The removed construction is a leftover from when the SSLeay support was removed. Closes #3269 Reviewed-by:
Daniel Gustafsson <daniel@yesql.se> Reviewed-by:
Daniel Stenberg <daniel@haxx.se>
-
Han Han authored
Closes #3291
-
- 19 Nov, 2018 7 commits
-
-
Han Han authored
-
Han Han authored
-
Patrick Monnerat authored
-
Patrick Monnerat authored
-
Patrick Monnerat authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
The license for the impacket package was not in our tree. Imported now from upstream's https://github.com/SecureAuthCorp/impacket/blob/master/LICENSE Reported-by: infinnovation-dev on github Fixes #3276 Closes #3277
-
- 18 Nov, 2018 1 commit
-
-
Daniel Gustafsson authored
The partial struct initialization in 397664a0 caused a warning on uninitialized MODULEENTRY32 struct members: /src/tool_doswin.c:681:3: warning: missing initializer for field 'th32ModuleID' of 'MODULEENTRY32 {aka struct tagMODULEENTRY32}' [-Wmissing-field-initializers] This is sort of a bogus warning as the remaining members will be set to zero by the compiler, as all omitted members are. Nevertheless, remove the warning by omitting all members and setting the dwSize members explicitly. Closes #3254 Reviewed-by:
Marcel Raad <Marcel.Raad@teamviewer.com> Reviewed-by:
Jay Satiro <raysatiro@yahoo.com>
-
- 17 Nov, 2018 1 commit
-
-
Daniel Gustafsson authored
Commit 709cf76f deprecated USE_SSLEAY, as curl since long isn't compatible with the SSLeay library. This removes the few leftovers that were omitted in the less frequently used platform targets. Closes #3270 Reviewed-by:
Daniel Stenberg <daniel@haxx.se>
-
- 16 Nov, 2018 3 commits
-
-
Elia Tufarolo authored
Fix HTTP POST using CURLAUTH_NEGOTIATE. Closes #3275
-
Daniel Stenberg authored
Brought-by: bobmitchell1956 on github Fixes #3278 Closes #3279
-
Peter Wu authored
The SSL_CTX_set_msg_callback callback is not just called for the Handshake or Alert protocols, but also for the raw record header (SSL3_RT_HEADER) and the decrypted inner record type (SSL3_RT_INNER_CONTENT_TYPE). Be sure to ignore the latter to avoid excess debug spam when using `curl -v` against a TLSv1.3-enabled server: * TLSv1.3 (IN), TLS app data, [no content] (0): (Following this message, another callback for the decrypted handshake/alert messages will be be present anyway.) Closes https://github.com/curl/curl/pull/3281
-
- 15 Nov, 2018 1 commit
-
-
Marc Hoersken authored
SO_EXCLUSIVEADDRUSE is on by default on Vista or newer, but does not work together with SO_REUSEADDR being on. The default changes were made with stunnel 5.34 and 5.35.
-
- 13 Nov, 2018 3 commits
-
-
Kamil Dudka authored
Closes #3262
-
Daniel Stenberg authored
Fixes #3261
-
Daniel Gustafsson authored
Commit 5bfaa86c introduced a new compiler warning on Windows cross compilation with GCC. See below for an example of the warning from the autobuild logs (whitespace edited to fit): /src/tool_cb_wrt.c:175:9: warning: cast from function call of type 'intptr_t {aka long long int}' to non-matching type 'void *' [-Wbad-function-cast] (HANDLE) _get_osfhandle(fileno(outs->stream)), ^ Store the return value from _get_osfhandle() in an intermediate variable and cast the variable in WriteConsoleW() rather than the function call directly to avoid a compiler warning. In passing, also add inspection of the MultiByteToWideChar() return value and return failure in case an error is reported. Closes #3263 Reviewed-by:
Marcel Raad <Marcel.Raad@teamviewer.com> Reviewed-by:
Viktor Szakats <commit@vszakats.net>
-
- 12 Nov, 2018 1 commit
-
-
Daniel Stenberg authored
-
- 10 Nov, 2018 1 commit
-
-
Daniel Stenberg authored
-
- 09 Nov, 2018 7 commits
-
-
Tim Rühsen authored
Curl_ftp_parselist: avoid unsigned integer overflows The overflow has no real world impact, just avoid it for "best practice". Closes #3225
-
Daniel Stenberg authored
The end port number in a given range was not included in the range used, as it is documented to be. Reported-by: infinnovation-dev on github Fixes #3251 Closes #3255
-
Jérémy Rocher authored
As per BoringSSL porting documentation [1], BoringSSL rejects peer renegotiations by default. curl fails when trying to authenticate to server through client certificate if it is requested by server after the initial TLS handshake. Enable renegotiation by default with BoringSSL to get same behavior as with OpenSSL. This is done by calling SSL_set_renegotiate_mode [2] which was introduced in commit 1d5ef3bb1eb9 [3]. 1 - https://boringssl.googlesource.com/boringssl/+/HEAD/PORTING.md#tls-renegotiation 2 - https://boringssl.googlesource.com/boringssl/+/master/include/openssl/ssl.h#3482 3 - https://boringssl.googlesource.com/boringssl/+/1d5ef3bb1eb97848617db5e7d633d735a401df86 Signed-off-by:
Jérémy Rocher <rocher.jeremy@gmail.com> Fixes #3258 Closes #3259
-
Daniel Stenberg authored
Added a few of the more notable milestones in curl history that were missing. Primarily more recent ones but I also noted some older that could be worth mentioning. [ci skip] Closes #3257
-
Daniel Gustafsson authored
Add the identified issue with --proxy-any and proxy servers which advertise authentication schemes other than the supported one. Closes #876 Closes #3250 Reported-by: NTMan on Github Reviewed-by:
Daniel Stenberg <daniel@haxx.se>
-
Jim Fuller authored
Allows an application to pass in a pre-parsed URL via a URL handle. Closes #3227
-
Gisle Vanem authored
Groff / Troff will display a: printaf("Errno: %ld\n", error); as: printf("Errno: %ld0, error); when a "\n" is not escaped. Use "\\n" instead. Closes #3246
-
- 08 Nov, 2018 1 commit
-
-
Daniel Stenberg authored
Regression by 52db5486. Reported-by: infinnovation-dev on github Fixes #3248 Closes #3249
-
- 07 Nov, 2018 4 commits
-
-
Gisle Vanem authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
The tool's local port command line range parser didn't check for integer overflows and could pass "weird" data to libcurl for this option. libcurl however, has a strict range check for the values so it rejects anything outside of the accepted range. Reported-by: Brian Carpenter Closes #3242
-
Daniel Stenberg authored
Follow-up to e431daf0, as I did the wrong correction for a compiler warning. It should be a break and not a fall-through. Pointed-out-by: Frank Gevaerts
-