Unverified Commit 27cb3846 authored by Jérémy Rocher's avatar Jérémy Rocher Committed by Daniel Stenberg
Browse files

openssl: support BoringSSL TLS renegotiation 

As per BoringSSL porting documentation [1], BoringSSL rejects peer
renegotiations by default.

curl fails when trying to authenticate to server through client
certificate if it is requested by server after the initial TLS
handshake.

Enable renegotiation by default with BoringSSL to get same behavior as
with OpenSSL. This is done by calling SSL_set_renegotiate_mode [2]
which was introduced in commit 1d5ef3bb1eb9 [3].

1 - https://boringssl.googlesource.com/boringssl/+/HEAD/PORTING.md#tls-renegotiation
2 - https://boringssl.googlesource.com/boringssl/+/master/include/openssl/ssl.h#3482
3 - https://boringssl.googlesource.com/boringssl/+/1d5ef3bb1eb97848617db5e7d633d735a401df86



Signed-off-by: default avatarJérémy Rocher <rocher.jeremy@gmail.com>
Fixes #3258
Closes #3259
parent a1aabed8

lib/vtls/openssl.c

+4 −0
Original line number Diff line number Diff line
@@ -2610,6 +2610,10 @@ static CURLcode ossl_connect_step1(struct connectdata *conn, int sockindex) 
    SSL_set_tlsext_status_type(BACKEND->handle, TLSEXT_STATUSTYPE_ocsp);

#endif



#ifdef OPENSSL_IS_BORINGSSL

  SSL_set_renegotiate_mode(BACKEND->handle, ssl_renegotiate_freely);

#endif



  SSL_set_connect_state(BACKEND->handle);



  BACKEND->server_cert = 0x0;