Commit b88bf6e6 authored by Daniel Gustafsson's avatar Daniel Gustafsson
Browse files

tool_doswin: Fix uninitialized field warning 



The partial struct initialization in 397664a0 caused
a warning on uninitialized MODULEENTRY32 struct members:

  /src/tool_doswin.c:681:3: warning: missing initializer for field
  'th32ModuleID' of 'MODULEENTRY32 {aka struct tagMODULEENTRY32}'
  [-Wmissing-field-initializers]

This is sort of a bogus warning as the remaining members will be set
to zero by the compiler, as all omitted members are. Nevertheless,
remove the warning by omitting all members and setting the dwSize
members explicitly.

Closes #3254
Reviewed-by: default avatarMarcel Raad <Marcel.Raad@teamviewer.com>
Reviewed-by: default avatarJay Satiro <raysatiro@yahoo.com>
parent 1cccf2f9

src/tool_doswin.c

+3 −1
Original line number Diff line number Diff line
@@ -678,9 +678,11 @@ CURLcode FindWin32CACert(struct OperationConfig *config, 
struct curl_slist *GetLoadedModulePaths(void)

{

  HANDLE hnd = INVALID_HANDLE_VALUE;

  MODULEENTRY32 mod = { sizeof(mod), };

  MODULEENTRY32 mod = {0};

  struct curl_slist *slist = NULL;



  mod.dwSize = sizeof(MODULEENTRY32);



  do {

    hnd = CreateToolhelp32Snapshot(TH32CS_SNAPMODULE, 0);

  } while(hnd == INVALID_HANDLE_VALUE && GetLastError() == ERROR_BAD_LENGTH);