- 09 Jun, 2017 1 commit
-
-
Rich Salz authored
removed the unnecessary upper bracket add !SSL_USE_SIGALGS to check for broken implementations of GOST client signature (signature without length field) Reviewed-by:
Matt Caswell <matt@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/3588)
-
- 08 Jun, 2017 6 commits
-
-
Benjamin Kaduk authored
Modern browsers are now, well, pretty modern. Reviewed-by:
-
Tomas Mraz authored
Fixes #3490 Reviewed-by:
-
Rich Salz authored
when building with OPENSSL_SMALL_FOOTPRINT defined. Reviewed-by:
Tim Hudson <tjh@openssl.org> Reviewed-by:
-
Diego Santa Cruz authored
This uses memset() to clear all of the SRP_CTX when free'ing or initializing it as well as in error paths instead of having a series of NULL and zero assignments as it is safer. It also changes SSL_SRP_CTX_init() to reset all the SRP_CTX to zero in case or error, previously it could retain pointers to freed memory, potentially leading to a double free. Reviewed-by:
-
Diego Santa Cruz authored
Ownership and lifetime rules of SRP_CTX.info are confusing and different from those of SRP_CTX.login, making it difficult to use correctly. This makes the ownership and lifetime be the same as those of SRP_CTX.login, thet is a copy is made when setting it and is freed when SRP_CTX is freed. Reviewed-by:
-
Richard Levitte authored
The list of programs hit nmake's maximum line length, so we split up the line in smaller chunks. Fixes #3634 Reviewed-by:
-
- 07 Jun, 2017 1 commit
-
-
Rich Salz authored
Various initialization functions modify this table, which can cause heap corruption in the absence of external synchronization. Some stats are modified from OPENSSL_LH_retrieve, where callers aren't expecting to have to take out an exclusive lock. Switch to using atomic operations for those stats. Reviewed-by:
-
- 05 Jun, 2017 3 commits
-
-
Rich Salz authored
Document that -psk is required to use PSK cipher Reviewed-by:
Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/3607) (cherry picked from commit 9d772829)
-
Andy Polyakov authored
Drop some redundant instructions in reduction in ecp_nistz256_sqr_montx. Reviewed-by:
-
Rich Salz authored
Thanks to Jan Alexander Steffens for finding the bug and confirming the fix. Reviewed-by:
Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/3592) (cherry picked from commit 73bc5370)
-
- 02 Jun, 2017 1 commit
-
-
Rich Salz authored
Reviewed-by:
-
- 01 Jun, 2017 1 commit
-
-
Benjamin Kaduk authored
It does not exist on this branch. Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
-
- 31 May, 2017 2 commits
-
-
Paul Yang authored
Reformat some indents and braces based on OpenSSL coding style spec. Signed-off-by:
Paul Yang <paulyang.inf@gmail.com> Reviewed-by:
-
Matt Caswell authored
In a recent PR (#3566) it seems that TLSProxy gave up trying to connect to the server process too quickly. This meant the test failed even though the server *did* eventually start. Currently we try 3 times to connect with a 0.1 second pause between each attempt. That is probably too aggressive. Reviewed-by:
-
- 30 May, 2017 1 commit
-
-
Rich Salz authored
Require a comma between every name and a single space before the dash Reviewed-by:
Kurt Roeckx <kurt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/3559) (cherry picked from commit 2bcb232e)
-
- 27 May, 2017 2 commits
-
-
Rich Salz authored
Document thread-safety issues Cherry-pick from 076fc555 but keeps the RSA_null method. Reviewed-by:
Geoff Thorpe <geoff@openssl.org> (Merged from https://github.com/openssl/openssl/pull/3146)
-
Andy Polyakov authored
Reviewed-by:
-
- 26 May, 2017 3 commits
-
-
Matt Caswell authored
Issue #3562 describes a problem where a race condition can occur in the Proxy such that a test "ok" line can appear in the middle of other text causing the test harness to miss it. The issue is that we do not wait for the client process to finish after the test is complete, so that process may continue to write data to stdout/stderr at the same time that the test harness does. This commit fixes TLSProxy so that we always wait for the client process to finish before continuing. Fixes #3562 Reviewed-by:
-
Todd Short authored
The check for SSL3_FLAGS_ALLOW_UNSAFE_LEGACY_RENEGOTIATION is inconsistent. Most places check SSL->options, one place is checking SSL_CTX->options; fix that. Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> GH: #3523 (cherry picked from commit dffdcc77)
-
Rainer Jung authored
CLA: Trivial Fixes #3563. Reviewed-by:
-
- 25 May, 2017 5 commits
-
-
Kurt Roeckx authored
Reviewed-by:
-
Matt Caswell authored
Fixes #3541 Reviewed-by:
-
Matt Caswell authored
Reviewed-by:Stephen Henson <steve@openssl.org>
-
Matt Caswell authored
Reviewed-by: -
Matt Caswell authored
Reviewed-by:
-
- 24 May, 2017 2 commits
-
-
David Woodhouse authored
Part of issue #3531 Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
- 23 May, 2017 1 commit
-
-
Paul Yang authored
In the example section. CLA: trivial Signed-off-by:
-
- 22 May, 2017 4 commits
-
-
Alex Gaynor authored
Reviewed-by:
-
Todd Short authored
Remove assertion when mmap() fails. Only give the 1<<31 limit test as an example. Fix the small arena test to just check for the symptom of the infinite loop (i.e. initialized set on failure), rather than the actual infinite loop. This avoids some valgrind errors. Backport of: PR #3512 commit fee423bb PR #3510 commit a486561b PR #3455 commit c8e89d58 PR #3449 commit 7031ddac Issue 1: sh.bittable_size is a size_t but i is and int, which can result in freelist == -1 if sh.bittable_size exceeds an int. This seems to result in an OPENSSL_assert due to invalid allocation size, so maybe that is "ok." Worse, if sh.bittable_size is exactly 1<<31, then this becomes an infinite loop (because 1<<31 is a negative int, so it can be shifted right forever and sticks at -1). Issue 2: CRYPTO_secure_malloc_init() sets secure_mem_initialized=1 even when sh_init() returns 0. If sh_init() fails, we end up with secure_mem_initialized=1 but sh.minsize=0. If you then call secure_malloc(), which then calls, sh_malloc(), this then enters an infite loop since 0 << anything will never be larger than size. Issue 3: That same sh_malloc loop will loop forever for a size greater than size_t/2 because i will proceed (assuming sh.minsize=16): i=16, 32, 64, ..., size_t/8, size_t/4, size_t/2, 0, 0, 0, 0, .... This sequence will never be larger than "size". Reviewed-by:
-
Diego Santa Cruz authored
The password_callback() function does not necessarily NULL terminate the password buffer, the caller must use the returned length but the srp app uses this function as if it was doing NULL termination. This made the -passin and -passout options of "openssl srp" fail inexpicably and randomly or even crash. Fixed by enlarging the buffer by one, so that the maximum password length remains unchanged, and adding NULL termination upon return. [Rearrange code for coding style compliance in process.] Reviewed-by:
-
Andy Polyakov authored
Switch to TAP::Harness inadvertently masked test failures. Test::Harness::runtests was terminating with non-zero exit code in case of failure[s], while TAP::Harness apparently holds caller responsible for doing so. Reviewed-by:
-
- 21 May, 2017 1 commit
-
-
Rich Salz authored
update pkcs12, smime, ts apps. Reviewed-by:
-
- 19 May, 2017 3 commits
-
-
Diego Santa Cruz authored
With the -list option the srp app loops on the main while() endlessly, whether users were given on the command line or not. The loop should be stopped when in list mode and there are no more users. Reviewed-by:
-
Matt Caswell authored
Fixes #1526 Reviewed-by:
-
Matt Caswell authored
Fixes #1526 Reviewed-by:
-
- 17 May, 2017 1 commit
-
-
Richard Levitte authored
Notifications can be (and should be) configured on account basis on the CI web site. This avoids getting emails to openssl-commits for personal accounts that also build OpenSSL stuff. Reviewed-by:
-
- 15 May, 2017 2 commits
-
-
Richard Levitte authored
Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
