- 21 Sep, 2016 14 commits
-
-
Matt Caswell authored
A TLS message includes 3 bytes for its length in the header for the message. This would allow for messages up to 16Mb in length. Messages of this length are excessive and OpenSSL includes a check to ensure that a peer is sending reasonably sized messages in order to avoid too much memory being consumed to service a connection. A flaw in the logic of version 1.1.0 means that memory for the message is allocated too early, prior to the excessive message length check. Due to way memory is allocated in OpenSSL this could mean an attacker could force up to 21Mb to be allocated to service a connection. This could lead to a Denial of Service through memory exhaustion. However, the excessive message length check still takes place, and this would cause the connection to immediately fail. Assuming that the application calls SSL_free() on the failed conneciton in a timely manner then the 21Mb of allocated memory will then be immediately freed again. Therefore the excessive memory allocation will be transitory in nature. This then means that there is only a security impact if: 1) The application does not call SSL_free() in a timely manner in the event that the connection fails or 2) The application is working in a constrained environment where there is very little free memory or 3) The attacker initiates multiple connection attempts such that there are multiple connections in a state where memory has been allocated for the connection; SSL_free() has not yet been called; and there is insufficient memory to service the multiple requests. Except in the instance of (1) above any Denial Of Service is likely to be transitory because as soon as the connection fails the memory is subsequently freed again in the SSL_free() call. However there is an increased risk during this period of application crashes due to the lack of memory - which would then mean a more serious Denial of Service. This issue does not affect DTLS users. Issue was reported by Shi Lei (Gear Team, Qihoo 360 Inc.). CVE-2016-6307 Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit c1ef7c97)
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 047d97af)
-
Matt Caswell authored
If OPENSSL_sk_insert() calls OPENSSL_realloc() and it fails, it was leaking the originally allocated memory. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 41bff723)
-
Matt Caswell authored
Certain warning alerts are ignored if they are received. This can mean that no progress will be made if one peer continually sends those warning alerts. Implement a count so that we abort the connection if we receive too many. Issue reported by Shi Lei. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit af58be76)
-
Andy Polyakov authored
Suggested in GH#1589. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 7dc0ad4d)
-
Andy Polyakov authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit ba8fa4e5)
-
Andy Polyakov authored
Reported in GH#1589, but solution is different from suggested. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 799c1293)
-
Rich Salz authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 776e15f9)
-
Rich Salz authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 6fcace45)
-
Alessandro Ghedini authored
Makes the logic a little bit clearer. Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1571) (cherry picked from commit 4f8a5f4d)
-
Matt Caswell authored
We should check the last BN_CTX_get() call to ensure that it isn't NULL before we try and use any of the allocated BIGNUMs. Issue reported by Shi Lei. Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 1ff7425d)
-
Richard Levitte authored
This is a program for VMS that corresponds to util/shlib_wrap.sh. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit f3ff481f)
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 47852e6a)
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit f6be8315)
-
- 20 Sep, 2016 11 commits
-
-
Rich Salz authored
Check arg count and print an error message. Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 13a46183)
-
Richard Levitte authored
Reviewed-by:
Tim Hudson <tjh@openssl.org> (cherry picked from commit a19228b7)
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 6e836806)
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 8c88c88b)
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit f4566dff)
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit ccf11f7e)
-
Richard Levitte authored
Call SSL_CTX_new() before doing any configuration. (or call OPENSSL_ssl_init()) Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 54d72ef0)
-
Richard Levitte authored
'ECDHParameters = Automatic' isn't accepted. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 3656ea1c)
-
Richard Levitte authored
Note: server-cmod doesn't seem to do things right... from loading cmod.cnf, it tries to load libssl_conf.so. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 16c6deed)
-
FdaSilvaYY authored
CMS_NOOLDMIMETYPE and PKCS7_NOOLDMIMETYPE are unused in pkcs7/cms code. Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1585) (cherry picked from commit 28aef3d9)
-
FdaSilvaYY authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1585) (cherry picked from commit 12d56b29)
-
- 19 Sep, 2016 4 commits
-
-
Matt Caswell authored
We were casting num_alloc to size_t in lots of places, or just using it in a context where size_t makes more sense - so convert it. This simplifies the code a bit. Also tweak the style in stack.c a bit following on from the previous commit Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 9205ebeb)
-
Guido Vranken authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (cherry picked from commit 9731a9ce)
-
FdaSilvaYY authored
no-rsa is no longer an option since 7ec8de16 Fix a typo about poly1305 Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1582) (cherry picked from commit e2562bbb)
-
Richard Levitte authored
Some compilers complain about unused variables, and some tests do not run well without OCSP. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 057c676a)
-
- 17 Sep, 2016 3 commits
-
-
Richard Levitte authored
In an earlier attempt to simplify the processing of disabled options, 'no-err' and 'no-async' stopped working properly. 'err' and 'async' are directories under 'crypto/', but they are special insofar that they can't be simply skipped, like all the algorithm directories can, so they need special treatment among the disablable things. Reviewed-by:
Tim Hudson <tjh@openssl.org> (cherry picked from commit 66fe388a)
-
Richard Levitte authored
While we're at it, correct the fault in windows-makefile.tmpl Reviewed-by:
Andy Polyakov <appro@openssl.org> (cherry picked from commit 41240e68)
-
FdaSilvaYY authored
APP_INFO is currently a field of MEM struct. Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1583) (cherry picked from commit 76dc3563)
-
- 16 Sep, 2016 4 commits
-
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> (cherry picked from commit c5ad3076)
-
Richard Levitte authored
They are now relative paths as well Reviewed-by:
Andy Polyakov <appro@openssl.org> (cherry picked from commit 1967a42e)
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> (cherry picked from commit dc660c70)
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> (cherry picked from commit ee9b0bbb)
-
- 15 Sep, 2016 4 commits
-
-
Matt Caswell authored
This reverts commit 77a6be4d . There were some unexpected side effects to this commit, e.g. in SSLv3 a warning alert gets sent "no_certificate" if a client does not send a Certificate during Client Auth. With the above commit this causes the connection to abort, which is incorrect. There may be some other edge cases like this so we need to have a rethink on this. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit d602c2b6)
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit 51e5133d)
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit c7bdb6a3)
-