- Sep 14, 2016
-
-
Rich Salz authored
Resolves GH1515 and GH1509. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 7d959c35)
-
Matt Caswell authored
The internal SRP function t_fromb64() converts from base64 to binary. It does not validate that the size of the destination is sufficiently large - that is up to the callers. In some places there was such a check, but not in others. Add an argument to t_fromb64() to provide the size of the destination buffer and validate that we don't write too much data. Also add some sanity checks to the callers where appropriate. With thanks to Shi Lei for reporting this issue. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 73f0df83)
-
- Sep 13, 2016
-
-
Richard Levitte authored
Also, enlarge test group 20 to include openssl commands that aren't tested otherwise Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 497f3bf9)
-
Richard Levitte authored
RT#4674 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 9f9f962d)
-
Andy Grundman authored
This flag got moved after -xarch=v9 in 1.1.0 and had the unexpected side effect of the compiler building for 32-bit v8plusa instead of v9. GH#1521 CLA: none; trivial Signed-off-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit fa4618a2)
-
Viktor Szakats authored
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1520) (cherry picked from commit c2efa783)
-
Viktor Szakats authored
it appears when using gcc/mingw: ``` apps/s_client.c:815:9: warning: variable 'at_eof' set but not used [-Wunused-but-set-variable] int at_eof = 0; ^~~~~~ ``` Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1512) (cherry picked from commit d485640b)
-
Andy Polyakov authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 35c11bfc)
-
Andy Polyakov authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit cc2cb7bf)
-
Matt Caswell authored
Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 6462876f)
-
Matt Caswell authored
A peer continually sending unrecognised warning alerts could mean that we make no progress on a connection. We should abort rather than continuing if we receive an unrecognised warning alert. Thanks to Shi Lei for reporting this issue. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 77a6be4d)
-
- Sep 12, 2016
-
-
David Woodhouse authored
Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit cdbbf990)
-
- Sep 09, 2016
-
-
Tim Hudson authored
even when the public key is not present in an EC_KEY Reviewed-by: Stephen Henson <steve@openssl.org> (cherry picked from commit 82f52631)
-
- Sep 08, 2016
-
-
Richard Levitte authored
VMS sets that errno when the device part of a file spec is malformed or a logical name that doesn't exist. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit e82e2186)
-
Richard Levitte authored
Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 047a5da2)
-
Matt Caswell authored
Certain functions are automatically called during auto-deinit in order to deallocate resources. However, if we have never entered a function which marks lib crypto as inited then they never get called. This can happen if the user only ever makes use of a small sub-set of functions that don't hit the auto-init code. This commit ensures all such resources deallocated by these functions also init libcrypto when they are initially allocated. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Ben Laurie <ben@openssl.org> (cherry picked from commit 135648bc)
-
Matt Caswell authored
Using the -trace option to s_server or s_client was incorrectly printing UNKNOWN for the X25519 curve. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 2d11f5b2)
-
Andy Polyakov authored
Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 4e399729)
-
Andy Polyakov authored
Improve interchangeability of aix*-gcc targets by linking shared libraries with -static-libgcc, and address linking problems with vendor compiler. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit f780eaad)
-
Andy Polyakov authored
RT#4667 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit abcbf7ed)
-
- Sep 07, 2016
-
-
Rich Salz authored
Found by turning -Wswitch-enum on. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 252cfef1)
-
Richard Levitte authored
The background story is that util/shlib_wrap.sh was setting LD_PRELOAD or similar platform dependent variables, just in case the shared libraries were built with -rpath. Unfortunately, this doesn't work too well with asan, msan or ubsan. So, the solution is to forbid the combination of shared libraries, -rpath and any of the sanity analyzers we can configure. This changes util/shlib_wrap.sh so it only contains the code that sets LD_PRELOAD when -rpath has been used when configuring. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 342a1a23)
-
David Woodhouse authored
Some hardware devices don't provide the public EC_POINT data. The only way for X509_check_private_key() to validate that the key matches a given certificate is to actually perform a sign operation and then verify it using the public key in the certificate. Maybe that can come later, as discussed in issue 1532. But for now let's at least make it fail gracefully and not crash. GH: 1532 Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1547)
-
Richard Levitte authored
The way we figured out what options are crypto algorithms and what are something other was somewhat sketchy. This change bases the distinction on available sdirs instead. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 3e2dd30d)
-
Alex Gaynor authored
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit d65c3615)
-
- Sep 06, 2016
-
-
Rich Salz authored
Never output -0; make "negative zero" an impossibility. Do better checking on BN_rand top/bottom requirements and #bits. Update doc. Ignoring trailing garbage in BN_asc2bn. Port this commit from boringSSL: https://boringssl.googlesource.com/boringssl/+/899b9b19a4cd3fe526aaf5047ab9234cdca19f7d%5E!/ Ensure |BN_div| never gives negative zero in the no_branch code. Have |bn_correct_top| fix |bn->neg| if the input is zero so that we don't have negative zeros lying around. Thanks to Brian Smith for noticing. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 01c09f9f)
-
Richard Levitte authored
Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 77a42b5f)
-
- Sep 05, 2016
-
-
Richard Levitte authored
In the case of using an independent makedepend, we had split that into two separate recipes, one depending on the other. However, there are cases where the makedepend recipe was always trying, but doesn't update the time stamp of the .d file because there are no actual changes, and thereby causing constant updates of the object files. This change makes one recipe that takes care of both makedepend och cc, thereby avoiding these extra updates. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 7e5b8b93)
-
- Sep 03, 2016
-
-
Andy Polyakov authored
Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 6cf412c4)
-
- Sep 02, 2016
-
-
Andy Polyakov authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit d5a39c12)
-
Andy Polyakov authored
Since vendor assembler can't assemble our modules with -KPIC flag, it, assembly support, was not available as an option. But this means lack of side-channel resistant code, which is incompatible with security by todays standards. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 216a0cc4)
-
- Sep 01, 2016
-
-
Richard Levitte authored
This adheres much better to the documentation in test/README Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 377ab6d1)
-
Richard Levitte authored
This reverts commit 7f9ae888 . Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 967e831e)
-
Richard Levitte authored
This reverts commit eb40eaed . Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit a5e1f123)
-
- Aug 31, 2016
-
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 7f9ae888)
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit ed43fe73)
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit bf98d9da)
-
Richard Levitte authored
Because some targets execute perl code that might die, we risk incomplete lists. Make it so dying doesn't happen when we're listing targets. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit d63c12c6)
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 0c0d78b8)
-
Richard Levitte authored
These tests take a very long time on some platforms, and arent't always strictly necessary. This makes it possible to turn them off. The necessary binaries are still built, though, in case someone still wants to do a manual run. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit eb40eaed)
-