- Jun 03, 2012
-
-
Daniel Stenberg authored
-
Steve Holme authored
Added some comments and removed an unreferenced variable.
-
Steve Holme authored
Added USE_NTLM condition compilation around the NTLM functions called from pop3_statemach_act() introduced in commit 69f7156a.
-
Steve Holme authored
Moved the cram-md5 message creation from smtp.c into the sasl module to allow for use by other modules such as pop3.
-
Steve Holme authored
Because pop3_endofresp() is called for each line of data yet is not passed the line and line length, so we have to use the data pointed to by pp->linestart_resp which contains the whole packet, the mechanisms were being detected in one call yet the function would be called for each line of data. Using curl with verbose mode enabled would show that one line of data would be received in response to the AUTH command, before the AUTH <mechanism> command was sent to the server and then the next few lines of the original AUTH command would be displayed before the response from the AUTH <mechanism> command. This would then cause problems when parsing the CRAM-MD5 challenge data as extra data was contained in the buffer. Changed the parsing so that each line is checked for the mechanisms and the function returns FALSE until the whole of the AUTH response has been processed.
-
Daniel Stenberg authored
Due to new features
-
Daniel Stenberg authored
Also bumped the contributor number and next release is to become 7.27.0
-
Daniel Stenberg authored
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
Added new sections 11. IMAP and 12. LDAP to document adding SASL based authentication. Renumbered current sections 11 to 17 as 13 to 19. Additionally added 19.10 Add CURLOPT_MAIL_CLIENT option.
-
- Jun 02, 2012
-
-
Steve Holme authored
Applied a fix to avoid warnings on systems where Curl_ntlm_sspi_cleanup() is just a nop.
-
Steve Holme authored
-
Steve Holme authored
Previously it wasn't possible to connect to POP3 and not specify the user name as a CURLE_ACCESS_DENIED error would be returned. This error occurred because USER would be sent to the server with a blank user name if no mailbox user was specified as the server would reply with -ERR. This wasn't a problem prior to the 7.26.0 release but with the introduction of custom commands the user and/or application developer might want to issue a CAPA command without having to log in as a specific mailbox user. Additionally this fix won't send the newly introduced AUTH command if no user name is specified.
-
Steve Holme authored
Corrected lines exceeding 78 characters. Repositioned some comments and added extra clarity.
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
Moved the ntlm message creation and decoding from smtp.c into the sasl module to allow for use by other modules such as pop3.
-
- Jun 01, 2012
-
-
Steve Holme authored
-
Yang Tse authored
-
Yang Tse authored
This is done introducing tags <file1> to <file4> besides existing <file> one, as well as corresponding <stripfile1> to <stripfile4> ones, that can be used in the <verify> section in the same way as the non-numbered ones.
-
- May 31, 2012
-
-
Steve Holme authored
Moved the login message creation from smtp.c into the sasl module to allow for use by other modules such as pop3.
-
Steve Holme authored
Rather than encoding the password message itself the smtp_state_authpasswd_resp() function now delegates the work to the same function that smtp_state_authlogin_resp() and smtp_authenticate() use when constructing the encoded user name.
-
Steve Holme authored
In preparation for moving to the SASL module re-factored the smtp_auth_login_user() function to smtp_auth_login() so that it can be used for both user names and passwords as sending both of these under the login authentication mechanism is the same.
-
Steve Holme authored
-
- May 30, 2012
-
-
Steve Holme authored
-
Steve Holme authored
Moved the plain text message creation from smtp.c into the sasl module to allow for use by other modules such as pop3.
-
Yang Tse authored
-
Yang Tse authored
Introduce SUPPORTCAPA and SUPPORTAUTH config commands to allow further pop3 test server expansion for tests that require CAPA or AUTH support, although this will need some extra work to make it fully functional.
-
- May 28, 2012
-
-
Steve Holme authored
-
Steve Holme authored
The POP3 protocol doesn't really have the concept of error codes and uses +, +OK and -ERR in response to commands to indicate continue, success and error. The AUTH command is one of those commands that requires multiple pieces of data to be sent to the server where the server will respond with + as part of the handshaking. This meant changing the values before continuing with the next stage of adding authentication support.
-
Steve Holme authored
Changed the order of the state machine to match the order of actual events. Reworked some comments and function parameter positioning that I missed the other day.
-
-
- May 27, 2012
-
-
Daniel Stenberg authored
Since it isn't a feature supported by curl-config we can't compare that with the --version output
-
Daniel Stenberg authored
-
Steve Holme authored
Additionally corrected another RFC link that I missed yesterday.
-
Steve Holme authored
Added support for detecting the supported SASL authentication mechanisms via the AUTH command. There are two ways of detecting them, either by using the AUTH command, that will return -ERR if not supported or by using the CAPA command which will return SASL and the list of mechanisms if supported, not include SASL if SASL authentication is not supported or -ERR if the CAPA command is not supported. As such it seems simpler to use the AUTH command and fallback to normal clear text authentication if the the command is not supported. Additionally updated the test cases to return -ERR when the AUTH command is encountered. Additional test cases will be added when support for the individual authentication mechanisms is added.
-
Daniel Stenberg authored
-
Steve Holme authored
Moved EOB definition into header file. Switched the logic around in pop3_endofresp() to allow for the introduction of auth-mechanism detection. Repositioned second and third function variables where they will fit within the 78 character line limit. Tidied up some comments.
-