Commit 69ba0da8 authored by Steve Holme's avatar Steve Holme
Browse files

pop3: Fixed the issue of having to supply the user name for all requests 

Previously it wasn't possible to connect to POP3 and not specify the
user name as a CURLE_ACCESS_DENIED error would be returned. This error
occurred because USER would be sent to the server with a blank user name
if no mailbox user was specified as the server would reply with -ERR.

This wasn't a problem prior to the 7.26.0 release but with the
introduction of custom commands the user and/or application developer
might want to issue a CAPA command without having to log in as a
specific mailbox user.

Additionally this fix won't send the newly introduced AUTH command if no
user name is specified.
parent 1fa2af51

RELEASE-NOTES

+1 −0
Original line number Original line Diff line number Diff line
@@ -14,6 +14,7 @@ This release includes the following changes: 




This release includes the following bugfixes:

This release includes the following bugfixes:





 o pop3: Fixed the issue of having to supply the user name for all requests

 o 

 o 





This release includes the following known bugs:

This release includes the following known bugs:

lib/pop3.c

+9 −1
Original line number Original line Diff line number Diff line
@@ -305,12 +305,20 @@ static void state(struct connectdata *conn, pop3state newstate) 




static CURLcode pop3_state_auth(struct connectdata *conn)

static CURLcode pop3_state_auth(struct connectdata *conn)

{

{

  CURLcode result;

  CURLcode result = CURLE_OK;

  struct pop3_conn *pop3c = &conn->proto.pop3c;

  struct pop3_conn *pop3c = &conn->proto.pop3c;





  pop3c->authmechs = 0;         /* No known authentication mechanisms yet */

  pop3c->authmechs = 0;         /* No known authentication mechanisms yet */

  pop3c->authused = 0;          /* Clear the authentication mechanism used */

  pop3c->authused = 0;          /* Clear the authentication mechanism used */





  /* Check we have a username and password to authenticate with and end the

     connect phase if we don't */

  if(!conn->bits.user_passwd) {

    state(conn, SMTP_STOP);



    return result;

  }



  /* send AUTH */

  /* send AUTH */

  result = Curl_pp_sendf(&pop3c->pp, "AUTH");

  result = Curl_pp_sendf(&pop3c->pp, "AUTH");