- 21 Aug, 2018 3 commits
-
-
Matt Caswell authored
Reviewed-by:Tim Hudson <tjh@openssl.org>
-
Matt Caswell authored
Reviewed-by:
-
Nicola Tuveri authored
The EFD database does not state that the "ladd-2002-it-3" algorithm assumes X1 != 0. Consequently the current implementation, based on it, fails to compute correctly if the affine x coordinate of the scalar multiplication input point is 0. We replace this implementation using the alternative algorithm based on Eq. (9) and (10) from the same paper, which being derived from the additive relation of (6) does not incur in this problem, but costs one extra field multiplication. The EFD entry for this algorithm is at https://hyperelliptic.org/EFD/g1p/auto-shortw-xz.html#ladder-ladd-2002-it-4 and the code to implement it was generated with tooling. Regression tests add one positive test for each named curve that has such a point. The `SharedSecret` was generated independently from the OpenSSL codebase with sage. This bug was originally reported by Dmitry Belyavsky on the openssl-users maling list: https://mta.openssl.org/pipermail/openssl-users/2018-August/008540.html Co-authored-by:
Billy Brumley <bbrumley@gmail.com> Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
-
- 20 Aug, 2018 3 commits
-
-
Matt Caswell authored
We already have SSL_set_post_handshake_auth(). This just adds the SSL_CTX equivalent. Reviewed-by:
-
Matt Caswell authored
Having post handshake auth automatically switched on breaks some applications written for TLSv1.2. This changes things so that an explicit function call is required for a client to indicate support for post-handshake auth. Fixes #6933. Reviewed-by:
-
Pauli authored
Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> Reviewed-by:
Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/6993)
-
- 19 Aug, 2018 5 commits
-
-
parasssh authored
CLA: trivial Reviewed-by:
-
Pauli authored
spurious output when checking for error conditions. Reviewed-by:
-
Dr. Matthias St. Pierre authored
Don't discard partial reads from /dev/*random and retry instead. Reviewed-by:
Paul Dale <paul.dale@oracle.com> Reviewed-by:
-
Dr. Matthias St. Pierre authored
Fixes #6978 Don't discard partial reads from syscall_random() and retry instead. Reviewed-by:
-
Dr. Matthias St. Pierre authored
Change return value type to ssize_t and ensure that a negative value is returned only if a corresponding errno is set. Reviewed-by:
-
- 18 Aug, 2018 2 commits
-
-
Andy Polyakov authored
The option has no meaning on Darwin, but it can bail out in combination with -fembed-bitcode or -no-integrated-as... Reviewed-by:Richard Levitte <levitte@openssl.org>
-
Dr. Matthias St. Pierre authored
Reviewed-by:
-
- 17 Aug, 2018 2 commits
-
-
Benjamin Kaduk authored
gcc 4.6 (arguably erroneously) warns about our use of 'free' as the name of a function parameter, when --strict-warnings is enabled: crypto/x509/x509_meth.c: In function 'X509_LOOKUP_meth_set_free': crypto/x509/x509_meth.c:61:12: error: declaration of 'free' shadows a global declaration [-Werror=shadow] cc1: all warnings being treated as errors make[1]: *** [crypto/x509/x509_meth.o] Error 1 (gcc 4.8 is fine with this code, as are newer compilers.) Reviewed-by:
-
Andy Polyakov authored
CRYPTO_atomic_read was added with intention to read statistics counters, but readings are effectively indistinguishable from regular load (even in non-lock-free case). This is because you can get out-dated value in both cases. CRYPTO_atomic_write was added for symmetry and was never used. Reviewed-by:
-
- 16 Aug, 2018 2 commits
-
-
Richard Levitte authored
Fixes #6980 Reviewed-by:
-
Andy Polyakov authored
Relax memory_order on counter decrement itself, because mutable members of the reference-counted structure should be visible on all processors independently on counter. [Even re-format and minimize dependency on other headers.] Reviewed-by:
-
- 15 Aug, 2018 4 commits
-
-
Matt Caswell authored
The TLSv1.4 tolerance test wasn't testing what we thought it was. Reviewed-by:
Ben Kaduk <kaduk@mit.edu> Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Pauli authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/6963)
-
- 14 Aug, 2018 4 commits
-
-
Tomas Mraz authored
If application explicitly calls CONF_modules_load_file() the SSL conf module will be initialized twice and the module data would leak. We need to free it before initializing it again. Fixes #6835 Reviewed-by:
-
Philip Prindeville authored
The logs are usually not looked at, and when they are it's almost always after they've completed and returned a status. That being the case, "progress" output is useless if it's always seen after the fact. Signed-off-by:
Philip Prindeville <philipp@redfish-solutions.com> Reviewed-by:
-
Dmitry Yakovlev authored
To avoid crash (same as #5138 fixed in 44f23cd2 ) CLA: trivial Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
- 13 Aug, 2018 1 commit
-
-
Andy Polyakov authored
Originally fopen(3) was called from bio/bss_file.c, which performed the aliasing. Then fopen(3) was moved to o_fopen.c, while "magic" definition was left behind. It's still useful on 32-bit platforms, so pull it to o_fopen.c. Reviewed-by:
-
- 12 Aug, 2018 2 commits
-
-
Richard Levitte authored
This allows the original path to be displayed when it's shown to be invalid, so the user can relate without question. Reviewed-by:
-
Richard Levitte authored
Extra slashes in paths are permissible in Unix-like platforms... however, when compared with the result from 'which', which returns canonical paths, the comparison might fail even though the compared paths may be equivalent. We make the NDK path canonical internally to ensure the equivalence compares as equal, at least for the most trivial cases. Fixes #6917 Reviewed-by:
-
- 11 Aug, 2018 1 commit
-
-
Richard Levitte authored
Since 0.9.7, all i2d_ functions were documented to allocate an output buffer if the user didn't provide one, under these conditions (from the 1.0.2 documentation): For OpenSSL 0.9.7 and later if B<*out> is B<NULL> memory will be allocated for a buffer and the encoded data written to it. In this case B<*out> is not incremented and it points to the start of the data just written. i2d_ASN1_OBJECT was found not to do this, and would crash if a NULL output buffer was provided. Fixes #6914 Reviewed-by:
-
- 09 Aug, 2018 5 commits
-
-
Pauli authored
to the now released RFC 8410. Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/6910)
-
Matt Caswell authored
Commit 88393244 removed some NULL checks from the stack code. This caused a no-comp build to fail in the client and server fuzzers. Reviewed-by:
-
Matt Caswell authored
This reverts commit 88393244 . Removing these checks changes the behaviour of the API which is not appropriate for a minor release. This also fixes a failure in the fuzz tests when building with no-comp. Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
A client that has fallen back could detect an inappropriate fallback if the TLSv1.3 downgrade protection sentinels are present. Fixes #6756 Reviewed-by:
-
- 08 Aug, 2018 4 commits
-
-
Matt Caswell authored
Test that a server can handle an unecrypted alert when normally the next message is encrypted. Reviewed-by:
-
Matt Caswell authored
At certain points in the handshake we could receive either a plaintext or an encrypted alert from the client. We should tolerate both where appropriate. Reviewed-by:
-
Matt Caswell authored
If we sent early_data and then received back an HRR, the enc_write_ctx was stale resulting in errors if an alert needed to be sent. Thanks to Quarkslab for reporting this. In any case it makes little sense to encrypt alerts using the client_early_traffic_secret, so we add special handling for alerts sent after early_data. All such alerts are sent in plaintext. Reviewed-by:
-
Matt Caswell authored
Under certain error conditions a call to SSLfatal could accidently be missed. Reviewed-by:
-
- 07 Aug, 2018 2 commits
-
-
Dr. Matthias St. Pierre authored
In 38eca7fe a new check for the pem_str member of the entries of the ASN1 method table was introduced. Because the test condition was split into two TEST_true(...) conditions, the test outputs error diagnostics for all entries which have pem_str != NULL. This commit joins the two test conditions into a single condition. Reviewed-by:
-
Rich Salz authored
Also add build-time errors to keep them in sync. Thanks to GitHub user YuDudysheva for reporting this. Reviewed-by:
-
