- 15 Aug, 2017 3 commits
-
-
Richard Levitte authored
There already is a scrypt.c in crypto/kdf/, both becoming script.o or script.obj. With some linkers, the same object files name more than once means one of them is dropped, either when building shared libraries or when building executables from static libraries. Reviewed-by:
Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4164)
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4069)
-
Richard Levitte authored
Instead of having perl modules under test/testlib, util and util/perl, consolidate them all to be inside util/perl. Reviewed-by:
-
- 14 Aug, 2017 2 commits
-
-
Rich Salz authored
Reviewed-by:
Paul Dale <paul.dale@oracle.com> Reviewed-by:
Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/4160)
-
Rich Salz authored
Write missing prime.pod and srp.pod Implement -c in find-doc-nits (for command options) Other fixes to some manpages Use B<-I<digest|cipher>> notation Split up multiple flags into a single entry in the synopsis. Add -1 and missing-help to list command. Reviewed-by:
-
- 13 Aug, 2017 1 commit
-
-
Rich Salz authored
Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/4150)
-
- 12 Aug, 2017 4 commits
-
-
FdaSilvaYY authored
[skip ci] Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4149)
-
Andy Polyakov authored
Reviewed-by: -
Andy Polyakov authored
Reviewed-by:
-
Andy Polyakov authored
Reviewed-by:
-
- 11 Aug, 2017 5 commits
-
-
Johannes Bauer authored
This fixes issue #3043, which ultimately was reported because documentation was not clear on the meaning of the "-ignore_err" option. Update both command line documentation and add this option to manpage. Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
Rich Salz authored
Use an inline rand.inc; this fixes Google's OSS-Fuzz builds. Reviewed-by:
-
Jon Spillett authored
Reviewed-by:
-
Jon Spillett authored
Reviewed-by:
-
- 10 Aug, 2017 4 commits
-
-
Dr. Stephen Henson authored
Fix warning and don't use binary field certificate for ECDH CMS key only test. Reviewed-by:
-
Dr. Stephen Henson authored
Reviewed-by:
-
Dr. Stephen Henson authored
Reviewed-by:
-
David von Oheimb authored
Discussion is in https://github.com/openssl/openssl/issues/4127 Reviewed-by:
-
- 09 Aug, 2017 9 commits
-
-
Benjamin Kaduk authored
If s->hit is set, s->session corresponds to a session created on a previous connection, and is a data structure that is potentially shared across other SSL objects. As such, there are thread-safety issues with modifying the structure without taking its lock (and of course all corresponding read accesses would also need to take the lock as well), which have been observed to cause double-frees. Regardless of thread-safety, the resumed session object is intended to reflect parameters of the connection that created the session, and modifying it to reflect the parameters from the current connection is confusing. So, modifications to the session object during ClientHello processing should only be performed on new connections, i.e., those where s->hit is not set. The code mostly got this right, providing such checks when processing SNI and EC point formats, but the supported groups (formerly supported curves) extension was missing it, which is fixed by this commit. However, TLS 1.3 makes the suppported_groups extension mandatory (when using (EC)DHE, which is the normal case), checking for the group list in the key_share extension processing. But, TLS 1.3 only [0] supports session tickets for session resumption, so the session object in question is the output of d2i_SSL_SESSION(), and will not be shared across SSL objects. Thus, it is safe to modify s->session for TLS 1.3 connections. [0] A psk_find_session callback can also be used, but the restriction that each callback execution must produce a distinct SSL_SESSION structure can be documented when the psk_find_session callback documentation is completed. Reviewed-by:
-
Tomas Mraz authored
Reviewed-by:
-
Benjamin Kaduk authored
When we are using the internal cache we have to make a copy of the session before removing it from the parent context's cache, since we want our copy to still be resumable. However, SSL_CTX_remove_session() just detaches the session from the SSL_CTX; it does not free the session. So, we must call SSL_SESSION_free() ourselves before overwriting the variable that we dup'd from. Reviewed-by:
-
Rich Salz authored
Reviewed-by:
-
Xiaoyin Liu authored
In the generated HTML document, the `<pre>` tag is not closed. This patch also has a trivial code-style improvement, unrelated to the bug fix. Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
-
Paul Yang authored
Code Health (Tuesday?): Parameters' names are not correct. Reviewed-by:
-
Paul Yang authored
This is a 'code health' commit to respond to this round of code health Tuesday... Reviewed-by:
-
Matt Caswell authored
In particular this covers the scenario mentioned in #4014 Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
- 08 Aug, 2017 6 commits
-
-
Johannes Bauer authored
Building without the scrypt KDF is now possible, the OPENSSL_NO_SCRYPT define is honored in code. Previous this lead to undefined references. Reviewed-by:
Stephen Henson <steve@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4116)
-
Dr. Stephen Henson authored
Reviewed-by:
-
Dr. Stephen Henson authored
Reviewed-by:
-
Johannes Bauer authored
Added manpage for the new scrypt EVP_PKEY_METHOD KDF interface. Reviewed-by:
-
Johannes Bauer authored
Added the pkey_meth_kdf_test tests which test the PKEY_METHOD macros (at the moment, of HKDF and scrypt). Reviewed-by:
-
Johannes Bauer authored
Add an interface that allows accessing the scrypt KDF as a PKEY_METHOD. This fixes #4021 (at least for the scrypt portion of the issue). Reviewed-by:
-
- 07 Aug, 2017 3 commits
-
-
Rich Salz authored
Try to put DRBG and rand_bytes buffers in secure heap Read the TSC fewer times (but it's still not enabled). Short-circuit return in win RAND_poll_ex; other minor tweaks and format-fixes. Use the _bytes version of rdrand/rdseed Fix ia32cap checks. Reviewed-by:
Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/4100)
-
Bernd Edlinger authored
Reviewed-by:
-
Rich Salz authored
Use atfork to count child forks, and reseed DRBG when the counts don't match. Reviewed-by:
-
- 06 Aug, 2017 3 commits
-
-
Pauli authored
reference not by value. This allows an error return from the setup function. Reviewed-by:
-
Rich Salz authored
Also use "" not <> for all include cryptlib Reviewed-by:
-
Dr. Stephen Henson authored
The test ENGINE effectively used a predictable PRNG because it supplied a bogus implementation of SHA256 which the old version of OpenSSL's PRNG used. The new DRBG does not use SHA256 so it is no longer predictable if the SHA256 implementation is replaced. Use an explicit predictable PRNG instead. Reviewed-by:
-
