- 20 Jul, 2016 12 commits
-
-
Matt Caswell authored
This is adapted from BoringSSL commit 2f87112b963. This fixes a number of bugs where the existence of bbio was leaked in the public API and broke things. - SSL_get_wbio returned the bbio during the handshake. It must always return the BIO the consumer configured. In doing so, some internal accesses of SSL_get_wbio should be switched to ssl->wbio since those want to see bbio. - The logic in SSL_set_rfd, etc. (which I doubt is quite right since SSL_set_bio's lifetime is unclear) would get confused once wbio got wrapped. Those want to compare to SSL_get_wbio. - If SSL_set_bio was called mid-handshake, bbio would get disconnected and lose state. It forgets to reattach the bbio afterwards. Unfortunately, Conscrypt does this a lot. It just never ended up calling it at a point where the bbio would cause problems. - Make more explicit the invariant that any bbio's which exist are always attached. Simplify a few things as part of that. RT#4572 Reviewed-by:Richard Levitte <levitte@openssl.org>
-
Emilia Kasper authored
Systematically test every server-side version downgrade or upgrade. Client version upgrade or downgrade could be tested analogously but will be done in a later change. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Dr. Stephen Henson authored
Reviewed-by: -
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Fix some indentation at the same time Reviewed-by:
-
Hannes Magnusson authored
f0e0fd51 added X509_STORE_CTX_set_verify_cb with a typedef'd argument, making the original one redundant. Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Fix some code indentation Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
Todd Short authored
There are two failure cases for OCSP_request_add_id(): 1. OCSP_ONEREQ_new() failure, where |cid| is not freed 2. sk_OCSP_ONEREQ_push() failure, where |cid| is freed This changes makes the error behavior consistent, such that |cid| is not freed when sk_OCSP_ONEREQ_push() fails. OpenSSL only takes ownership of |cid| when the function succeeds. Reviewed-by:
-
- 19 Jul, 2016 28 commits
-
-
Dr. Stephen Henson authored
RT#4600 Reviewed-by: -
Dr. Stephen Henson authored
RT#4610 Reviewed-by: -
Coty Sutherland authored
Reviewed-by:
-
Richard Levitte authored
Reviewed-by:Kurt Roeckx <kurt@openssl.org>
-
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
That way, we have a way to check if the init function was successful or not. Reviewed-by: -
Richard Levitte authored
Because pthread_once() takes a function taking no argument and returning nothing, and we want to be able to check if they're successful, we define a few internal macros to get around the issue. Reviewed-by: -
Rich Salz authored
Update find-doc-nits to find errors in SYNOPSIS (the most common place where they were missing). Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Matt Caswell authored
The new fuzzing code broke no-cms Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Emilia Kasper authored
- Always process ALPN (previously there was an early return in the certificate status handling) - Don't send a duplicate alert. Previously, both ssl_check_clienthello_tlsext_late and its caller would send an alert. Consolidate alert sending code in the caller. Reviewed-by: -
Emilia Kasper authored
Reviewed-by: -
mrpre authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by: -
Matt Caswell authored
After the refactor of tls_process_key_exchange(), this commit tidies up some loose ends. Reviewed-by: -
Matt Caswell authored
Continuing from the previous commit. Refactor tls_process_key_exchange() to split out into a separate function the ECDHE aspects. Reviewed-by: -
Matt Caswell authored
Continuing from the previous commit. Refactor tls_process_key_exchange() to split out into a separate function the DHE aspects. Reviewed-by: -
Matt Caswell authored
Continuing from the previous commit. Refactor tls_process_key_exchange() to split out into a separate function the SRP aspects. Reviewed-by: -
Matt Caswell authored
The tls_process_key_exchange() function is too long. This commit starts the process of splitting it up by moving the PSK preamble code to a separate function. Reviewed-by: -
Matt Caswell authored
The function tls_process_key_exchange() is too long. This commit moves the PSK preamble processing out to a separate function. Reviewed-by: -
Matt Caswell authored
Narrow the scope of the local vars in preparation for split up this function. Reviewed-by: -
Matt Caswell authored
Add some more tests for sessions following on from the previous commit to ensure the callbacks are called when appropriate. Reviewed-by: -
Matt Caswell authored
If the SSL_SESS_CACHE_NO_INTERNAL_STORE cache mode is used then we weren't removing sessions from the external cache, e.g. if an alert occurs the session is supposed to be automatically removed. Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
Reviewed-by:
-
