- Dec 14, 2014
-
-
Marc Hoersken authored
-
Marc Hoersken authored
The >= 0 is actually not required, since i underflows and the for-loop is stopped using the < condition, but this makes the VS2012 compiler and code analysis happy.
-
Marc Hoersken authored
Fixes code analysis warning C6031: return value ignored: <function> could return unexpected value
-
Marc Hoersken authored
warning C28252: Inconsistent annotation for function: parameter has another annotation on this instance
-
Steve Holme authored
smb.c:320: warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Result may not be an expected value
-
Marc Hoersken authored
-
Steve Holme authored
Rather than testing against _WIN32 use the preferred HAVE_PROCESS_H pre-processor define when including process.h.
-
Daniel Stenberg authored
... to avoid using a fixed memory size that risks being too large or too small.
-
Marc Hoersken authored
- do not grow memory by doubling its size - do not leak previously allocated memory if reallocation fails - replace while-loop with a single check to make sure that the requested amount of data fits into the buffer Bug: http://curl.haxx.se/bug/view.cgi?id=1450 Reported-by: Warren Menzer
-
Steve Holme authored
-
Marc Hoersken authored
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
There is no need to set the 'state' and 'result' member variables to SMB_REQUESTING (0) and CURLE_OK (0) after the allocation via calloc() as calloc() initialises the contents to zero.
-
Steve Holme authored
Use CURLE_BAD_CONTENT_ENCODING for bad type-2 Target Info security buffers just like we do for bad decodes.
-
Steve Holme authored
I don't think both of my fix ups from yesterday were needed to fix the compilation warning, so remove the one that I think is unnecessary and let the next Android autobuild prove/disprove it.
-
- Dec 13, 2014
-
-
Steve Holme authored
curl_ntlm_msgs.c:170: warning: conversion to 'short unsigned int' from 'int' may alter its value
-
Guenter Knauf authored
-
Steve Holme authored
-
Steve Holme authored
curl_ntlm_msgs.c:169: warning: conversion to 'short unsigned int' from 'int' may alter its value
-
Guenter Knauf authored
-
Guenter Knauf authored
worldtimeserver.com seems also no longer available.
-
Guenter Knauf authored
For getting the date header its not necessary to access special pages or even CGI scripts - all pages including the main index reply with the date header, therefore shortened URLs to domain. Removed worldtime.com; added pool.ntp.org.
-
Steve Holme authored
ftp.c:819: warning: unused parameter 'lineno'
-
Steve Holme authored
For debugging purposes, and as per other protocols within curl, added state change functions rather than changing the states directly.
-
Steve Holme authored
-
- Dec 12, 2014
-
-
Steve Holme authored
-
Steve Holme authored
smtp.c:2357 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string smtp.c:2375 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string smtp.c:2386 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string Used array index notation instead.
-
Steve Holme authored
This fixes compilation issues with compilers that don't support 64-bit integers through long long or __int64.
-
Steve Holme authored
This fixes compilation issues with compilers that don't support 64-bit integers through long long or __int64 which was introduced in commit 07b66cbf.
-
Steve Holme authored
Previously USE_NTLM2SESSION would only be defined automatically when USE_NTRESPONSES wasn't already defined. Separated the two definitions so that the user can manually set USE_NTRESPONSES themselves but USE_NTLM2SESSION is defined automatically if they don't define it.
-
Steve Holme authored
-
Steve Holme authored
As the OpenSSL and NSS Crypto engines are prefered by the core NTLM routines, to the Windows Crypt API, don't define USE_WIN32_CRYPT automatically when either OpenSSL or NSS are in use - doing so would disable NTLM2Session responses in NTLM type-3 messages.
-
Steve Holme authored
If the scratch buffer was allocated in a previous call to Curl_smtp_escape_eob(), a new buffer not allocated in the subsequent call and no action taken by that call, then an attempt would be made to try and free the buffer which, by now, would be part of the data->state structure. This bug was introduced in commit 4bd860a0.
-
Steve Holme authored
Fixed a problem with the CRLF. detection when multiple buffers were used to upload an email to libcurl and the line ending character(s) appeared at the end of each buffer. This meant any lines which started with . would not be escaped into .. and could be interpreted as the end of transmission string instead. This only affected libcurl based applications that used a read function and wasn't reproducible with the curl command-line tool. Bug: http://curl.haxx.se/bug/view.cgi?id=1456 Assisted-by: Patrick Monnerat
-
- Dec 11, 2014
-
-
Daniel Stenberg authored
-
- Dec 10, 2014
-
-
Daniel Stenberg authored
... and I could use a break instead of a goto to end the loop. Bug: http://curl.haxx.se/mail/lib-2014-12/0089.html Reported-by: Tor Arntsen
-
Steve Holme authored
Added some bug fixes that I had missed in previous synchronisations.
-
Daniel Stenberg authored
I suspect this causes compile failures on Solaris: Bug: http://curl.haxx.se/mail/lib-2014-12/0081.html
-
Steve Holme authored
url.c:3078: warning: variable 'credentialsMatch' set but not used
-