- 01 Mar, 2019 1 commit
-
-
Daniel Stenberg authored
in the same sftp_done function in both SSH backends. Simplify them somewhat. Pointed out by Codacy. Closes #3628
-
- 28 Feb, 2019 7 commits
-
-
Daniel Stenberg authored
-
Daniel Stenberg authored
Introduced in 8b6314cc, but not used anymore in current code. Unclear since when. Closes #3626
-
Daniel Stenberg authored
Without it set, we would unwillingly triger the "HTTP error before end of send, stop sending" condition even if the entire POST body had been sent (since it wouldn't know the expected size) which would unnecessarily log that message and close the connection when it didn't have to. Reported-by: Matt McClure Bug: https://curl.haxx.se/mail/archive-2019-02/0023.html Closes #3624
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
Everyone calls it Secure Transport, now we do too. Reviewed-by: Nick Zitzmann Closes #3619
-
- 27 Feb, 2019 7 commits
-
-
Marcel Raad authored
But use the MSYS2 shell rather than the default MSYS shell because of POSIX path conversion issues. Classic MinGW is only available on the Visual Studio 2015 image. Closes https://github.com/curl/curl/pull/3623
-
Marcel Raad authored
Add a MinGW-w64 build using CMake's MSYS Makefiles generator. Use the Visual Studio 2015 image as it has GCC 8, while the Visual Studio 2017 image only has GCC 7.2. Closes https://github.com/curl/curl/pull/3623
-
Daniel Stenberg authored
Follow-up to 8eddb8f4. If the cookieinfo pointer is NULL there really is nothing to save. Without this fix, we got a problem when a handle was using shared object with cookies and is told to "FLUSH" it to file (which worked) and then the share object was removed and when the easy handle was closed just afterwards it has no cookieinfo and no cookies so it decided to save an empty jar (overwriting the file just flushed). Test 1905 now verifies that this works. Assisted-by: Michael Wallner Assisted-by: Marcel Raad Closes #3621
-
DaVieS authored
Closes #3421
-
Daniel Stenberg authored
This allows the compiler to pack and align the structs better in memory. For a rather feature-complete build on x86_64 Linux, gcc 8.1.2 makes the Curl_easy struct 4.9% smaller. From 6312 bytes to 6000. Removed an unused struct field. No functionality changes. Closes #3610
-
Don J Olmstead authored
Closes #3616
-
Daniel Stenberg authored
Closes #3611
-
- 26 Feb, 2019 8 commits
-
-
Daniel Stenberg authored
Follow-up to 180501cb Reported-by: Marcel Raad Fixes #3609 Closes #3620
-
Marcel Raad authored
Switch all Visual Studio 2015 builds to Visual Studio 2017. It's not a moving target anymore as the last update, Update 9, has been released. Closes https://github.com/curl/curl/pull/3606
-
Marcel Raad authored
The Visual Studio 2017 image has Visual Studio 2015 and 2017 installed. Closes https://github.com/curl/curl/pull/3606
-
Marcel Raad authored
Currently, we're using the default Visual Studio 2015 image for everything. Closes https://github.com/curl/curl/pull/3606
-
Daniel Stenberg authored
Instead of using a fixed 256 byte buffer in the connectdata struct. In my build, this reduces the size of the connectdata struct by 11.8%, from 2160 to 1904 bytes with no functionality or performance loss. This also fixes a bug in schannel's Curl_verify_certificate where it called Curl_sspi_strerror when it should have called Curl_strerror for string from GetLastError. the only effect would have been no text or the wrong text being shown for the error. Co-authored-by: Jay Satiro Closes #3612
-
Michael Wallner authored
Regression brought by a52e46f3 (shipped in 7.63.0) Closes #3613
-
Marcel Raad authored
It's passing now. Closes https://github.com/curl/curl/pull/3615
-
Marcel Raad authored
Remove the Visual Studio 2012 and 2013 builds as they add little value. Ref: https://github.com/curl/curl/pull/3606 Closes https://github.com/curl/curl/pull/3614
-
- 25 Feb, 2019 4 commits
-
-
Daniel Stenberg authored
-
Bernd Mueller authored
Closes #3591
-
Michael Felt authored
- Add an additional check for LDAP that also checks for OpenSSL since on AIX those libraries may be required to link LDAP properly. Fixes https://github.com/curl/curl/issues/3595 Closes https://github.com/curl/curl/pull/3596
-
georgeok authored
Add support for Ephemeral elliptic curve Diffie-Hellman key exchange algorithm option when selecting ciphers. This became available on the Win10 SDK. Closes https://github.com/curl/curl/pull/3608
-
- 24 Feb, 2019 1 commit
-
-
Daniel Stenberg authored
Failing to do so would make the CURLINFO_TOTAL_TIME timeout to not get updated correctly and could end up getting reported to the application completely wrong (way too small). Reported-by: accountantM on github Fixes #3602 Closes #3605
-
- 23 Feb, 2019 3 commits
-
-
Daniel Stenberg authored
From within the timer callbacks. Recursive is problematic for several reasons. They should still work, but this way the examples and the documentation becomes simpler. I don't think we need to encourage recursive calls. Discussed in #3537 Closes #3601
-
Marcel Raad authored
The macro itself has been removed in commit 11974ac8. Closes https://github.com/curl/curl/pull/3604
-
Daniel Stenberg authored
since wolfSSL PR https://github.com/wolfSSL/wolfssl/pull/717 (shipped in wolfSSL 3.10.2 and later) it sends these curves by default already. Pointed-out-by: David Garske Closes #3599
-
- 22 Feb, 2019 3 commits
-
-
Daniel Stenberg authored
and the two remaining #ifdefs for it Closes #3600
-
Jay Satiro authored
- Split off connection shutdown procedure from Curl_disconnect into new function conn_shutdown. - Change the shutdown procedure to close the sockets before disassociating the transfer. Prior to this change the sockets were closed after disassociating the transfer so SOCKETFUNCTION wasn't called since the transfer was already disassociated. That likely came about from recent work started in Jan 2019 (#3442) to separate transfers from connections. Bug: https://curl.haxx.se/mail/lib-2019-02/0101.html Reported-by: Pavel Löbl Closes https://github.com/curl/curl/issues/3597 Closes https://github.com/curl/curl/pull/3598
-
Marcel Raad authored
As seen in the MinGW autobuilds. Caused by commit f26bc29c.
-
- 21 Feb, 2019 1 commit
-
-
Dan Fandrich authored
-
- 20 Feb, 2019 5 commits
-
-
Daniel Stenberg authored
Suggested-by: Nicolas Grekas
-
Daniel Stenberg authored
-
Daniel Stenberg authored
... and remove it from the dist tarball. It has served its time, it barely gets updated anymore and "everything curl" is now convering all this document once tried to include, and does it more and better. In the compressed scenario, this removes ~15K data from the binary, which is 25% of the -M output. It remains in the git repo for now for as long as the web site builds a page using that as source. It renders poorly on the site (especially for mobile users) so its not even good there. Closes #3587
-
Daniel Stenberg authored
RFC 7540 says we should verify that the push is for an "authoritative" server. We make sure of this by only allowing push with an :athority header that matches the host that was asked for in the URL. Fixes #3577 Reported-by: Nicolas Grekas Bug: https://curl.haxx.se/mail/lib-2019-02/0057.html Closes #3581
-
Daniel Stenberg authored
The variable wasn't properly reset within the loop and thus could remain set for sockets that hadn't been set before and miss notifying the app. This is a follow-up to 4c35574b (shipped in curl 7.64.0) Reported-by: buzo-ffm on github Detected-by: Jan Alexander Steffens Fixes #3585 Closes #3589
-