- 21 Sep, 2016 1 commit
-
-
Matt Caswell authored
We should check the last BN_CTX_get() call to ensure that it isn't NULL before we try and use any of the allocated BIGNUMs. Issue reported by Shi Lei. Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 1ff7425d)
-
- 20 Sep, 2016 2 commits
-
-
Richard Levitte authored
Check arg count and print an error message. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Marcus Meissner authored
This helps with program code linked against static builds accessing a uninitialized ->engine pointer. CLA: none; trivial Reviewed-by:
Tim Hudson <tjh@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1540)
-
- 15 Sep, 2016 11 commits
-
-
Dr. Stephen Henson authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
This reverts commit 15d81749 . There were some unexpected side effects to this commit, e.g. in SSLv3 a warning alert gets sent "no_certificate" if a client does not send a Certificate during Client Auth. With the above commit this causes the connection to abort, which is incorrect. There may be some other edge cases like this so we need to have a rethink on this. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
This is needed, because on VMS, select() can only be used on sockets. being able to use select() on all kinds of file descriptors is unique to Unix. So, the solution for VMS is to create a layer that translates input from standard input to socket communication. Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Dr. Stephen Henson authored
Backport leak fix from master branch. Thanks to Shi Lei (Gear Team, Qihoo 360 Inc.) for reporting this bug. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Dr. Stephen Henson authored
Thanks to Shi Lei (Gear Team, Qihoo 360 Inc.) for reporting this bug. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
This fixes the following error when building with no particular pointer size is specified (implied 32 bit): static void *(*realloc_func) (void *, size_t) = realloc; ................................................^ %CC-E-UNDECLARED, In the initializer for realloc_func, "_realloc32" is not declared. at line number 93 in file DEV:[OPENSSL102.crypto]mem.c;1 Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
- 14 Sep, 2016 1 commit
-
-
Matt Caswell authored
The internal SRP function t_fromb64() converts from base64 to binary. It does not validate that the size of the destination is sufficiently large - that is up to the callers. In some places there was such a check, but not in others. Add an argument to t_fromb64() to provide the size of the destination buffer and validate that we don't write too much data. Also add some sanity checks to the callers where appropriate. With thanks to Shi Lei for reporting this issue. Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 73f0df83)
-
- 13 Sep, 2016 1 commit
-
-
Matt Caswell authored
A peer continually sending unrecognised warning alerts could mean that we make no progress on a connection. We should abort rather than continuing if we receive an unrecognised warning alert. Thanks to Shi Lei for reporting this issue. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 12 Sep, 2016 1 commit
-
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 11 Sep, 2016 1 commit
-
-
Dr. Stephen Henson authored
Backport leak fix from master branch. Thanks to Shi Lei for reporting this bug. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 09 Sep, 2016 1 commit
-
-
Rich Salz authored
Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
- 08 Sep, 2016 1 commit
-
-
Richard Levitte authored
VMS sets that errno when the device part of a file spec is malformed or a logical name that doesn't exist. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit e82e2186)
-
- 07 Sep, 2016 1 commit
-
-
David Woodhouse authored
Some hardware devices don't provide the public EC_POINT data. The only way for X509_check_private_key() to validate that the key matches a given certificate is to actually perform a sign operation and then verify it using the public key in the certificate. Maybe that can come later, as discussed in issue 1532. But for now let's at least make it fail gracefully and not crash. GH: 1532 Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1547) (cherry picked from commit 92ed7fa5)
-
- 06 Sep, 2016 1 commit
-
-
Rich Salz authored
Never output -0; make "negative zero" an impossibility. Do better checking on BN_rand top/bottom requirements and #bits. Update doc. Ignoring trailing garbage in BN_asc2bn. Port this commit from boringSSL: https://boringssl.googlesource.com/boringssl/+/899b9b19a4cd3fe526aaf5047ab9234cdca19f7d%5E!/ Ensure |BN_div| never gives negative zero in the no_branch code. Have |bn_correct_top| fix |bn->neg| if the input is zero so that we don't have negative zeros lying around. Thanks to Brian Smith for noticing. Reviewed-by:
Richard Levitte <levitte@openssl.org> (cherry picked from commit 01c09f9f) (Some manual work required)
-
- 31 Aug, 2016 1 commit
-
-
Andy Polyakov authored
crypto/bn/*: x86[_64] division instruction doesn't handle constants, change constraint from 'g' to 'r'. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Tim Hudson <tjh@openssl.org> (cherry picked from commit 68b4a6e9)
-
- 30 Aug, 2016 1 commit
-
-
Matt Caswell authored
The function tls_construct_cert_status() is called by both TLS and DTLS code. However it only ever constructed a TLS message header for the message which obviously failed in DTLS. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 26 Aug, 2016 11 commits
-
-
Matt Caswell authored
OPENSSL_cleanse() does not validate its input parameter for NULL so SRP_create_verifier() should do so instead. Otherwise a segfault will result. Alternative solution to GitHub PR#1006 Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
The definition of STITCHED_CALL relies on OPENSSL_NO_ASM. However, when a configuration simply lacks the assembler implementation for RC4 (which is where we have implemented the stitched call), OPENSSL_NO_ASM isn't implemented. Better, then, to rely on specific macros that indicated that RC4 (and MD5) are implemented in assembler. For this to work properly, we must also make sure Configure adds the definition of RC4_ASM among the C flags. (partly cherry picked from commit 216e8d91 ) Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
FdaSilvaYY authored
Fix a possible leak on NETSCAPE_SPKI_verify failure. Backport of 0517538d Backport of f6c006ea Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
David Woodhouse authored
(Modified for 1.0.2 by adding selected PACKET_xx() functions and PRF, and subsequent cleanup from commit eb633d03 ) Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (cherry picked from commit 40425899200a3dea9ec3684d3eb80bcf50c99baf)
-
David Woodhouse authored
Baroque, almost uncommented code triggers behaviour which is undefined by the C standard. You might quite reasonably not care that the code was broken on ones-complement machines, but if we support a ubsan build then we need to at least pretend to care. It looks like the special-case code for 64-bit big-endian is going to behave differently (and wrongly) on wrap-around, because it treats the values as signed. That seems wrong, and allows replay and other attacks. Surely you need to renegotiate and start a new epoch rather than wrapping around to sequence number zero again? Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (cherry picked from commit 2e94723c)
-
David Woodhouse authored
Commit d8e8590e ("Fix missing return value checks in SCTP") made the DTLS handshake fail, even for non-SCTP connections, if SSL_export_keying_material() fails. Which it does, for DTLS1_BAD_VER. Apply the trivial fix to make it succeed, since there's no real reason why it shouldn't even though we never need it. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (cherry picked from commit c8a18468)
-
Matt Caswell authored
This also fixes no-tls which is an alias for no-tls1 in 1.0.2 (it is not possible to do no-tls1_1 or no-tls1_2 in 1.0.2). Because it is not possible to disable TLS1.1 or TLS1.2 it no longer follows that disabling TLS1.0 should force the disabling of tlsext. Also a few missing ifdef guards. GitHub Iusse#935 Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (cherry picked from commit d3034d31)
-
Andy Polyakov authored
RT#4625 Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit e3057a57)
-
Andy Polyakov authored
Addition was not preserving inputs' property of being fully reduced. Thanks to Brian Smith for reporting this. Reviewed-by:
Rich Salz <rsalz@openssl.org> (cherry picked from commit b62b2454)
-
Todd Short authored
Sessions are stored on the session_ctx, which doesn't change after SSL_set_SSL_CTX(). Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
- 24 Aug, 2016 3 commits
-
-
Dr. Stephen Henson authored
Thanks to Shi Lei for reporting this issue. CVE-2016-6303 Reviewed-by:
Matt Caswell <matt@openssl.org> (cherry picked from commit 55d83bf7)
-
Rich Salz authored
Reviewed-by:
Viktor Dukhovni <viktor@openssl.org> Reviewed-by:
Emilia Käsper <emilia@openssl.org>
-
Matt Caswell authored
Use a ciphersuite in dtlstest that is not affected by no-* options. Backport of commit fe34735c . Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
- 23 Aug, 2016 1 commit
-
-
Dr. Stephen Henson authored
If a ticket callback changes the HMAC digest to SHA512 the existing sanity checks are not sufficient and an attacker could perform a DoS attack with a malformed ticket. Add additional checks based on HMAC size. Thanks to Shi Lei for reporting this bug. CVE-2016-6302 Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 22 Aug, 2016 1 commit
-
-
Richard Levitte authored
We don't really have a mechanism to include other object files into a given test program. For now, a simple hack in mk1mf.pl will do. RT#4653 Reviewed-by:
Rich Salz <rsalz@openssl.org>
-