- Aug 09, 2012
-
-
Kamil Dudka authored
... and make the list of cipher-suites in nss.c readable by humans. Bug: http://curl.haxx.se/mail/archive-2012-08/0016.html
-
Kamil Dudka authored
-
- Aug 08, 2012
-
-
Armel Asselin authored
CURLSSH_AUTH_AGENT is a new auth type for SSH
-
Daniel Stenberg authored
Fixed this (harmless) clang-analyzer warning. Also fixed the source indentation level.
-
Daniel Stenberg authored
By reading the ->head pointer and using that instead of the ->size number to figure out if there's a list remaining we avoid the (false positive) clang-analyzer warning that we might dereference of a null pointer.
-
Daniel Stenberg authored
I suspect this is a regression introduced in commit 207cf150, included since 7.24.0. Avoid showing '(nil)' as hostname in verbose output by making sure the hostname fixup function is called early enough to set the pointers that are used for this. The name data is set again for each request even for re-used connections to handle multiple hostnames over the same connection (like with proxy) or that the casing etc of the host name is changed between requests (which has proven to be important at least once in the past). Test1011 was modified to use a redirect with a re-used a connection since it then showed the bug and now lo longer does. There's currently no easy way to have the test suite detect 'nil' texts in verbose ouputs so no tests will detect if this problem gets reintroduced. Bug: http://curl.haxx.se/mail/lib-2012-07/0111.html Reported by: Gisle Vanem
-
- Aug 07, 2012
-
-
Mike Crowe authored
Ensure that the copy of the CURLOPT_INTERFACE string is freed if we decide we can reuse an existing connection.
-
Daniel Stenberg authored
This is the same fix applied for the conditional code that uses select() that was already done for the poll specific code in commit b61e8b81.
-
Maxime Larocque authored
We found a problem with ftp transfer using libcurl (7.23 and 7.25) inside an application which is receiving unix signals (SIGUSR1, SIGUSR2...) almost continuously. (Linux 2.4, PowerPC, HAVE_POLL_FINE defined). Curl_socket_check() uses poll() to wait for the socket, and retries it when a signal is received (EINTR). However, if a signal is received and it also happens that the timeout has been reached, Curl_socket_check() returns -1 instead of 0 (indicating an error instead of a timeout). In our case, the result is an aborted connection even before the ftp banner is received from the server, and a return value of CURLE_OUT_OF_MEMORY from curl_easy_perform() (Curl_pp_multi_statemach(), in pingpong.c, actually returns OOM if Curl_socket_check() fails :-) Funny to debug on a system on which OOM is a possible cause). Bug: http://curl.haxx.se/mail/lib-2012-07/0122.html
-
Daniel Stenberg authored
Due to WSAPoll bugs, libcurl does not work as intended. When the cURL library is used to setup a connection to an incorrect port, normally the result is CURLE_COULDNT_CONNECT, /* 7 */, but due to the bug in WSAPoll, the result now is CURLE_OPERATION_TIMEDOUT, /* 28 - the timeout time was reached */. On August 1, Jan Koen Annot opened a case for this to Microsoft Premier Online (https://premier.microsoft.com/). The support engineer handling the case wrote that the case description is quite clear. He will try to reproduce the issue and then proceed with troubleshooting it. Reported by: Jan Koen Annot Bug: http://curl.haxx.se/mail/lib-2012-07/0310.html
-
Daniel Stenberg authored
When figuring out if the data stream needs to be rewound when the request is to be resent, we must not access the HTTP struct unless the protocol used is indeed HTTP... Bug: http://curl.haxx.se/bug/view.cgi?id=3544688
-
Daniel Stenberg authored
This fixes a build failure of lib/ssluse.c. Bug: http://curl.haxx.se/bug/view.cgi?id=3552997
-
- Aug 06, 2012
-
-
Daniel Stenberg authored
Bug: http://curl.haxx.se/bug/view.cgi?id=3554668 Reported by: Anthony G. Basile
-
- Aug 03, 2012
- Jul 30, 2012
-
-
Kamil Dudka authored
It eliminates noisy events when using inotify and fixes a TOCTOU issue. Bug: https://bugzilla.redhat.com/844385
-
- Jul 27, 2012
-
-
Guenter Knauf authored
-
Guenter Knauf authored
-
- Jul 26, 2012
-
-
Guenter Knauf authored
Synced the output to the same short form as we now use for Windows SSL (WinSSL).
-
- Jul 25, 2012
-
-
Nick Zitzmann authored
Previously the curl_multi interface would freeze if darwinssl was enabled and at least one of the handles tried to connect to a Web site using HTTPS. Removed the "wouldblock" state darwinssl was using because I figured out a solution for our "would block but in which direction?" dilemma.
-
Guenter Knauf authored
-
- Jul 22, 2012
-
-
Daniel Stenberg authored
DragonFly uses milliseconds, while our API and Linux use full seconds. Reported by: John Marino Bug: http://curl.haxx.se/bug/view.cgi?id=3546257
-
Kamil Dudka authored
Bug: https://bugzilla.redhat.com/676596
-
- Jul 21, 2012
-
-
Anton Yabchinskiy authored
-
- Jul 15, 2012
-
-
Daniel Stenberg authored
In many states the easy_conn pointer is referenced and just assumed to be working. This is an added extra check since analyzing indicates there's a risk we can end up in these states with a NULL pointer there.
-
- Jul 13, 2012
-
-
Daniel Stenberg authored
Spotted by clang-analyzer
-
Daniel Stenberg authored
Spotted by clang-analyzer. The return code was never checked, just stored.
-
Daniel Stenberg authored
va_end() needs to be used after va_start() and we don't normally use Curl_ prefixes for purely static functions.
-
Philip Craig authored
This avoids false positives from clang's scan-build.
-
- Jul 12, 2012
-
-
Guenter Knauf authored
-
- Jul 11, 2012
-
-
Daniel Stenberg authored
A HEAD response has no body length and gets the headers like the corresponding GET would so it should not get closed after the response based on the same rules. This mistake caused connections that did HEAD to get closed too often without a valid reason. Bug: http://curl.haxx.se/bug/view.cgi?id=3542731 Reported by: Eelco Dolstra
-
Guenter Knauf authored
Updated .gitignore for NetWare created files.
-
Guenter Knauf authored
-
Guenter Knauf authored
-
Guenter Knauf authored
-
Guenter Knauf authored
-
Guenter Knauf authored
-
- Jul 09, 2012
-
-
Yang Tse authored
Modification based on voting result: http://curl.haxx.se/mail/lib-2012-07/0104.html
-
Daniel Stenberg authored
-
Christian Hägele authored
The function https_getsock was only implemented properly when USE_SSLEAY or USE_GNUTLS is defined, but it is also necessary for USE_SCHANNEL. The problem occurs when Curl_read_plain or Curl_write_plain returns CURLE_AGAIN. In that case CURL_OK is returned to the multi-interface an the used socket is set to state CURL_POLL_REMOVE and the easy-state is set to CURLM_STATE_PROTOCONNECT. This is fine, because later the socket should be set to CURL_POLL_IN or CURL_POLL_OUT via multi_getsock. That's where https_getsock is called and doesn't return any sockets.
-