Commit 1a74e54e authored by Philip Craig's avatar Philip Craig Committed by Daniel Stenberg
Browse files

Split up Curl_getinfo 

This avoids false positives from clang's scan-build.
parent 6e3802a2

lib/getinfo.c

+167 −129
Original line number Diff line number Diff line
@@ -72,61 +72,62 @@ CURLcode Curl_initinfo(struct SessionHandle *data) 
  return CURLE_OK;

}



CURLcode Curl_getinfo(struct SessionHandle *data, CURLINFO info, ...)

static CURLcode Curl_getinfo_char(struct SessionHandle *data, CURLINFO info,

                                  char **param_charp)

{

  va_list arg;

  long *param_longp=NULL;

  double *param_doublep=NULL;

  char **param_charp=NULL;

  struct curl_slist **param_slistp=NULL;

  int type;

  curl_socket_t sockfd;



  union {

    struct curl_certinfo * to_certinfo;

    struct curl_slist    * to_slist;

  } ptr;



  union {

    unsigned long *to_ulong;

    long          *to_long;

  } lptr;



  if(!data)

    return CURLE_BAD_FUNCTION_ARGUMENT;



  va_start(arg, info);



  type = CURLINFO_TYPEMASK & (int)info;

  switch(type) {

  case CURLINFO_STRING:

    param_charp = va_arg(arg, char **);

    if(NULL == param_charp)

      return CURLE_BAD_FUNCTION_ARGUMENT;

  switch(info) {

  case CURLINFO_EFFECTIVE_URL:

    *param_charp = data->change.url?data->change.url:(char *)"";

    break;

  case CURLINFO_LONG:

    param_longp = va_arg(arg, long *);

    if(NULL == param_longp)

      return CURLE_BAD_FUNCTION_ARGUMENT;

  case CURLINFO_CONTENT_TYPE:

    *param_charp = data->info.contenttype;

    break;

  case CURLINFO_DOUBLE:

    param_doublep = va_arg(arg, double *);

    if(NULL == param_doublep)

      return CURLE_BAD_FUNCTION_ARGUMENT;

  case CURLINFO_PRIVATE:

    *param_charp = (char *) data->set.private_data;

    break;

  case CURLINFO_SLIST:

    param_slistp = va_arg(arg, struct curl_slist **);

    if(NULL == param_slistp)

      return CURLE_BAD_FUNCTION_ARGUMENT;

  case CURLINFO_FTP_ENTRY_PATH:

    /* Return the entrypath string from the most recent connection.

       This pointer was copied from the connectdata structure by FTP.

       The actual string may be free()ed by subsequent libcurl calls so

       it must be copied to a safer area before the next libcurl call.

       Callers must never free it themselves. */

    *param_charp = data->state.most_recent_ftp_entrypath;

    break;

  case CURLINFO_REDIRECT_URL:

    /* Return the URL this request would have been redirected to if that

       option had been enabled! */

    *param_charp = data->info.wouldredirect;

    break;

  case CURLINFO_PRIMARY_IP:

    /* Return the ip address of the most recent (primary) connection */

    *param_charp = data->info.conn_primary_ip;

    break;

  case CURLINFO_LOCAL_IP:

    /* Return the source/local ip address of the most recent (primary)

       connection */

    *param_charp = data->info.conn_local_ip;

    break;

  case CURLINFO_RTSP_SESSION_ID:

    *param_charp = data->set.str[STRING_RTSP_SESSION_ID];

    break;



  default:

    return CURLE_BAD_FUNCTION_ARGUMENT;

  }

  return CURLE_OK;

}



static CURLcode Curl_getinfo_long(struct SessionHandle *data, CURLINFO info,

                                  long *param_longp)

{

  curl_socket_t sockfd;



  union {

    unsigned long *to_ulong;

    long          *to_long;

  } lptr;



  switch(info) {

  case CURLINFO_EFFECTIVE_URL:

    *param_charp = data->change.url?data->change.url:(char *)"";

    break;

  case CURLINFO_RESPONSE_CODE:

    *param_longp = data->info.httpcode;

    break;
@@ -142,59 +143,12 @@ CURLcode Curl_getinfo(struct SessionHandle *data, CURLINFO info, ...) 
  case CURLINFO_REQUEST_SIZE:

    *param_longp = data->info.request_size;

    break;

  case CURLINFO_TOTAL_TIME:

    *param_doublep = data->progress.timespent;

    break;

  case CURLINFO_NAMELOOKUP_TIME:

    *param_doublep = data->progress.t_nslookup;

    break;

  case CURLINFO_CONNECT_TIME:

    *param_doublep = data->progress.t_connect;

    break;

  case CURLINFO_APPCONNECT_TIME:

    *param_doublep = data->progress.t_appconnect;

    break;

  case CURLINFO_PRETRANSFER_TIME:

    *param_doublep =  data->progress.t_pretransfer;

    break;

  case CURLINFO_STARTTRANSFER_TIME:

    *param_doublep = data->progress.t_starttransfer;

    break;

  case CURLINFO_SIZE_UPLOAD:

    *param_doublep =  (double)data->progress.uploaded;

    break;

  case CURLINFO_SIZE_DOWNLOAD:

    *param_doublep = (double)data->progress.downloaded;

    break;

  case CURLINFO_SPEED_DOWNLOAD:

    *param_doublep =  (double)data->progress.dlspeed;

    break;

  case CURLINFO_SPEED_UPLOAD:

    *param_doublep = (double)data->progress.ulspeed;

    break;

  case CURLINFO_SSL_VERIFYRESULT:

    *param_longp = data->set.ssl.certverifyresult;

    break;

  case CURLINFO_CONTENT_LENGTH_DOWNLOAD:

    *param_doublep = (data->progress.flags & PGRS_DL_SIZE_KNOWN)?

      (double)data->progress.size_dl:-1;

    break;

  case CURLINFO_CONTENT_LENGTH_UPLOAD:

    *param_doublep = (data->progress.flags & PGRS_UL_SIZE_KNOWN)?

      (double)data->progress.size_ul:-1;

    break;

  case CURLINFO_REDIRECT_TIME:

    *param_doublep =  data->progress.t_redirect;

    break;

  case CURLINFO_REDIRECT_COUNT:

    *param_longp = data->set.followlocation;

    break;

  case CURLINFO_CONTENT_TYPE:

    *param_charp = data->info.contenttype;

    break;

  case CURLINFO_PRIVATE:

    *param_charp = (char *) data->set.private_data;

    break;

  case CURLINFO_HTTPAUTH_AVAIL:

    lptr.to_long = param_longp;

    *lptr.to_ulong = data->info.httpauthavail;
@@ -209,20 +163,6 @@ CURLcode Curl_getinfo(struct SessionHandle *data, CURLINFO info, ...) 
  case CURLINFO_NUM_CONNECTS:

    *param_longp = data->info.numconnects;

    break;

  case CURLINFO_SSL_ENGINES:

    *param_slistp = Curl_ssl_engines_list(data);

    break;

  case CURLINFO_COOKIELIST:

    *param_slistp = Curl_cookie_list(data);

    break;

  case CURLINFO_FTP_ENTRY_PATH:

    /* Return the entrypath string from the most recent connection.

       This pointer was copied from the connectdata structure by FTP.

       The actual string may be free()ed by subsequent libcurl calls so

       it must be copied to a safer area before the next libcurl call.

       Callers must never free it themselves. */

    *param_charp = data->state.most_recent_ftp_entrypath;

    break;

  case CURLINFO_LASTSOCKET:

    sockfd = Curl_getconnectinfo(data, NULL);
@@ -235,41 +175,18 @@ CURLcode Curl_getinfo(struct SessionHandle *data, CURLINFO info, ...) 
         may not be the same as the CURL_SOCKET_BAD value */

      *param_longp = -1;

    break;

  case CURLINFO_REDIRECT_URL:

    /* Return the URL this request would have been redirected to if that

       option had been enabled! */

    *param_charp = data->info.wouldredirect;

    break;

  case CURLINFO_PRIMARY_IP:

    /* Return the ip address of the most recent (primary) connection */

    *param_charp = data->info.conn_primary_ip;

    break;

  case CURLINFO_PRIMARY_PORT:

    /* Return the (remote) port of the most recent (primary) connection */

    *param_longp = data->info.conn_primary_port;

    break;

  case CURLINFO_LOCAL_IP:

    /* Return the source/local ip address of the most recent (primary)

       connection */

    *param_charp = data->info.conn_local_ip;

    break;

  case CURLINFO_LOCAL_PORT:

    /* Return the local port of the most recent (primary) connection */

    *param_longp = data->info.conn_local_port;

    break;

  case CURLINFO_CERTINFO:

    /* Return the a pointer to the certinfo struct. Not really an slist

       pointer but we can pretend it is here */

    ptr.to_certinfo = &data->info.certs;

    *param_slistp = ptr.to_slist;

    break;

  case CURLINFO_CONDITION_UNMET:

    /* return if the condition prevented the document to get transferred */

    *param_longp = data->info.timecond;

    break;

  case CURLINFO_RTSP_SESSION_ID:

    *param_charp = data->set.str[STRING_RTSP_SESSION_ID];

    break;

  case CURLINFO_RTSP_CLIENT_CSEQ:

    *param_longp = data->state.rtsp_next_client_CSeq;

    break;
@@ -285,3 +202,124 @@ CURLcode Curl_getinfo(struct SessionHandle *data, CURLINFO info, ...) 
  }

  return CURLE_OK;

}



static CURLcode Curl_getinfo_double(struct SessionHandle *data, CURLINFO info,

                                    double *param_doublep)

{

  switch(info) {

  case CURLINFO_TOTAL_TIME:

    *param_doublep = data->progress.timespent;

    break;

  case CURLINFO_NAMELOOKUP_TIME:

    *param_doublep = data->progress.t_nslookup;

    break;

  case CURLINFO_CONNECT_TIME:

    *param_doublep = data->progress.t_connect;

    break;

  case CURLINFO_APPCONNECT_TIME:

    *param_doublep = data->progress.t_appconnect;

    break;

  case CURLINFO_PRETRANSFER_TIME:

    *param_doublep =  data->progress.t_pretransfer;

    break;

  case CURLINFO_STARTTRANSFER_TIME:

    *param_doublep = data->progress.t_starttransfer;

    break;

  case CURLINFO_SIZE_UPLOAD:

    *param_doublep =  (double)data->progress.uploaded;

    break;

  case CURLINFO_SIZE_DOWNLOAD:

    *param_doublep = (double)data->progress.downloaded;

    break;

  case CURLINFO_SPEED_DOWNLOAD:

    *param_doublep =  (double)data->progress.dlspeed;

    break;

  case CURLINFO_SPEED_UPLOAD:

    *param_doublep = (double)data->progress.ulspeed;

    break;

  case CURLINFO_CONTENT_LENGTH_DOWNLOAD:

    *param_doublep = (data->progress.flags & PGRS_DL_SIZE_KNOWN)?

      (double)data->progress.size_dl:-1;

    break;

  case CURLINFO_CONTENT_LENGTH_UPLOAD:

    *param_doublep = (data->progress.flags & PGRS_UL_SIZE_KNOWN)?

      (double)data->progress.size_ul:-1;

    break;

  case CURLINFO_REDIRECT_TIME:

    *param_doublep =  data->progress.t_redirect;

    break;



  default:

    return CURLE_BAD_FUNCTION_ARGUMENT;

  }

  return CURLE_OK;

}



static CURLcode Curl_getinfo_slist(struct SessionHandle *data, CURLINFO info,

                                   struct curl_slist **param_slistp)

{

  union {

    struct curl_certinfo * to_certinfo;

    struct curl_slist    * to_slist;

  } ptr;



  switch(info) {

  case CURLINFO_SSL_ENGINES:

    *param_slistp = Curl_ssl_engines_list(data);

    break;

  case CURLINFO_COOKIELIST:

    *param_slistp = Curl_cookie_list(data);

    break;

  case CURLINFO_CERTINFO:

    /* Return the a pointer to the certinfo struct. Not really an slist

       pointer but we can pretend it is here */

    ptr.to_certinfo = &data->info.certs;

    *param_slistp = ptr.to_slist;

    break;



  default:

    return CURLE_BAD_FUNCTION_ARGUMENT;

  }

  return CURLE_OK;

}



CURLcode Curl_getinfo(struct SessionHandle *data, CURLINFO info, ...)

{

  va_list arg;

  long *param_longp=NULL;

  double *param_doublep=NULL;

  char **param_charp=NULL;

  struct curl_slist **param_slistp=NULL;

  int type;



  if(!data)

    return CURLE_BAD_FUNCTION_ARGUMENT;



  va_start(arg, info);



  type = CURLINFO_TYPEMASK & (int)info;

  switch(type) {

  case CURLINFO_STRING:

    param_charp = va_arg(arg, char **);

    if(NULL == param_charp)

      return CURLE_BAD_FUNCTION_ARGUMENT;

    return Curl_getinfo_char(data, info, param_charp);

  case CURLINFO_LONG:

    param_longp = va_arg(arg, long *);

    if(NULL == param_longp)

      return CURLE_BAD_FUNCTION_ARGUMENT;

    return Curl_getinfo_long(data, info, param_longp);

  case CURLINFO_DOUBLE:

    param_doublep = va_arg(arg, double *);

    if(NULL == param_doublep)

      return CURLE_BAD_FUNCTION_ARGUMENT;

    return Curl_getinfo_double(data, info, param_doublep);

  case CURLINFO_SLIST:

    param_slistp = va_arg(arg, struct curl_slist **);

    if(NULL == param_slistp)

      return CURLE_BAD_FUNCTION_ARGUMENT;

    return Curl_getinfo_slist(data, info, param_slistp);

  default:

    return CURLE_BAD_FUNCTION_ARGUMENT;

  }

}