- Sep 07, 2017
-
-
Jakub Zakrzewski authored
It has already been fixed in 6140dfcf
-
Daniel Stenberg authored
`conn->connect_state` is NULL when doing a regular non-CONNECT request over the proxy and should therefor be considered complete at once. Fixes #1853 Closes #1862 Reported-by: Lawrence Wagerfield
-
Johannes Schindelin authored
Another mistake in my manual fixups of the largely mechanical search-and-replace ("connssl->" -> "BACKEND->"), just like the previous commit concerning HTTPS proxies (and hence not caught during my earlier testing). Fixes #1855 Closes #1871 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-
Johannes Schindelin authored
In d65e6cc4 (vtls: prepare the SSL backends for encapsulated private data, 2017-06-21), this developer prepared for a separation of the private data of the SSL backends from the general connection data. This conversion was partially automated (search-and-replace) and partially manual (e.g. proxy_ssl's backend data). Sadly, there was a crucial error in the manual part, where the wrong handle was used: rather than connecting ssl[sockindex]' BIO to the proxy_ssl[sockindex]', we reconnected proxy_ssl[sockindex]. The reason was an incorrect location to paste "BACKEND->"... d'oh. Reported by Jay Satiro in https://github.com/curl/curl/issues/1855 . Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-
Jay Satiro authored
Ever since 70f1db32 (vtls: encapsulate SSL backend-specific data, 2017-07-28), the code handling HTTPS proxies was broken because the pointer to the SSL backend data was not swapped between conn->ssl[sockindex] and conn->proxy_ssl[sockindex] as intended, but instead set to NULL (causing segmentation faults). [jes: provided the commit message, tested and verified the patch] Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-
Daniel Stenberg authored
... instead of the prefix-less version since WolfSSL 3.12 now uses an enum with that name that causes build failures for us. Fixes #1865 Closes #1867 Reported-by: Gisle Vanem
-
Daniel Stenberg authored
Closes #1868
-
Daniel Stenberg authored
-
- Sep 06, 2017
-
-
Jay Satiro authored
-
Patrick Monnerat authored
- The part kind MIMEKIND_FILE and associated code are suppressed. - Seek data origin offset not used anymore: suppressed. - MIMEKIND_NAMEDFILE renamed MIMEKIND_FILE; associated fields/functions renamed accordingly. - Curl_getformdata() processes stdin via a callback.
-
Daniel Stenberg authored
Back in 2008, (and commit 3f3d6ebe) we changed the logic in how we determine the native type for `curl_off_t`. To really make sure we didn't break ABI without bumping SONAME, we introduced logic that attempted to detect that it would use a different size and thus not be compatible. We also provided a manual switch that allowed users to tell configure to bump SONAME by force. Today, we know of no one who ever got a SONAME bump auto-detected and we don't know of anyone who's using the manual bump feature. The auto- detection is also no longer working since we introduced defining curl_off_t in system.h (7.55.0). Finally, this bumping logic is not present in the cmake build. Closes #1861
-
Gisle Vanem authored
- Do a case-insensitive comparison of CURL_SSL_BACKEND env as well. - Change Curl_strcasecompare calls to strcasecompare (maps to the former but shorter). Follow-up to c290b8fb. Bug: https://github.com/curl/curl/commit/c290b8f#commitcomment-24094313 Co-authored-by: Jay Satiro
-
Jay Satiro authored
This is an adaptation of 2 of Peter Wu's SSLKEYLOGFILE implementations. The first one, written for old OpenSSL versions: https://git.lekensteyn.nl/peter/wireshark-notes/tree/src/sslkeylog.c The second one, written for BoringSSL and new OpenSSL versions: https://github.com/curl/curl/pull/1346 Note the first one is GPL licensed but the author gave permission to waive that license for libcurl. As of right now this feature is disabled by default, and does not have a configure option to enable it. To enable this feature define ENABLE_SSLKEYLOGFILE when building libcurl and set environment variable SSLKEYLOGFILE to a pathname that will receive the keys. And in Wireshark change your preferences to point to that key file: Edit > Preferences > Protocols > SSL > Master-Secret Co-authored-by: Peter Wu Ref: https://github.com/curl/curl/pull/1030 Ref: https://github.com/curl/curl/pull/1346 Closes https://github.com/curl/curl/pull/1866
-
- Sep 05, 2017
-
-
Patrick Monnerat authored
-
Patrick Monnerat authored
mime_state is now a typedef.
-
Patrick Monnerat authored
curl_mime_encoder() is operational and documented. curl tool -F option is extended with ";encoder=". curl tool --libcurl option generates calls to curl_mime_encoder(). New encoder tests 648 & 649. Test 1404 extended with an encoder specification.
-
Patrick Monnerat authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
... and slightly edited to follow our code style better.
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
Kamil Dudka authored
Up2date versions of OpenSSL maintain the default reasonably secure without breaking compatibility, so it is better not to override the default by curl. Suggested at https://bugzilla.redhat.com/1483972 Closes #1846
-
Viktor Szakats authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
...for curl-config and its corresponding test 1014
-
Daniel Stenberg authored
Added test 1904 to verify. Reported-by: Lawrence Wagerfield Fixes #1859 Closes #1860
-
Daniel Stenberg authored
-
- Sep 04, 2017
-
-
Daniel Stenberg authored
... to a README file that doesn't exist anymore
-
Viktor Szakats authored
-
Viktor Szakats authored
and some minor whitespace fixes
-
Daniel Stenberg authored
... not *CACERT_BADFILE as it isn't really because of a bad file. Bug: https://curl.haxx.se/mail/lib-2017-09/0002.html Closes #1858
-
Daniel Stenberg authored
-
Daniel Stenberg authored
... since people copy and paste code from this example and thus they get an inefficient POST operation without a good reason and sometimes without understanding why. Instead this now returns as much data as possible.
-
Daniel Stenberg authored
-
Daniel Stenberg authored
... as the other functions. Makes it easier to machine-parse!
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
- Sep 03, 2017
-
-
Patrick Monnerat authored
-
Daniel Stenberg authored
As it was added to multi.h simply to not break test 1135, which now has been disabled due to the mime API addition anyway and su we can now move the sslset stuff to where the other curl_global_* prototypes are.
-
Patrick Monnerat authored
Use and generate CURL_ZERO_TERMINATED in curl tool and tests.
-