Commits · 86ab78e2a57022bcd1cf9fda9d875058cce29c17 · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

May 30, 2002

This definitely gets the award for least useful error message of the month. · 86ab78e2

Cliff Woolley authored May 30, 2002

Not only should it just say "can't do that on win32," which is after all
the bottom line, it was spitting out openssl error messages which were
totally useless.  Eg:

[30/May/2002 17:31:17 05760] [error] Init: PassPhraseDialog BuiltIn not
supported in server private key from file
F:/Apache/Apache2/conf/ssl/secure.key (OpenSSL library error follows)
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D084069:asn1
encoding routines:d2i_ASN1_SET:bad tag
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09D082:asn1
encoding routines:d2i_RSAPrivateKey:parsing
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09B00D:asn1
encoding routines:d2i_PrivateKey:ASN1 lib

Which is essentially saying "OpenSSL couldn't read your private key because
it was encrypted, and we can't get the passphrase the way you asked us to
on this platform."


Brought to my attention by the inquiry of:  Chris Hsiang <chsiang@ivivos.com>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95415 13f79535-47bb-0310-9956-ffa450edef68

86ab78e2

Why the stack buffer and the copy? This seems much more straightforward. · 43ea0253
Cliff Woolley authored May 30, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95413 13f79535-47bb-0310-9956-ffa450edef68
```
43ea0253

mod_bucketeer needs to preserve error buckets if it sees them rather · 349b3fbd

Justin Erenkrantz authored May 30, 2002

than silently discarding them.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95412 13f79535-47bb-0310-9956-ffa450edef68

349b3fbd

Let the error bucket implement the simple copy routine. · 483b149b
Justin Erenkrantz authored May 30, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95411 13f79535-47bb-0310-9956-ffa450edef68
```
483b149b

Add macro to check for an error bucket. (Can't call it APR_BUCKET_IS_ERROR · 9715dad4

Justin Erenkrantz authored May 30, 2002

since error bucket is private to httpd - hence the AP_ prefix.)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95410 13f79535-47bb-0310-9956-ffa450edef68

9715dad4

some comments after testing "apxs -g" from a 2.0.36 binbuild · 244fc038
Jeff Trawick authored May 30, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95409 13f79535-47bb-0310-9956-ffa450edef68
```
244fc038

· 95c06509

William A. Rowe Jr authored May 30, 2002

  Based on DougM's feedback to the list...


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95408 13f79535-47bb-0310-9956-ffa450edef68

95c06509

· b557db8c

William A. Rowe Jr authored May 30, 2002

Apparently Roy missed this comment. Rephrase as a seperate paragraph
to more clearly split credit for OpenSSL from credit for mod_ssl.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95407 13f79535-47bb-0310-9956-ffa450edef68

b557db8c

· c26d0999

William A. Rowe Jr authored May 30, 2002

  Split out the LAYOUT


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95406 13f79535-47bb-0310-9956-ffa450edef68

c26d0999

· f9eb4947

William A. Rowe Jr authored May 30, 2002

  As we find the right places for this content, move them out in bits


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95405 13f79535-47bb-0310-9956-ffa450edef68

f9eb4947

clear up some warnings about unused variables · 72e886dc

Ian Holsman authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95404 13f79535-47bb-0310-9956-ffa450edef68

72e886dc

· e736fc4f

William A. Rowe Jr authored May 30, 2002

Thanks for verifying these are valid, Doug. Now this [much shorter]
list should be living in our STATUS file. Question of module maps
and file layout is already off to the list.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95403 13f79535-47bb-0310-9956-ffa450edef68

e736fc4f

A tiny bit more clarification of _default_. · f4cfd079

Joshua Slive authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95402 13f79535-47bb-0310-9956-ffa450edef68

f4cfd079

Too many people seem to try to use _default_ with name-virtual hosts. · 3b7b9a25

Joshua Slive authored May 30, 2002

Maybe this will help?


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95401 13f79535-47bb-0310-9956-ffa450edef68

3b7b9a25

keep the signed-ness of char buffers consistent with what is expected · 2c395162

Jeff Trawick authored May 30, 2002

by functions they are passed to (putLong() this time)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95399 13f79535-47bb-0310-9956-ffa450edef68

2c395162

Unroll the putLong and getLong loops and correct putLong's input param type to · 726b0edb

Justin Erenkrantz authored May 30, 2002

be unsigned char* instead of char*.

Submitted by:	Sander Striker
Reviewed by:	Justin Erenkrantz


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95397 13f79535-47bb-0310-9956-ffa450edef68

726b0edb

Update Japanese translation. · 6730d319

Yoshiki Hayashi authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95396 13f79535-47bb-0310-9956-ffa450edef68

6730d319

New Japanese translation. · 93b214d9

Yoshiki Hayashi authored May 30, 2002

Submitted by:	Hiroaki KAWAI <hawk@bcl.t.u-tokyo.ac.jp>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95395 13f79535-47bb-0310-9956-ffa450edef68

93b214d9

Switch mod_proxy to using the brigade/filter calls directly rather than · 378eb21f

Justin Erenkrantz authored May 30, 2002

the *_client_block calls.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95394 13f79535-47bb-0310-9956-ffa450edef68

378eb21f

New Japanese translation. Forward port from 1.3. · 0fc7f975

Yoshiki Hayashi authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95393 13f79535-47bb-0310-9956-ffa450edef68

0fc7f975

New Japanese translation. Forward port from 1.3. · 9a509c6a

Yoshiki Hayashi authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95392 13f79535-47bb-0310-9956-ffa450edef68

9a509c6a

New Japanese translation. · a7dbc7ba

Yoshiki Hayashi authored May 30, 2002

Submitted by: Hiroaki KAWAI <hawk@bcl.t.u-tokyo.ac.jp>
Reviewed by: Yoshiki Hayashi

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95391 13f79535-47bb-0310-9956-ffa450edef68

a7dbc7ba

Add a PROXYREQ_RESPONSE value for request_rec->proxyreq because it is · 8dc39a0a

Justin Erenkrantz authored May 30, 2002

possible that there can be different behavior at the protocol level if
request_rec isn't really a request but a response.

This stems from the fact that request bodies must be indicated by
Content-Length or Transfer-Encoding, but response bodies do not. The
recent change to ap_http_filter to return EOS if there isn't a body broke
proxy. Therefore, there must be some way for the proxy to indicate that
this is a response. Accordingly, ap_http_filter can allow the BODY_NONE
iff this is a response.

Since r->proxyreq is set to PROXYREQ_PROXY even for the original request
from the client, that value isn't sufficient. Hence, the introduction of
PROXYREQ_RESPONSE.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95390 13f79535-47bb-0310-9956-ffa450edef68

8dc39a0a

· aad30330

William A. Rowe Jr authored May 30, 2002

All rather stale. Any new/remaining issues should be moved to CHANGES
in the present tense, as opposed to the "Future port to 2.0". Heh

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95389 13f79535-47bb-0310-9956-ffa450edef68

aad30330

Imagine the horror. I go to try compiling PHP4, and it bombs out on · 412b9c17

Cliff Woolley authored May 30, 2002

r->boundary.  BUT WAIT, I say, we have a test in there for that:
#if !MODULE_MAGIC_AT_LEAST(20020506,0).  The test doesn't seem to be
working.  That's odd, I think.  So I go look at the ap_mmn.h.  Egad,
the tests are totally backwards.  How on earth are we going to handle this?
Surely it's wrong in 1.3.x as well.  So I go look.  Nope, turns out it
got fixed TWO YEARS AGO in that repository.  Sigh.  Anyway, thanks Greg.
:)

Submitted by:	Greg Stein, circa Apache 1.3.13


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95388 13f79535-47bb-0310-9956-ffa450edef68

412b9c17

· f50d71cd

William A. Rowe Jr authored May 30, 2002

Now a moot issue.

Isn't it time to just drop "PRs that have been suspended forever waiting
for someone to put them into 'the next release'" if they have no status?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95387 13f79535-47bb-0310-9956-ffa450edef68

f50d71cd

mod_cgid got hit too with this change · f9b38e5a

Justin Erenkrantz authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95386 13f79535-47bb-0310-9956-ffa450edef68

f9b38e5a

Apply same patch to mod_cgid that was applied to mod_cgi so that it · 947efebd

Justin Erenkrantz authored May 30, 2002

bypasses the *_client_block calls in favor of using the input filters
and brigades directly.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95385 13f79535-47bb-0310-9956-ffa450edef68

947efebd

· 5ae2a092

William A. Rowe Jr authored May 30, 2002

  Goodness


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95383 13f79535-47bb-0310-9956-ffa450edef68

5ae2a092

okay then :) · c36f9a72

Cliff Woolley authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95382 13f79535-47bb-0310-9956-ffa450edef68

c36f9a72

Yet another reason the MMN needs to get bumped. If there are changes · 12fd05c1

Cliff Woolley authored May 30, 2002

that anyone's been holding off on because they would affect the MMN, might
as well get them in now so we minimize the number of releases with MMN
changes. I believe there are more renames pending in APR that should be
done sooner rather than later, for example.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95381 13f79535-47bb-0310-9956-ffa450edef68

12fd05c1

· c8300497

William A. Rowe Jr authored May 30, 2002

  Always using -t "Window Title" option myself, so I never caught this.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95380 13f79535-47bb-0310-9956-ffa450edef68

c8300497

· fdc9719a

William A. Rowe Jr authored May 30, 2002

  Four column tabs, no less?  Just a formatting fix


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95379 13f79535-47bb-0310-9956-ffa450edef68

fdc9719a

A clean prefork build starts up for me on Darwin. Will try with worker later. · 96455bda
Justin Erenkrantz authored May 30, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95378 13f79535-47bb-0310-9956-ffa450edef68
```
96455bda

Fix some subscriptions and a typo. · 51137f71

Joshua Slive authored May 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95377 13f79535-47bb-0310-9956-ffa450edef68

51137f71

Rewrite mod_cgi's input handling to use brigades and input filters directly. · 73815be4

Justin Erenkrantz authored May 30, 2002

This removes the unnecessary overhead of the *_client_block functions.

Optimize usage of the dbuf char* (don't do pcalloc on it!)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95376 13f79535-47bb-0310-9956-ffa450edef68

73815be4

Thanks Ryan for cleaning up after my laziness. :) Here are just a few · c12208ea

Cliff Woolley authored May 30, 2002

last little changes.  ->datafile should be initialized... but doing so
brings up the fact that the check in run_rewritemap_programs() was
expecting ->datafile to have a string attached to it.  For clarity,
let's just use argv[0] there.  And since we've reinstated the use of
->checkfile, we no longer need that extra apr_stat() I hacked in,
so let's get rid of it.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95375 13f79535-47bb-0310-9956-ffa450edef68

c12208ea

- Remove APR_STATUS_IS_SUCCESS calls in favor of directly testing APR_SUCCESS. · 17ea90f8

Justin Erenkrantz authored May 30, 2002

- Minor style nit with spaces.
(No functional changes.)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95374 13f79535-47bb-0310-9956-ffa450edef68

17ea90f8

Catch up with the apr_allocator_set_owner -> apr_allocator_owner_set renames · 968ffa11
Sander Striker authored May 30, 2002
```
in APR.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95373 13f79535-47bb-0310-9956-ffa450edef68
```
968ffa11

Tokenize the arguments for rewrite programs during config parsing, and · ff841f19

Ryan Bloom authored May 30, 2002

just use that information later. I was having a problem with prg
directives with arguments failing the configuration. The problem was
a call to stat, which was being passed the program name and the arguments.
Obviously, the arguments were messing up the call to stat. This gets the
test suite working for me again.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95372 13f79535-47bb-0310-9956-ffa450edef68

ff841f19