- 23 Jan, 2017 9 commits
-
-
Matt Caswell authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1983)
-
Matt Caswell authored
In a non client-auth renegotiation where the original handshake *was* client auth, then the server will expect the client to send a Certificate message anyway resulting in a connection failure. Reviewed-by:
-
Matt Caswell authored
In a non client-auth renegotiation where the original handshake *was* client auth, then the client will send a Certificate message anyway resulting in a connection failure. Reviewed-by:
-
Matt Caswell authored
The flag SSL_VERIFY_CLIENT_ONCE is documented as follows: B<Server mode:> only request a client certificate on the initial TLS/SSL handshake. Do not ask for a client certificate again in case of a renegotiation. This flag must be used together with SSL_VERIFY_PEER. B<Client mode:> ignored But the implementation actually did nothing. After the server sends its ServerKeyExchange message, the code was checking s->session->peer to see if it is NULL. If it was set then it did not ask for another client certificate. However s->session->peer will only be set in the event of a resumption, but a ServerKeyExchange message is only sent in the event of a full handshake (i.e. no resumption). The documentation suggests that the original intention was for this to have an effect on renegotiation, and resumption doesn't come into it. The fix is to properly check for renegotiation, not whether there is already a client certificate in the session. As far as I can tell this has been broken for a *long* time. Reviewed-by:
-
Matt Caswell authored
Repeat for various handshake types Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Bernd Edlinger authored
Reviewed-by:
Kurt Roeckx <kurt@openssl.org> Reviewed-by:
-
Bernd Edlinger authored
Reviewed-by:
Matt Caswell <matt@openssl.org> Reviewed-by:
-
- 20 Jan, 2017 1 commit
-
-
Richard Levitte authored
When setting the digest parameter for DSA parameter generation, the signature MD was set instead of the parameter generation one. Fortunately, that's also the one that was used for parameter generation, but it ultimately meant the parameter generator MD and the signature MD would always be the same. Fixes github issue #2016 Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/2250) (cherry picked from commit 8a05c4d3)
-
- 19 Jan, 2017 1 commit
-
-
Markus Triska authored
CLA: trivial Reviewed-by:
Tim Hudson <tjh@openssl.org> Reviewed-by:
-
- 18 Jan, 2017 5 commits
-
-
Rich Salz authored
Reviewed-by:
Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1597) (cherry picked from commit 4f326dd8)
-
Rich Salz authored
Reviewed-by:
-
FdaSilvaYY authored
... mostly related to some old discarded modules . Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
Markus Triska authored
Reviewed-by:
-
- 17 Jan, 2017 1 commit
-
-
EasySec authored
Reviewed-by:
-
- 16 Jan, 2017 2 commits
-
-
xemdetia authored
CLA: trivial Reviewed-by:
-
Kurt Roeckx authored
Reviewed-by:
-
- 15 Jan, 2017 3 commits
-
-
Kurt Roeckx authored
Found by oss-fuzz Reviewed-by:
Andy Polyakov <appro@openssl.org> GH: #2231 (cherry picked from commit c2ce477f)
-
Kurt Roeckx authored
Reviewed-by:
-
Kurt Roeckx authored
Found by afl Reviewed-by:
-
- 13 Jan, 2017 2 commits
-
-
Richard Levitte authored
RUN_ONCE really just returns 0 on failure or whatever the init function returned. By convention, however, the init function must return 0 on failure and 1 on success. This needed to be clarified. Reviewed-by:
-
Richard Levitte authored
The use of EXFLAG_SET requires the inclusion of openssl/x509v3.h. openssl/ocsp.h does that, except when OCSP is disabled. Reviewed-by:
-
- 12 Jan, 2017 2 commits
-
-
Rich Salz authored
Also, if want SHA1 then use the pre-computed value if there. Reviewed-by:
-
Rich Salz authored
Reviewed-by:
-
- 10 Jan, 2017 3 commits
-
-
Rich Salz authored
Fixes GitHub issue 2169. Reviewed-by:
-
Kurt Roeckx authored
Found by tis-interpreter Reviewed-by:
-
Matt Caswell authored
Otherwise the client will try to process it again. The second time around it will try and move the record data into handshake fragment storage and realise that there is no data left. At that point it marks it as read anyway. However, it is a bug that we go around the loop a second time, so we prevent that. Reviewed-by:
-
- 09 Jan, 2017 3 commits
-
-
Bernd Edlinger authored
Signed-off-by:
Kurt Roeckx <kurt@roeckx.be> Reviewed-by:
-
Rich Salz authored
Reviewed-by:
-
Rich Salz authored
Enhance find-doc-nits to be better about finding typedefs for callback functions. Fix all nits it now finds. Added some new typedef names to ssl.h some of which were documented but did not exist Reviewed-by:
-
- 08 Jan, 2017 2 commits
-
-
Dr. Stephen Henson authored
Add option ExpectedTmpKeyType to test the temporary key the server sends is of the correct type. Reviewed-by:
-
Dr. Stephen Henson authored
Reviewed-by:
-
- 05 Jan, 2017 1 commit
-
-
Dr. Stephen Henson authored
BIO_seek and BIO_tell can cause problems with evp_test.c on some platforms. Avoid them by using a temporary memory BIO to store key PEM data. Reviewed-by:
-
- 03 Jan, 2017 2 commits
-
-
Dr. Stephen Henson authored
Reviewed-by:
-
Dr. Stephen Henson authored
Reviewed-by:
-
- 30 Dec, 2016 2 commits
-
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
This macro has a typo in it which makes it unusable. This issue was already fixed in 1.0.2 in commit 75fdee04 , but the same fix was not applied to other branches. Reviewed-by:
-
- 29 Dec, 2016 1 commit
-
-
Markus Triska authored
Reviewed-by:
-
