- Dec 04, 2014
-
-
Matt Caswell authored
Reviewed-by:Tim Hudson <tjh@openssl.org>
-
- Dec 03, 2014
-
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
than the mtu we are already using Reviewed-by:
-
Matt Caswell authored
and UDP header) when setting an mtu. This constant is not always correct (e.g. if using IPv6). Use the new DTLS_CTRL functions instead. Reviewed-by:
-
Matt Caswell authored
we will support then dtls1_do_write can go into an infinite loop. This commit fixes that. Reviewed-by:
-
Matt Caswell authored
at least the minimum or it will fail. There were some instances in dtls1_query_mtu where the final mtu can end up being less than the minimum, i.e. where the user has set an mtu manually. This shouldn't be allowed. Also remove dtls1_guess_mtu that, despite having logic for guessing an mtu, was actually only ever used to work out the minimum mtu to use. Reviewed-by:
-
Matt Caswell authored
and instead use the value provided by the underlying BIO. Also provide some new DTLS_CTRLs so that the library user can set the mtu without needing to know this constant. These new DTLS_CTRLs provide the capability to set the link level mtu to be used (i.e. including this IP/UDP overhead). The previous DTLS_CTRLs required the library user to subtract this overhead first. Reviewed-by:
-
Matt Caswell authored
used with no explanation. Some of this was introduced as part of RT#1929. The value 28 is the length of the IP header (20 bytes) plus the UDP header (8 bytes). However use of this constant is incorrect because there may be instances where a different value is needed, e.g. an IPv4 header is 20 bytes but an IPv6 header is 40. Similarly you may not be using UDP (e.g. SCTP). This commit introduces a new BIO_CTRL that provides the value to be used for this mtu "overhead". It will be used by subsequent commits. Reviewed-by:
-
Matt Caswell authored
mtu that we have received is not less than the minimum. If its less it uses the minimum instead. The second call to query the mtu does not do that, but instead uses whatever comes back. We have seen an instance in RT#3592 where we have got an unreasonably small mtu come back. This commit makes both query checks consistent. Reviewed-by:
-
Matt Caswell authored
automatically updated, and we should use the one provided instead. Unfortunately there are a couple of locations where this is not respected. Reviewed-by:
-
Matt Caswell authored
RT#3592 provides an instance where the OPENSSL_assert that this commit replaces can be hit. I was able to recreate this issue by forcing the underlying BIO to misbehave and come back with very small mtu values. This happens the second time around the while loop after we have detected that the MTU has been exceeded following the call to dtls1_write_bytes. Reviewed-by:
-
- Dec 02, 2014
-
-
Kurt Roeckx authored
If SSLv2 and SSLv3 are both disabled we still support SSL/TLS. Reviewed-by:Richard Levitte <levitte@openssl.org>
-
- Nov 28, 2014
-
-
Richard Levitte authored
Reviewed-by:Matt Caswell <matt@openssl.org>
-
Richard Levitte authored
Previously, state variant was not advanced, which resulted in state being stuck in the st1 variant (usually "_A"). This broke certificate callback retry logic when accepting connections that were using SSLv2 ClientHello (hence reusing the message), because their state never advanced to SSL3_ST_SR_CLNT_HELLO_C variant required for the retry code path. Reported by Yichun Zhang (agentzh). Signed-off-by:
Piotr Sikora <piotr@cloudflare.com> Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
Alok Menghrajani authored
The current documentation contains a bunch of spelling and grammar mistakes. I also found it hard to understand some paragraphs, so here is my attempt to improve its readability. Reviewed-by:
-
- Nov 27, 2014
-
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
PR#1767 Reviewed-by:
-
Matt Caswell authored
PR#3613 Reviewed-by:
-
Matt Caswell authored
Reviewed-by:Dr. Stephen Henson <steve@openssl.org>
-
Matt Caswell authored
Reviewed-by:
-
André Guerreiro authored
PR#3612 Reviewed-by:
-
Guenter authored
Workaround for NetWare CodeWarrior compiler which doesn't properly lookup includes when in same directory as the C file which includes it. PR#3569 Reviewed-by:
-
Matt Caswell authored
Minor changes made by Matt Caswell Reviewed-by:
-
Matt Caswell authored
Minor changes made by Matt Caswell. Reviewed-by:
-
Matt Caswell authored
Minor changes made by Matt Caswell. Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
- Nov 26, 2014
-
-
Matt Caswell authored
PR#3608 Reviewed-by:
-
- Nov 25, 2014
-
-
Matt Caswell authored
PR#3574 Reviewed-by:
-
- Nov 20, 2014
-
-
Dr. Stephen Henson authored
When using the -xcert option to test certificate validity print out if we pass Suite B compliance. We print out "not tested" if we aren't in Suite B mode. Reviewed-by:
-
Dr. Stephen Henson authored
Reviewed-by:
-
David Benjamin authored
the session's version (server). See also BoringSSL's commit bdf5e72f50e25f0e45e825c156168766d8442dde. Reviewed-by:
-
Matt Caswell authored
ECDH_compute_key is silently ignored and the KDF is run on duff data Thanks to github user tomykaira for the suggested fix. Reviewed-by:
-
Emilia Kasper authored
Reviewed-by:
-
Emilia Kasper authored
once the ChangeCipherSpec message is received. Previously, the server would set the flag once at SSL3_ST_SR_CERT_VRFY and again at SSL3_ST_SR_FINISHED. This would allow a second CCS to arrive and would corrupt the server state. (Because the first CCS would latch the correct keys and subsequent CCS messages would have to be encrypted, a MitM attacker cannot exploit this, though.) Thanks to Joeri de Ruiter for reporting this issue. Reviewed-by:
-
Emilia Kasper authored
The server must send a NewSessionTicket message if it advertised one in the ServerHello, so make a missing ticket message an alert in the client. An equivalent change was independently made in BoringSSL, see commit 6444287806d801b9a45baf1f6f02a0e3a16e144c. Reviewed-by:
-
Emilia Kasper authored
The client sends a session ID with the session ticket, and uses the returned ID to detect resumption, so we do not need to peek at handshake messages: s->hit tells us explicitly if we're resuming. An equivalent change was independently made in BoringSSL, see commit 407886f589cf2dbaed82db0a44173036c3bc3317. Reviewed-by:
-
