- Sep 07, 2016
-
-
David Woodhouse authored
Some hardware devices don't provide the public EC_POINT data. The only way for X509_check_private_key() to validate that the key matches a given certificate is to actually perform a sign operation and then verify it using the public key in the certificate. Maybe that can come later, as discussed in issue 1532. But for now let's at least make it fail gracefully and not crash. GH: 1532 Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1547)
-
Richard Levitte authored
The way we figured out what options are crypto algorithms and what are something other was somewhat sketchy. This change bases the distinction on available sdirs instead. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 3e2dd30d)
-
Alex Gaynor authored
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit d65c3615)
-
- Sep 06, 2016
-
-
Rich Salz authored
Never output -0; make "negative zero" an impossibility. Do better checking on BN_rand top/bottom requirements and #bits. Update doc. Ignoring trailing garbage in BN_asc2bn. Port this commit from boringSSL: https://boringssl.googlesource.com/boringssl/+/899b9b19a4cd3fe526aaf5047ab9234cdca19f7d%5E!/ Ensure |BN_div| never gives negative zero in the no_branch code. Have |bn_correct_top| fix |bn->neg| if the input is zero so that we don't have negative zeros lying around. Thanks to Brian Smith for noticing. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 01c09f9f)
-
Richard Levitte authored
Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 77a42b5f)
-
- Sep 05, 2016
-
-
Richard Levitte authored
In the case of using an independent makedepend, we had split that into two separate recipes, one depending on the other. However, there are cases where the makedepend recipe was always trying, but doesn't update the time stamp of the .d file because there are no actual changes, and thereby causing constant updates of the object files. This change makes one recipe that takes care of both makedepend och cc, thereby avoiding these extra updates. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 7e5b8b93)
-
- Sep 03, 2016
-
-
Andy Polyakov authored
Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 6cf412c4)
-
- Sep 02, 2016
-
-
Andy Polyakov authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit d5a39c12)
-
Andy Polyakov authored
Since vendor assembler can't assemble our modules with -KPIC flag, it, assembly support, was not available as an option. But this means lack of side-channel resistant code, which is incompatible with security by todays standards. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 216a0cc4)
-
- Sep 01, 2016
-
-
Richard Levitte authored
This adheres much better to the documentation in test/README Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 377ab6d1)
-
Richard Levitte authored
This reverts commit 7f9ae888 . Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 967e831e)
-
Richard Levitte authored
This reverts commit eb40eaed . Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit a5e1f123)
-
- Aug 31, 2016
-
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 7f9ae888)
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit ed43fe73)
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit bf98d9da)
-
Richard Levitte authored
Because some targets execute perl code that might die, we risk incomplete lists. Make it so dying doesn't happen when we're listing targets. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit d63c12c6)
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 0c0d78b8)
-
Richard Levitte authored
These tests take a very long time on some platforms, and arent't always strictly necessary. This makes it possible to turn them off. The necessary binaries are still built, though, in case someone still wants to do a manual run. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit eb40eaed)
-
Andy Polyakov authored
crypto/bn/*: x86[_64] division instruction doesn't handle constants, change constraint from 'g' to 'r'. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 68b4a6e9)
-
Richard Levitte authored
Note: some shells do not like the command verb to be quoted, so we avoid it unless it's actually necessary. RT#4665 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit f879d5ff)
-
Rich Salz authored
Remove NULL check on parameter, and use NULL not ! on buffer. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit bde588df)
-
- Aug 30, 2016
-
-
Matt Caswell authored
The previous commit revealed a long standing problem where CertStatus processing was broken in DTLS. This would have been revealed by better testing - so add some! Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 767ccc3b)
-
Matt Caswell authored
The function tls_construct_cert_status() is called by both TLS and DTLS code. However it only ever constructed a TLS message header for the message which obviously failed in DTLS. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit f046afb0)
-
Richard Levitte authored
Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit ee4cdb7f)
-
Richard Levitte authored
Build file templates would be looked up like this if the user gave us an additional directory to look for configuration files and build file templates: $OPENSSL_LOCAL_CONFIG_DIR/$OSTYPE-Makefile.tmpl $SOURCEDIR/Configurations/$OSTYPE-Makefile.tmpl $OPENSSL_LOCAL_CONFIG_DIR/Makefile.tmpl $SOURCEDIR/Configurations/Makefile.tmpl So for example, if the user created his own Makefile.tmpl and tried to use it with a unixly config, it would never be user because we have a unix-Makefile.tmpl in our Configurations directory. This is clearly wrong, and this change makes it look in this order instead: $OPENSSL_LOCAL_CONFIG_DIR/$OSTYPE-Makefile.tmpl $OPENSSL_LOCAL_CONFIG_DIR/Makefile.tmpl $SOURCEDIR/Configurations/$OSTYPE-Makefile.tmpl $SOURCEDIR/Configurations/Makefile.tmpl Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 79822c3c)
-
Richard Levitte authored
We've done away with Makefile as source of information and now use configdata.pm exclusively. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit acc63c7d)
-
Richard Levitte authored
Make sure the information is kept for reconfiguration too. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 8b5156d1)
-
- Aug 29, 2016
-
-
Rich Salz authored
Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit d196305a)
-
Rich Salz authored
Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 66117ab0)
-
- Aug 26, 2016
-
-
Richard Levitte authored
Because of a perl operator priority mixup, the --openssldir argument wasn't honored. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 661a3963)
-
Rich Salz authored
Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit e5f969a8)
-
Richard Levitte authored
The definition of STITCHED_CALL relies on OPENSSL_NO_ASM. However, when a configuration simply lacks the assembler implementation for RC4 (which is where we have implemented the stitched call), OPENSSL_NO_ASM isn't implemented. Better, then, to rely on specific macros that indicated that RC4 (and MD5) are implemented in assembler. For this to work properly, we must also make sure Configure adds the definition of RC4_ASM among the C flags. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 216e8d91)
-
Matt Caswell authored
EC DRBG support was added in 7fdcb457 in 2011 and then later removed. However the CHANGES entry for its original addition was left behind. This just removes the spurious CHANGES entry. Reviewed-by: Stephen Henson <steve@openssl.org> (cherry picked from commit bbf73f84)
-
- Aug 25, 2016
-
-
Matt Caswell authored
Reviewed-by: Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
Reviewed-by: Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
msan detected an uninit read. Reviewed-by: Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
Reviewed-by: Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
User can make Windows openssl.exe to treat command-line arguments and console input as UTF-8 By setting OPENSSL_WIN32_UTF8 environment variable (to any value). This is likely to be required for data interchangeability with other OSes and PKCS#12 containers generated with Windows CryptoAPI. Reviewed-by: Richard Levitte <levitte@openssl.org>
-
Dr. Stephen Henson authored
OpenSSL versions before 1.1.0 didn't convert non-ASCII UTF8 PKCS#12 passwords to Unicode correctly. To correctly decrypt older files, if MAC verification fails with the supplied password attempt to use the broken format which is compatible with earlier versions of OpenSSL. Reviewed-by: Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
To avoid possible race conditions don't switch password format using global state in crypto/pkcs12 Reviewed-by: Richard Levitte <levitte@openssl.org>
-