- 13 Jan, 2018 1 commit
-
-
Bernd Edlinger authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5071) (cherry picked from commit 438e57a4)
-
- 10 Jan, 2018 1 commit
-
-
Patrick Schlangen authored
The data argument of SSL_dane_tlsa_add is used read-only, so it should be const. Reviewed-by:
Viktor Dukhovni <viktor@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5056) (cherry picked from commit a41a6120)
-
- 09 Jan, 2018 4 commits
-
-
Matt Caswell authored
In the case of a protocol version alert being sent by a peer the record version number may not be what we are expecting. In DTLS records with an unexpected version number are silently discarded. This probably isn't appropriate for alerts, so we tolerate a mismatch in the minor version number. This resolves an issue reported on openssl-users where an OpenSSL server chose DTLS1.0 but the client was DTLS1.2 only and sent a protocol_version alert with a 1.2 record number. This was silently ignored by the server. Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5039)
-
David von Oheimb authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
-
- 08 Jan, 2018 3 commits
-
-
Patrick Steuer authored
In apps/engine.pod and crypto/ENGINE_add.pod Reviewed-by:
-
pass86 authored
CLA: trivial Reviewed-by:
Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/5029) (cherry picked from commit bebef673)
-
Richard Levitte authored
The uClinux targets included some attributes that would result in circular references of CFLAGS and LDCLAGS. Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5034) (cherry picked from commit f720194c)
-
- 07 Jan, 2018 2 commits
-
-
Richard Levitte authored
Reviewed-by:
-
Rich Salz authored
Reviewed-by:
-
- 06 Jan, 2018 2 commits
-
-
Konstantin Shemyak authored
A backport of #4997. Fixes #4996. Reviewed-by:
Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/5021)
-
Bernd Edlinger authored
Add comments to no longer usable ciphers. Reviewed-by:
-
- 05 Jan, 2018 1 commit
-
-
Viktor Dukhovni authored
Reviewed-by:
-
- 04 Jan, 2018 1 commit
-
-
Rich Salz authored
Reviewed-by:
-
- 27 Dec, 2017 1 commit
-
-
Andy Polyakov authored
Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/4974) (cherry picked from commit 8af7e94d)
-
- 17 Dec, 2017 1 commit
-
-
Daniel Bevenius authored
This commit adds comments to bio_method_st definitions where the function pointers are defined as NULL. Most of the structs have comments but some where missing and not all consitent. CLA: trivial Reviewed-by:
Paul Dale <paul.dale@oracle.com> Reviewed-by:
-
- 16 Dec, 2017 2 commits
-
-
Bernd Edlinger authored
Rename bio_info_cb to BIO_info_cb. Reviewed-by:
-
Bernd Edlinger authored
Reviewed-by:
-
- 15 Dec, 2017 1 commit
-
-
Bernd Edlinger authored
Reviewed-by:
-
- 13 Dec, 2017 8 commits
-
-
Viktor Dukhovni authored
Also improved documentation of TRUSTED_FIRST Reviewed-by:
-
Ben Kaduk authored
Fix a typo for "retrieve" and some indentation. Reviewed-by:
-
Benjamin Kaduk authored
make_dummy_resp() uses OCSP types, and get_cert_and_key() is unused once make_dummy_resp() is compiled out, so neither can be included in the build when OCSP is disabled and strict warnings are active. Reviewed-by:
-
Benjamin Kaduk authored
Avoid memory leaks in error paths, and correctly apply parentheses to function calls in a long if-chain. Reviewed-by:
-
Rich Salz authored
Reviewed-by:
-
Ben Kaduk authored
Reviewed-by:
-
Benjamin Kaduk authored
Some of the OCSP APIs (such as the recently added OCSP_resp_get0_signer) do not really merit inclusion in the ocsp(1) utility, but we should still have unit tests for them. For now, only test OCSP_resp_get0_signer(), but it should be easy to add more tests in the future. Provide an X509 cert and private key in the test's data directory to use for signing responses, since constructing those on the fly is more effort than is needed. Reviewed-by:
-
Benjamin Kaduk authored
Add a new function OCSP_resp_get0_signer() that looks in the certs bundled with the response as well as in additional certificates provided as a function argument, returning the certificate that signed the given response (if present). Reviewed-by:
-
- 12 Dec, 2017 2 commits
-
-
Patrick Steuer authored
Signed-off-by:
Patrick Steuer <patrick.steuer@de.ibm.com> Reviewed-by:
-
Richard Levitte authored
If OPENSSL_init_crypto() hasn't been called yet when ERR_get_state() is called, it need to be called early, so the base initialization is done. On some platforms (those who support DSO functionality and don't define OPENSSL_USE_NODELETE), that includes a call of ERR_set_mark(), which calls this function again. Furthermore, we know that ossl_init_thread_start(), which is called later in ERR_get_state(), calls OPENSSL_init_crypto(0, NULL), except that's too late. Here's what happens without an early call of OPENSSL_init_crypto(): => ERR_get_state(): => CRYPTO_THREAD_get_local(): <= NULL; # no state is found, so it gets allocated. => ossl_init_thread_start(): => OPENSSL_init_crypto(): # Here, base_inited is set to 1 # before ERR_set_mark() call => ERR_set_mark(): => ERR_get_state(): ...
-
- 11 Dec, 2017 2 commits
-
-
Benjamin Kaduk authored
Reviewed-by:
-
Matt Caswell authored
SSL_trace() has a case which was inadvertently falling through. Reviewed-by:
-
- 10 Dec, 2017 2 commits
-
-
FdaSilvaYY authored
check is already made 10 line above. clean commented code Reviewed-by:
-
Daniel Bevenius authored
I noticed that some of the BIO_METHOD structs are placing the name on the same line as the type and some don't. This commit places the name on a separate line for consistency (which looks like what the majority do) CLA: trivial Reviewed-by:
-
- 08 Dec, 2017 6 commits
-
-
Rich Salz authored
Reviewed-by:
-
Daniel Bevenius authored
CLA: trivial Reviewed-by:
-
FdaSilvaYY authored
Pointer 'o' is set inside a local buffer, so it can't be NULL. Also fix coding style and add comments Reviewed-by:
-
Richard Levitte authored
Otherwise, any command that relies on ssl modules may fail, because SSL_add_ssl_module() will be called after the config file has already been loaded. Fixes #4788 Reviewed-by:
-
Richard Levitte authored
IF OPENSSL_init_ssl() is called with the option flag OPENSSL_INIT_LOAD_CONFIG, any SSL config will be handled wrongly (i.e. there will be an attempt to load libssl_conf.so or whatever corresponds to that on non-Unix platforms). Therefore, at least SSL_add_ssl_module() MUST be called before OPENSSL_init_crypto() is called. The base ssl init does that, plus adds all kinds of ciphers and digests, which is harmless. Fixes #4788 Reviewed-by:
-
Richard Levitte authored
Some compilers react badly to non-ASCII characters Fixes #4877 Reviewed-by:
-
