- Dec 22, 2018
-
-
FdaSilvaYY authored
Call to i2d method returns an int value. Fix: CID 1338183 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371691 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371692 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) [extended tests] Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7359) (cherry picked from commit da84249b)
-
FdaSilvaYY authored
CID 1440002 (#1 of 1): Use after free (USE_AFTER_FREE) Not a deadly error, because error was just before app exit. Reviewed-by:
-
- Dec 20, 2018
-
-
Ken Goldman authored
The check_key_level() function currently fails when the public key cannot be extracted from the certificate because its algorithm is not supported. However, the public key is not needed for the last certificate in the chain. This change moves the check for level 0 before the check for a non-NULL public key. For background, this is the TPM 1.2 endorsement key certificate. I.e., this is a real application with millions of certificates issued. The key is an RSA-2048 key. The TCG (for a while) specified Public Key Algorithm: rsaesOaep rather than the commonly used Public Key Algorithm: rsaEncryption because the key is an encryption key rather than a signing key. The X509 certificate parser fails to get the public key. Reviewed-by:Viktor Dukhovni <viktor@openssl.org> Reviewed-by:
-
- Dec 19, 2018
-
-
Christian Heimes authored
The correct function name is SSL_CTX_enable_ct, not SSL_CTX_ct_enable. Signed-off-by:
Christian Heimes <christian@python.org> Reviewed-by:
Paul Dale <paul.dale@oracle.com> Reviewed-by:
-
- Dec 15, 2018
-
-
Dr. Matthias St. Pierre authored
While stereotyped repetitions are frowned upon in literature, they serve a useful purpose in manual pages, because it is easier for the user to find certain information if it is always presented in the same way. For that reason, this commit harmonizes the varying formulations in the HISTORY section about which functions, flags, etc. were added in which OpenSSL version. It also attempts to make the pod files more grep friendly by avoiding to insert line breaks between the symbol names and the corresponding version number in which they were introduced (wherever possible). Some punctuation and typographical errors were fixed on the way. Reviewed-by:
Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7854)
-
- Dec 14, 2018
-
-
Richard Levitte authored
It turns out that intialization may change the error number, so we need to preserve the system error number in functions where initialization is called for. These are ERR_get_state() and err_shelve_state() Fixes #7897 Reviewed-by:
-
- Dec 13, 2018
-
-
Mansour Ahmadi authored
Fixes #7657 Reviewed-by:
Nicola Tuveri <nic.tuv@gmail.com> Reviewed-by:
-
Mansour Ahmadi authored
Fixes #7650 Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> Reviewed-by:
-
Mansour Ahmadi authored
Fixes #7117 Reviewed-by:
-
- Dec 12, 2018
-
-
Richard Levitte authored
It turned out that .S files aren't to be treated as lightly as I thought. They need to go through a preprocessing step, which .s files don't need to. Corrects #7703 Reviewed-by:
-
Dr. Matthias St. Pierre authored
Fixes #7883 Reviewed-by:
-
Jakub Jelen authored
CLA: trivial Signed-off-by:
Jakub Jelen <jjelen@redhat.com> Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
Tobias Stoeckmann authored
There was a trailing :w at a line, which didn't make sense in context of the sentence/styling. Removed it, because I think it's a leftover vi command. CLA: trivial Signed-off-by:
Tobias Stoeckmann <tobias@stoeckmann.org> Reviewed-by:
Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by:
-
- Dec 11, 2018
-
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Check that s is less than the order before attempting to verify the signature as per RFC8032 5.2.7 Fixes #7706 Reviewed-by:
-
- Dec 10, 2018
-
-
Eneas U de Queiroz authored
Digest must be able to do partial-state copy to be used. Signed-off-by:
Eneas U de Queiroz <cote2004-github@yahoo.com> Reviewed-by:
-
Eneas U de Queiroz authored
Make CTR mode behave like a stream cipher. Signed-off-by:
-
Eneas U de Queiroz authored
The engine needs a custom cipher context copy function to open a new /dev/crypto session. Signed-off-by:
-
Eneas U de Queiroz authored
Close the session in digest_cleanup instead of digest_final. A failure in closing the session does not mean a previous successful digest final has failed as well. Signed-off-by:
-
Eneas U de Queiroz authored
If the source ctx has not been initialized, don't initialize the copy either. Signed-off-by:
-
Eneas U de Queiroz authored
Return failure when the digest_ctx is null in digest_update and digest_final, and when md is null in digest_final. Signed-off-by:
-
Eneas U de Queiroz authored
Call functions to prepare methods after confirming that /dev/crytpo was sucessfully open and that the destroy function has been set. Signed-off-by:
-
Eneas U de Queiroz authored
Signed-off-by:
-
Matt Caswell authored
Fixes #7727 Reviewed-by:
-
Matt Caswell authored
For the same reasons as in the previous commit we must preserve errno across dlopen calls. Some implementations (e.g. solaris) do not preserve errno even on a successful dlopen call. Fixes #6953 Reviewed-by:
-
Matt Caswell authored
This function can end up being called during ERR_get_error() if we are initialising. ERR_get_error() must preserve errno since it gets called via SSL_get_error(). If that function returns SSL_ERROR_SYSCALL then you are supposed to inspect errno. Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
- Dec 08, 2018
-
-
Andy Polyakov authored
Reviewed-by:
-
- Dec 07, 2018
-
-
Richard Levitte authored
It turns out that the strictness that was implemented in EVP_PKEY_asn1_new() (see Github openssl/openssl#6880) was badly placed for some usages, and that it's better to do this check only when the method is getting registered. Fixes #7758 Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
Paul Yang <yang.yang@baishancloud.com> Reviewed-by:
-
- Dec 06, 2018
-
-
Dr. Matthias St. Pierre authored
Reviewed-by:
-
Dr. Matthias St. Pierre authored
Fixes #7698 Reviewed-by:
-
- Dec 05, 2018
-
-
Matt Caswell authored
Fix some issues in tls13_hkdf_expand() which impact the above function for TLSv1.3. In particular test that we can use the maximum label length in TLSv1.3. Reviewed-by:
-
Matt Caswell authored
This reverts commit ec0c5f5693e39c5a013f81e6dd9dfd09ec65162d. SSL_export_keying_material() may use longer label lengths. Fixes #7712 Reviewed-by:
-
Andy Polyakov authored
Fixed-top interfaces tolerate zero-padded inputs and facilitate constant-time-ness. bn_div_fixed_top tolerates zero-padded dividend, but not divisor. It's argued that divisor's length is public even when value is secret. [extended tests] Reviewed-by:
-
Andy Polyakov authored
and add template for constant-time bn_div_3_words. Reviewed-by:
-
Andy Polyakov authored
Reviewed-by:
-
Andy Polyakov authored
It's being replaced with constant-time alternative. Reviewed-by:
-
