Skip to content
  1. Oct 10, 2017
  2. Oct 09, 2017
  3. Oct 08, 2017
  4. Oct 07, 2017
  5. Oct 06, 2017
  6. Oct 05, 2017
  7. Oct 04, 2017
  8. Oct 03, 2017
  9. Oct 02, 2017
  10. Sep 29, 2017
  11. Sep 28, 2017
  12. Sep 27, 2017
  13. Sep 26, 2017
    • David Benjamin's avatar
      Allow DH_set0_key with only private key. · 7966101e
      David Benjamin authored
      The pub_key field for DH isn't actually used in DH_compute_key at all.
      (Note the peer public key is passed in as as BIGNUM.) It's mostly there
      so the caller may extract it from DH_generate_key. It doesn't
      particularly need to be present if filling in a DH from external
      parameters.
      
      The check in DH_set0_key conflicts with adding OpenSSL 1.1.0 to Node.
      Their public API is a thin wrapper over the old OpenSSL one:
      https://nodejs.org/api/crypto.html#crypto_class_diffiehellman
      
      
      
      They have separate setPrivateKey and setPublicKey methods, so the public
      key may be set last or not at all. In 1.0.2, either worked fine since
      operations on DH objects generally didn't use the public key.  (Like
      with OpenSSL, Node's setPublicKey method is also largely a no-op, but so
      it goes.) In 1.1.0, DH_set0_key prevents create a private-key-only DH
      object.
      
      Reviewed-by: default avatarAndy Polyakov <appro@openssl.org>
      Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
      Reviewed-by: default avatarBernd Edlinger <bernd.edlinger@hotm...>
      7966101e