1. 03 May, 2016 1 commit
    • Matt Caswell's avatar
      Fix encrypt overflow · 3ab937bc
      Matt Caswell authored
      
      
      An overflow can occur in the EVP_EncryptUpdate function. If an attacker is
      able to supply very large amounts of input data after a previous call to
      EVP_EncryptUpdate with a partial block then a length check can overflow
      resulting in a heap corruption.
      
      Following an analysis of all OpenSSL internal usage of the
      EVP_EncryptUpdate function all usage is one of two forms.
      
      The first form is like this:
      EVP_EncryptInit()
      EVP_EncryptUpdate()
      
      i.e. where the EVP_EncryptUpdate() call is known to be the first called
      function after an EVP_EncryptInit(), and therefore that specific call
      must be safe.
      
      The second form is where the length passed to EVP_EncryptUpdate() can be
      seen from the code to be some small value and therefore there is no
      possibility of an overflow.
      
      Since all instances are one of these two forms, I believe that there can
      be no overflows in internal code due to this problem.
      
      It should be noted that EVP_DecryptUpdate() can call EVP_EncryptUpdate()
      in certain code paths. Also EVP_CipherUpdate() is a synonym for
      EVP_EncryptUpdate(). Therefore I have checked all instances of these
      calls too, and came to the same conclusion, i.e. there are no instances
      in internal usage where an overflow could occur.
      
      This could still represent a security issue for end user code that calls
      this function directly.
      
      CVE-2016-2106
      
      Issue reported by Guido Vranken.
      
      Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
      (cherry picked from commit 3f358213)
      3ab937bc
  2. 02 May, 2016 3 commits
  3. 29 Apr, 2016 4 commits
  4. 27 Apr, 2016 1 commit
  5. 26 Apr, 2016 1 commit
  6. 25 Apr, 2016 3 commits
  7. 23 Apr, 2016 1 commit
  8. 22 Apr, 2016 1 commit
  9. 07 Apr, 2016 2 commits
  10. 04 Apr, 2016 1 commit
  11. 26 Mar, 2016 1 commit
  12. 18 Mar, 2016 4 commits
  13. 14 Mar, 2016 1 commit
  14. 09 Mar, 2016 3 commits
  15. 08 Mar, 2016 1 commit
  16. 07 Mar, 2016 4 commits
  17. 04 Mar, 2016 1 commit
    • Dr. Stephen Henson's avatar
      Sanity check PVK file fields. · df14e502
      Dr. Stephen Henson authored
      
      
      PVK files with abnormally large length or salt fields can cause an
      integer overflow which can result in an OOB read and heap corruption.
      However this is an rarely used format and private key files do not
      normally come from untrusted sources the security implications not
      significant.
      
      Fix by limiting PVK length field to 100K and salt to 10K: these should be
      more than enough to cover any files encountered in practice.
      
      Issue reported by Guido Vranken.
      
      Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
      (cherry picked from commit 5f57abe2)
      df14e502
  18. 01 Mar, 2016 7 commits