1. 22 Aug, 2016 2 commits
    • Matt Caswell's avatar
      Fix DTLS buffered message DoS attack · 26f2c577
      Matt Caswell authored
      
      
      DTLS can handle out of order record delivery. Additionally since
      handshake messages can be bigger than will fit into a single packet, the
      messages can be fragmented across multiple records (as with normal TLS).
      That means that the messages can arrive mixed up, and we have to
      reassemble them. We keep a queue of buffered messages that are "from the
      future", i.e. messages we're not ready to deal with yet but have arrived
      early. The messages held there may not be full yet - they could be one
      or more fragments that are still in the process of being reassembled.
      
      The code assumes that we will eventually complete the reassembly and
      when that occurs the complete message is removed from the queue at the
      point that we need to use it.
      
      However, DTLS is also tolerant of packet loss. To get around that DTLS
      messages can be retransmitted. If we receive a full (non-fragmented)
      message from the peer after previously having received a fragment of
      that message, then we ignore the message in the queue and just use the
      non-fragmented version. At that point the queued message will never get
      removed.
      
      Additionally the peer could send "future" messages that we never get to
      in order to complete the handshake. Each message has a sequence number
      (starting from 0). We will accept a message fragment for the current
      message sequence number, or for any sequence up to 10 into the future.
      However if the Finished message has a sequence number of 2, anything
      greater than that in the queue is just left there.
      
      So, in those two ways we can end up with "orphaned" data in the queue
      that will never get removed - except when the connection is closed. At
      that point all the queues are flushed.
      
      An attacker could seek to exploit this by filling up the queues with
      lots of large messages that are never going to be used in order to
      attempt a DoS by memory exhaustion.
      
      I will assume that we are only concerned with servers here. It does not
      seem reasonable to be concerned about a memory exhaustion attack on a
      client. They are unlikely to process enough connections for this to be
      an issue.
      
      A "long" handshake with many messages might be 5 messages long (in the
      incoming direction), e.g. ClientHello, Certificate, ClientKeyExchange,
      CertificateVerify, Finished. So this would be message sequence numbers 0
      to 4. Additionally we can buffer up to 10 messages in the future.
      Therefore the maximum number of messages that an attacker could send
      that could get orphaned would typically be 15.
      
      The maximum size that a DTLS message is allowed to be is defined by
      max_cert_list, which by default is 100k. Therefore the maximum amount of
      "orphaned" memory per connection is 1500k.
      
      Message sequence numbers get reset after the Finished message, so
      renegotiation will not extend the maximum number of messages that can be
      orphaned per connection.
      
      As noted above, the queues do get cleared when the connection is closed.
      Therefore in order to mount an effective attack, an attacker would have
      to open many simultaneous connections.
      
      Issue reported by Quan Luo.
      
      CVE-2016-2179
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      26f2c577
    • Matt Caswell's avatar
      0ee4f13b
  2. 21 Aug, 2016 3 commits
  3. 20 Aug, 2016 1 commit
  4. 19 Aug, 2016 13 commits
    • Rich Salz's avatar
      RT3940: For now, just document the issue. · ff5537c2
      Rich Salz authored
      
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      (cherry picked from commit 2a9afa40)
      ff5537c2
    • Rich Salz's avatar
      Fix NULL-return checks in 1.0.2 · a03f81f4
      Rich Salz authored
      
      
      RT4386: Add sanity checks for BN_new()
      RT4384: Missing Sanity Checks for RSA_new_method()
      RT4384: Missing Sanity Check plus potential NULL pointer deref
      RT4382: Missing Sanity Check(s) for BUF_strdup()
      RT4380: Missing Sanity Checks for EVP_PKEY_new()
      RT4377: Prevent potential NULL pointer dereference
      RT4375: Missing sanity checks for OPENSSL_malloc()
      RT4374: Potential for NULL pointer dereferences
      RT4371: Missing Sanity Check for malloc()
      RT4370: Potential for NULL pointer dereferences
      
      Also expand tabs, make update, typo fix (rsalz)
      Minor tweak by Paul Dale.
      Some minor internal review feedback.
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      a03f81f4
    • Richard Levitte's avatar
      Have dtlstest run on VMS as well · 66e70832
      Richard Levitte authored
      
      
      Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
      66e70832
    • Matt Caswell's avatar
      Update function error code · 26aebca7
      Matt Caswell authored
      
      
      A function error code needed updating due to merge issues.
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      26aebca7
    • Matt Caswell's avatar
      Fix DTLS replay protection · 3884b47b
      Matt Caswell authored
      
      
      The DTLS implementation provides some protection against replay attacks
      in accordance with RFC6347 section 4.1.2.6.
      
      A sliding "window" of valid record sequence numbers is maintained with
      the "right" hand edge of the window set to the highest sequence number we
      have received so far. Records that arrive that are off the "left" hand
      edge of the window are rejected. Records within the window are checked
      against a list of records received so far. If we already received it then
      we also reject the new record.
      
      If we have not already received the record, or the sequence number is off
      the right hand edge of the window then we verify the MAC of the record.
      If MAC verification fails then we discard the record. Otherwise we mark
      the record as received. If the sequence number was off the right hand edge
      of the window, then we slide the window along so that the right hand edge
      is in line with the newly received sequence number.
      
      Records may arrive for future epochs, i.e. a record from after a CCS being
      sent, can arrive before the CCS does if the packets get re-ordered. As we
      have not yet received the CCS we are not yet in a position to decrypt or
      validate the MAC of those records. OpenSSL places those records on an
      unprocessed records queue. It additionally updates the window immediately,
      even though we have not yet verified the MAC. This will only occur if
      currently in a handshake/renegotiation.
      
      This could be exploited by an attacker by sending a record for the next
      epoch (which does not have to decrypt or have a valid MAC), with a very
      large sequence number. This means the right hand edge of the window is
      moved very far to the right, and all subsequent legitimate packets are
      dropped causing a denial of service.
      
      A similar effect can be achieved during the initial handshake. In this
      case there is no MAC key negotiated yet. Therefore an attacker can send a
      message for the current epoch with a very large sequence number. The code
      will process the record as normal. If the hanshake message sequence number
      (as opposed to the record sequence number that we have been talking about
      so far) is in the future then the injected message is bufferred to be
      handled later, but the window is still updated. Therefore all subsequent
      legitimate handshake records are dropped. This aspect is not considered a
      security issue because there are many ways for an attacker to disrupt the
      initial handshake and prevent it from completing successfully (e.g.
      injection of a handshake message will cause the Finished MAC to fail and
      the handshake to be aborted). This issue comes about as a result of trying
      to do replay protection, but having no integrity mechanism in place yet.
      Does it even make sense to have replay protection in epoch 0? That
      issue isn't addressed here though.
      
      This addressed an OCAP Audit issue.
      
      CVE-2016-2181
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      3884b47b
    • Matt Caswell's avatar
      Add DTLS replay protection test · 30ea36e6
      Matt Caswell authored
      
      
      Injects a record from epoch 1 during epoch 0 handshake, with a record
      sequence number in the future, to test that the record replay protection
      feature works as expected. This is described more fully in the next commit.
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      30ea36e6
    • Matt Caswell's avatar
      Fix DTLS unprocessed records bug · 20744f6b
      Matt Caswell authored
      
      
      During a DTLS handshake we may get records destined for the next epoch
      arrive before we have processed the CCS. In that case we can't decrypt or
      verify the record yet, so we buffer it for later use. When we do receive
      the CCS we work through the queue of unprocessed records and process them.
      
      Unfortunately the act of processing wipes out any existing packet data
      that we were still working through. This includes any records from the new
      epoch that were in the same packet as the CCS. We should only process the
      buffered records if we've not got any data left.
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      20744f6b
    • Matt Caswell's avatar
      Add a DTLS unprocesed records test · bc4d7e12
      Matt Caswell authored
      
      
      Add a test to inject a record from the next epoch during the handshake and
      make sure it doesn't get processed immediately.
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      bc4d7e12
    • Matt Caswell's avatar
      Back port ssltestlib code to 1.0.2 · 48e8df6e
      Matt Caswell authored
      
      
      Enables the testing of DTLS code in 1.0.2
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      48e8df6e
    • Richard Levitte's avatar
      VSI submission: RAND fixups · 7b415b0e
      Richard Levitte authored
      
      
      - make the VMS version of RAND_poll() faster and more secure
      - avoid pointer size warnings with setvbuf()
      
      Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
      7b415b0e
    • Richard Levitte's avatar
    • Richard Levitte's avatar
      556c4b51
    • Richard Levitte's avatar
  5. 18 Aug, 2016 1 commit
  6. 16 Aug, 2016 1 commit
  7. 15 Aug, 2016 3 commits
  8. 11 Aug, 2016 1 commit
  9. 05 Aug, 2016 2 commits
  10. 04 Aug, 2016 4 commits
  11. 03 Aug, 2016 1 commit
  12. 02 Aug, 2016 4 commits
  13. 29 Jul, 2016 1 commit
  14. 28 Jul, 2016 1 commit
  15. 26 Jul, 2016 2 commits