- Sep 19, 2018
-
-
Benjamin Kaduk authored
Historically SSL_CTX_set_ssl_version() has reset the cipher list to the default. Splitting TLS 1.3 ciphers to be tracked separately caused a behavior change, in that TLS 1.3 cipher configuration was preserved across calls to SSL_CTX_set_ssl_version(). To restore commensurate behavior with the historical behavior, set the ciphersuites to the default as well as setting the cipher list to the default. Closes: #7226 Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7270) (cherry picked from commit 2340ed27)
-
- Sep 18, 2018
-
-
Dr. Matthias St. Pierre authored
Fixes #7252 Reviewed-by:
Tim Hudson <tjh@openssl.org> Reviewed-by:
Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7253) (cherry picked from commit f9a22815)
-
Tobias Nießen authored
This commit reuses a variable instead of reevaluating the expression and updates an outdated comment in the EVP test. Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/7242) (cherry picked from commit 523fcfb4)
-
- Sep 17, 2018
-
-
David Makepeace authored
Reviewed-by:
-
Pauli authored
Specifically, include e_os.h to pick up alloca definition for WIN32. Reviewed-by:
-
- Sep 16, 2018
-
-
Pauli authored
The latter causes problems when complex.h is #included. Reviewed-by:
-
Pauli authored
coexist. Reviewed-by:
-
Matt Eaton authored
Fixed a minor typo while reading the documentation. I agree that this contribution is trivial can be freely used. CLA: trivial Reviewed-by:
Nicola Tuveri <nic.tuv@gmail.com> Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/7221)
-
Kurt Roeckx authored
Reviewed-by:
Ben Kaduk <kaduk@mit.edu> GH: #7188 (cherry picked from commit 8e593f0a)
-
- Sep 15, 2018
-
-
Richard Levitte authored
It simply isn't available on older versions. Issue submitted by Mark Daniels Fixes #7229 Reviewed-by:
-
- Sep 13, 2018
-
-
Paul Yang authored
Reviewed-by:
Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7209)
-
Matt Caswell authored
-early_data is not compatible with -www, -WWW, -HTTP or -rev. Fixes #7200 Reviewed-by:
-
Matt Caswell authored
Caused a compilation failure in some environments Fixes #7204 Reviewed-by:
Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7205) (cherry picked from commit bc278f30)
-
- Sep 12, 2018
-
-
Dr. Matthias St. Pierre authored
The new DRBG API added the aforementioned #define. However, it is used internally only and having it defined publicly does not serve any purpose except causing potential version compatibility problems. Fixes #7182 Reviewed-by:
-
Bernd Edlinger authored
Fixes: #7161 (hopefully) Reviewed-by:
-
Brian 'geeknik' Carpenter authored
Fixes a minor typo that would cause the linker to complain about not finding -lFuzzer CLA: trivial Reviewed-by:
-
Viktor Szakats authored
- fix to use secure URL in generated Windows resources - fix a potentially uninitialized variable - fix an unused variable warning CLA: trivial Reviewed-by:
-
Richard Levitte authored
Fixes #7186 Reviewed-by:
-
- Sep 11, 2018
-
-
Matt Caswell authored
Reviewed-by: -
Matt Caswell authored
Reviewed-by: -
Matt Caswell authored
Reviewed-by:
-
Richard Levitte authored
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became unusable. This change fixes that. Fixes #7131 Reviewed-by:
-
- Sep 10, 2018
-
-
Matt Caswell authored
Found by Coverity Reviewed-by:
-
Matt Caswell authored
Fixes a Coverity complaint. Reviewed-by:
-
Matt Caswell authored
If sizeof(int) != sizeof(size_t) this may not work correctly. Fixes a Coverity issue. Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Matt Caswell authored
Hopefully this will resolve spurious travis failures. [extended tests] Reviewed-by:
-
Paul Yang authored
Reviewed-by:
-
Dr. Matthias St. Pierre authored
It's actually not a real issue but caused by the absence of the default case which does not occur in reality but which makes coverity see a code path where pkey remains unassigned. Reported by Coverity Scan (CID 1423323) [extended tests] Reviewed-by:
-
Dr. Matthias St. Pierre authored
Reported by Coverity Scan (CID 1439138) [extended tests] Reviewed-by:
-
Dr. Matthias St. Pierre authored
Reported by Coverity Scan (CID 1439136) [extended tests] Reviewed-by:
-
- Sep 09, 2018
-
-
Richard Levitte authored
The deprecated ASN.1 type LONG / ZLONG (incorrectly) produced zero length INTEGER encoding for zeroes. For the sake of backward compatibility, we allow those to be read without fault when using the replacement types INT32 / UINT32 / INT64 / UINT64. Fixes #7134 Reviewed-by:
-
Richard Levitte authored
Confirms #7134 Reviewed-by:
-
- Sep 08, 2018
-
-
Richard Levitte authored
This was originally part of SipHash_Init. However, there are cases where there isn't any key material to initialize from when setting the hash size, and we do allow doing so with a EVP_PKEY control. The solution is to provide a separate hash_size setter and to use it in the corresponding EVP_PKEY_METHOD. Fixes #7143 Reviewed-by:
-
Richard Levitte authored
Confirms #7143 Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
Richard Levitte authored
Reviewed-by:
-
- Sep 07, 2018
-
-
Matt Caswell authored
PR #3783 introduce coded to reset the server side SNI state in SSL_do_handshake() to ensure any erroneous config time SNI changes are cleared. Unfortunately SSL_do_handshake() can be called mid-handshake multiple times so this is the wrong place to do this and can mean that any SNI data is cleared later on in the handshake too. Therefore move the code to a more appropriate place. Fixes #7014 Reviewed-by:
-
Ben Kaduk authored
Ideally, SSL_get_servername() would do exactly as it is documented and return exactly what the client sent (i.e., what we currently are stashing in the SSL's ext.hostname), without needing to refer to an SSL_SESSION object. For historical reasons, including the parsed SNI value from the ClientHello originally being stored in the SSL_SESSION's ext.hostname field, we have had references to the SSL_SESSION in this function. We cannot fully excise them due to the interaction between user-supplied callbacks and TLS 1.2 resumption flows, where we call all callbacks but the client did not supply an SNI value. Existing callbacks expect to receive a valid SNI value in this case, so we must fake one up from the resumed session in order to avoid breakage. Otherwise, greatly simplify the implementation and just return the value in the SSL, as sent by the client. Reviewed-by:
-
