- May 29, 2016
-
-
Joey Yandle authored
Reviewed-by:
Matt Caswell <matt@openssl.org> Reviewed-by:
Tim Hudson <tjh@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1079)
-
Joey Yandle authored
Reviewed-by:
-
Joey Yandle authored
Reviewed-by:
-
Joey Yandle authored
Reviewed-by:
-
Joey Yandle authored
Reviewed-by:
-
Joey Yandle authored
Reviewed-by:
-
Joey Yandle authored
Reviewed-by:
-
Joey Yandle authored
Reviewed-by:
-
Joey Yandle authored
Reviewed-by:
-
Andy Polyakov authored
[as it is now quoting $output is not required, but done just in case] Reviewed-by:Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
As it turns out default glob's behaviour for quoted argument varies from version to version, making it impossible to Configure or run tests in some cases. The reason for quoting globs was to accommodate source path with spaces in its name, which was treated by default glob as multiple paths. File::Glob::glob on the other hand doesn't consider spaces as delimiters and therefore works with unquoted patterns. [Unfortunaltely File::Glob::glob, being too csh-ly, doesn't work on VMS, hence the "pinning" is conditional.] Reviewed-by:
-
- May 28, 2016
-
-
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
Andy Polyakov authored
Reviewed-by: -
Andy Polyakov authored
Reviewed-by: -
Richard Levitte authored
Reviewed-by:Viktor Dukhovni <viktor@openssl.org>
-
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
Their only reason to exist was that they didn't exist in VMS before version 7.0. We do not support such old versions any more. However, for the benefit of systems that don't get strings.h included by string.h, we include the former in e_os.h. RT#4458 Reviewed-by:
-
- May 27, 2016
-
-
Andy Polyakov authored
Newer gcc still recognizes e.g. -std=c9x in which case it wouldn't have used 'noreturn' at all with original logic. Reviewed-by: -
Andy Polyakov authored
Reviewed-by: -
Andy Polyakov authored
not by OS [as was implied by guarding #if condition]. Reviewed-by: -
Andy Polyakov authored
Reviewed-by: -
Andy Polyakov authored
Reviewed-by: -
Kurt Roeckx authored
We can call memcpy() with a pointer 1 past the last allocated byte and length of 0 and you can argue that that's undefined behaviour. Reported by tis-interpreter Reviewed-by: -
Todd Short authored
When setting the certificate chain, if a certificate doesn't pass security checks, then chain may point to a freed STACK_OF(X509) Reviewed-by:
-
Richard Levitte authored
- If we have a maximum amount of characters permitted to be printed (for example "%.2s", which allows for a maximum of 2 chars), we minimize the number of characters from the string to printed to that size. - If there is space for padding and there is a maximum amount of characters to print (for example "%3.2s", which shall give at least a 1 space padding), the amount of characters to pad with gets added to the maximum so the minimum field size (3 in this example) gets filled out. Reviewed-by: -
Richard Levitte authored
RT#4486 Reviewed-by: -
Richard Levitte authored
RT#4486 Reviewed-by: -
Richard Levitte authored
This applies when building out-of-source. RT#4486 NOTE: we can't do the same for Unix, as Unix make doesn't handle this type of issue. Also, directory specs are much less likely to have spaces on Unix... Reviewed-by: -
Richard Levitte authored
RT#4486 Reviewed-by: -
Richard Levitte authored
Someone wants to configure like this: PERL="/usr/bin/env perl" ./config The end goal is to get that in the #! line of CA.pl and a few other scripts. That works well already, but in the Makefile, there were a few lines looking like this: PERL=$(PERL) $(PERL) whatever.pl ... Those need some quoting. RT#4311 Reviewed-by: -
Matt Caswell authored
If using the msys console then msys attempts to "fix" command line arguments to convert them from Unix style to Windows style. One of the things it does is to look for arguments seperated by colons. This it assumes is a list of file paths, so it replaces the colon with a semi-colon. This was causing one of our tests to fail when calling the "req" command line app. We were attempting to create a new DSA key and passing the argument "dsa:../apps/dsa1024.pem". This is exactly what we intended but Msys mangles it to "dsa;../apps/dsa1024.pem" and the command fails. There doesn't seem to be a way to suppress Msys name mangling. Fortunately we can work around this issue by generating the DSA key in a separate step by calling "gendsa". RT#4255 Reviewed-by: -
Matt Caswell authored
When closing down the socket in s_client Windows will close it immediately even if there is data in the write buffer still waiting to be sent. This was causing tests to fail in Msys/Mingw builds because TLSProxy doesn't see the final CloseNotify. I have experimented with various ways of doing this "properly" (e.g. shutting down the socket before closing, setting SO_LINGER etc). I can't seem to find the "magic" formula that will make Windows do this. Inserting a short 50ms sleep seems to do the trick...but its not very "nice" so I've inserted a TODO on this item. Perhaps someone else will have better luck in figuring this out. RT#4255 Reviewed-by: -
Matt Caswell authored
On Windows we were using the function _kbhit() to determine whether there was input waiting in stdin for us to read. Actually all this does is work out whether there is a keyboard press event waiting to be processed in the input buffer. This only seems to work in a standard Windows console (not Msys console) and also doesn't work if you redirect the input from some other source (as we do in TLSProxy tests). This commit changes things to work differently depending on whether we are on the Windows console or not. RT#4255 Reviewed-by: -
Matt Caswell authored
In s_server we call BIO_sock_should_retry() to determine the state of the socket and work out whether we should retry an operation on it or not. However if you leave it too long to call this then other operations may have occurred in the meantime which affect the result. Therefore we should call it early and remember the result for when we need to use it. This fixes a test problem on Windows. Another issue with s_server on Windows is that some of output to stdout does not get displayed immediately. Apparently more liberal use of BIO_flush is required. RT#4255 Reviewed-by: -
Matt Caswell authored
Clang was complaining about some variables possibly being uninitialized when used. The warnings are bogus, but clang can't figure that out. This silences the warnings. Reviewed-by: -
Matt Caswell authored
Previous commits fixed the implementation of the %e and %g format specifiers as well as other issues. This commit adds a test. Reviewed-by: -
Matt Caswell authored
We convert the integer part of the float to a long. We should check it fits first. Issue reported by Guido Vranken. GitHub Issue #1102 Reviewed-by: -
Matt Caswell authored
The previous commit which "fixed" the "e" and "g" floating point formats just printed them in the same way as "f". This is wrong. This commit provides the correct formatting. Reviewed-by: -
Matt Caswell authored
Convert assert to OPENSSL_assert(), add some documentation, add the calls to fmtfp() for the "e" and "g" floating point formats which were missing. Based on a patch provided by Ger Hobbelt <ger@hobbelt.com>. RT#2270 Reviewed-by:
-
