Skip to content
  1. Apr 04, 2016
  2. Apr 03, 2016
  3. Apr 02, 2016
  4. Apr 01, 2016
  5. Mar 31, 2016
  6. Mar 30, 2016
    • Matt Caswell's avatar
      Remove the CRYPTO_mem_leaks adjustment for the BIO · b3895f42
      Matt Caswell authored
      
      
      CRYPTO_mem_leaks attempts to adjust the count of bytes leaks to not
      include the BIO that is being used to print the results out. However this
      does not work properly. In all internal cases we switch off recording
      the memory allocation during creation of the BIO so it makes no difference.
      In other cases if the BIO allocates any additional memory during
      construction then the adjustment will be wrong anyway. It also skips over
      the BIO memory during print_leak anyway, so the BIO memory is never
      added into the total. In other words this was broken in lots of ways and
      has been since it was first added.
      
      The simplest solution is just to make it the documented behaviour that
      you must turn off memory logging when creating the BIO, and remove all
      the adjustment stuff completely. The adjustment code was only ever in
      master and never made it to a release branch so there is no loss of
      functionality.
      
      This commit also fixes a compilation failure when using
      enable-crypto-mdebug.
      
      Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
      b3895f42
    • Ben Laurie's avatar
      Fix buffer overrun in ASN1_parse(). · 79c7f74d
      Ben Laurie authored
      
      
      Fix buffer overrun in asn1_get_length().
      
      Reproducer: asn1parse-reproduce crash-6bfd417f47bc940f6984f5e639b637fd4e6074bc
      
      Fix length calculations.
      
      Reproducer: asn1parse-reproduce crash-1819d0e54cd2b0430626c59053e6077ef04c2ffb
      Reproducer: asn1parse-reproduce crash-9969db8603e644ddc0ba3459b51eac7a2c4b729b
      
      Make i long.
      
      Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
      79c7f74d