- 15 Jan, 2019 2 commits
-
-
Daniel Stenberg authored
Since they're used purely for testing purposes, I think they should rather be stored there. Closes #3470
-
Sergei Nikulov authored
-
- 14 Jan, 2019 3 commits
-
-
Frank Gevaerts authored
Closes #3469
-
Marcel Raad authored
zlibwapi.lib (dynamic library) and zlibstat.lib (static library) have the ZLIB_WINAPI define set by default. Using them requires that define too. Ref: https://zlib.net/DLL_FAQ.txt Fixes https://github.com/curl/curl/issues/3133 Closes https://github.com/curl/curl/pull/3460
-
Daniel Stenberg authored
-
- 13 Jan, 2019 2 commits
-
-
Daniel Stenberg authored
Make sure that this function sets a proper "live" transfer for the connection before calling the protocol-specific connection check function, and then clear it again afterward as a non-used connection has no current transfer. Reported-by: Jeroen Ooms Reviewed-by: Marcel Raad Reviewed-by: Daniel Gustafsson Fixes #3463 Closes #3464
-
Daniel Stenberg authored
OpenSSL_version() replaces OpenSSL_version_num() Closes #3462
-
- 11 Jan, 2019 3 commits
-
-
Sergei Nikulov authored
-
Daniel Stenberg authored
We use "conn" everywhere to be a pointer to the connection. Introduces two functions that "attaches" and "detaches" the connection to and from the transfer. Going forward, we should favour using "data->conn" (since a transfer always only has a single connection or none at all) to "conn->data" (since a connection can have none, one or many transfers associated with it and updating conn->data to be correct is error prone and a frequent reason for internal issues). Closes #3442
-
Daniel Stenberg authored
When calculating the progress bar width. Reported-by: Peng Li Fixes #3456 Closes #3458
-
- 10 Jan, 2019 10 commits
-
-
Daniel Gustafsson authored
Invoking the maintainer intended COPYRIGHTYEAR check for everyone in the PR pipeline is too invasive, especially at the turn of the year when many files get affected. Remove and leave it as a tool for maintainers to verify patches before commits. This reverts f7bdf4b2. After discussion with: Daniel Stenberg
-
Daniel Stenberg authored
Closes #3125
-
Daniel Stenberg authored
Closes #3229
-
Patrick Monnerat authored
See https://github.com/curl/curl/issues/3453#issuecomment-453054458 Reported-by: jonrumsey on github
-
Patrick Monnerat authored
Reported-by: jonrumsey on github Closes #3453
-
Daniel Stenberg authored
Attempt to reproduce issue #3444. Closes #3447
-
Daniel Stenberg authored
-
Daniel Stenberg authored
Both user and password are cleared uncondtitionally. Added unit test 1621 to verify. Fixes #3423 Closes #3433
-
Daniel Stenberg authored
Added test 1562 to verify. Reported-by: Jeroen Ooms Fixes #3445 Closes #3450
-
Daniel Stenberg authored
Fixes #3436 Closes #3448 Problem 1 After LOTS of scratching my head, I eventually realized that even when doing 10 uploads in parallel, sometimes the socket callback to the application that tells it what to wait for on the socket, looked like it would reflect the status of just the single transfer that just changed state. Digging into the code revealed that this was indeed the truth. When multiple transfers are using the same connection, the application did not correctly get the *combined* flags for all transfers which then could make it switch to READ (only) when in fact most transfers wanted to get told when the socket was WRITEABLE. Problem 1b A separate but related regression had also been introduced by me when I cleared connection/transfer association better a while ago, as now the logic couldn't find the connection and see if that was marked as used by more transfers and then it would also prematurely remove the socket from the socket hash table even in times other transfers were still using it! Fix 1 Make sure that each socket stored in the socket hash has a "combined" action field of what to ask the application to wait for, that is potentially the ORed action of multiple parallel transfers. And remove that socket hash entry only if there are no transfers left using it. Problem 2 The socket hash entry stored an association to a single transfer using that socket - and when curl_multi_socket_action() was called to tell libcurl about activities on that specific socket only that transfer was "handled". This was WRONG, as a single socket/connection can be used by numerous parallel transfers and not necessarily a single one. Fix 2 We now store a list of handles in the socket hashtable entry and when libcurl is told there's traffic for a particular socket, it now iterates over all known transfers using that single socket.
-
- 09 Jan, 2019 4 commits
-
-
Daniel Stenberg authored
[skip ci]
-
Katsuhiko YOSHIDA authored
Closes #3417
-
Daniel Stenberg authored
[skip ci]
-
Daniel Stenberg authored
Bug: https://curl.haxx.se/mail/lib-2018-12/0088.html Closes #3449
-
- 08 Jan, 2019 1 commit
-
-
Bernhard M. Wiedemann authored
similar to commit f508d29f Closes #3443
-
- 07 Jan, 2019 4 commits
-
-
Daniel Stenberg authored
-
Brad Spencer authored
Added Curl_resolver_kill() for all three resolver modes, which only blocks when necessary, along with test 1592 to confirm curl_multi_remove_handle() doesn't block unless it must. Closes #3428 Fixes #3371
-
Daniel Stenberg authored
This reverts commit 07ebaf83. This also reopens PR #3275 which brought the change now reverted. Fixes #3384 Closes #3439
-
Daniel Stenberg authored
This allows programs to include curl/urlapi.h directly. Reviewed-by: Daniel Gustafsson Reported-by: Ben Kohler Fixes #3438 Closes #3441
-
- 06 Jan, 2019 2 commits
-
-
Marcel Raad authored
Starting with Visual Studio 2017 Update 9, Visual Studio doesn't like the MinimalRebuild option anymore and warns: cl : Command line warning D9035: option 'Gm' has been deprecated and will be removed in a future release The option can be safely removed so that the default is used. Closes https://github.com/curl/curl/pull/3425
-
Marcel Raad authored
When building with Unicode on MSVC, the compiler warns about freeing a pointer to const in Curl_unicodefree. Fix this by declaring it as non-const and casting the argument to Curl_convert_UTF8_to_tchar to non-const too, like we do in all other places. Closes https://github.com/curl/curl/pull/3435
-
- 04 Jan, 2019 2 commits
-
-
Rikard Falkeborn authored
-
Rikard Falkeborn authored
Closes #3426
-
- 03 Jan, 2019 3 commits
-
-
Daniel Stenberg authored
... since it doesn't link with libcurl. Reverts the commit dcd6f810 changes from this file. Bug: https://curl.haxx.se/mail/lib-2019-01/0000.html Reported-by: Shlomi Fish Reviewed-by: Daniel Gustafsson Reviewed-by: Kamil Dudka Closes #3434
-
Daniel Stenberg authored
Closes #3431
-
Daniel Stenberg authored
Reviewed-by: Daniel Gustafsson Closes #3432
-
- 02 Jan, 2019 3 commits
-
-
Rikard Falkeborn authored
Add a few missing examples to make `make examples` not leave the workspace in a dirty state. Closes #3427 Reviewed-by:
Daniel Gustafsson <daniel@yesql.se>
-
Daniel Gustafsson authored
Add Adrian Burcea who made the artwork for the curl://up 2018 event which was held in Stockholm, Sweden.
-
Daniel Gustafsson authored
When a non-empty list is appended to, and used as the returnvalue, the list pointer can leak in case of an allocation failure in the curl_slist_append() call. This is correctly handled in curl code usage but we weren't explicitly pointing it out in the API call documentation. Fix by extending the RETURNVALUE manpage section and example code. Closes #3424 Reported-by: dnivras on github Reviewed-by:
Daniel Stenberg <daniel@haxx.se>
-
- 01 Jan, 2019 1 commit
-
-
Marcel Raad authored
MinGW-w64 defaults to targeting Windows 7 now, so GetTickCount64 is used and the milliseconds are represented as unsigned long long, leading to a compiler warning when implicitly converting them to long.
-