1. 14 Aug, 2011 4 commits
    • Daniel Stenberg's avatar
      Curl_output_ntlm: remove unused variable · dfb18da5
      Daniel Stenberg authored
      dfb18da5
    • Yang Tse's avatar
      0c4ec803
    • Yang Tse's avatar
      http NTLM: fix 8 compiler warnings · dc4f9d18
      Yang Tse authored
      Strict splitting of http_ntlm.[ch] may trigger 8 compiler warnings when
      building with some compilers and strict compiler warnings enabled, depending
      on other specific configuration options some could get triggered or not.
      
      Seven are related with 'unused function parameters' and another one with
      'var may be used before its value is set'.
      dc4f9d18
    • Yang Tse's avatar
      http NTLM: split http_ntlm.[ch] between http_ntlm.[ch] and curl_ntlm.[ch] · 98fb0ef7
      Yang Tse authored
      For modularity purposes, huge chunks of NTLM existing code is transformed into
      functions to allow future internal code reuse.
      
      Resulting three new libcurl private functions:
      
       - Curl_ntlm_create_type1_message()
       - Curl_ntlm_create_type3_message()
       - Curl_ntlm_decode_type2_message()
      
      Changing static ntlm_sspi_cleanup() into non-static Curl_ntlm_sspi_cleanup()
      
      This 'refactoring' has been prepared by previous commits to allow that this
      specific one does not introduce any change to existing code. All existing
      goodness and badness previous to this commit should remain the same once it is
      applied, the only difference should be that existing code is moved into
      functions.
      
      Given the quite big portions of code being moved around, and the importance of
      change traceability, this commit has been done in such a way that it is
      possible to perform a three-way diff from initial http_ntlm.[ch] to resulting
      http_ntlm.[ch] and curl_ntlm.[ch] to actually verify that no functional change
      is introduced here.
      
      Notice that Steve Holme has provided several patches, but these included this
      refactoring along with 'extra' fixes. I really wanted this 'clean' refactoring
      done first, in order to allow discussion or committing of 'extra' fixes on a
      case by case basis, so, I had to bite the bullet ;-)
      
      Comments, line adjustments, compiler warning fixes, whatever, may follow
      afterwards.
      98fb0ef7
  2. 13 Aug, 2011 5 commits
  3. 12 Aug, 2011 9 commits
  4. 11 Aug, 2011 3 commits
  5. 10 Aug, 2011 3 commits
  6. 09 Aug, 2011 7 commits
  7. 08 Aug, 2011 9 commits