- Mar 09, 2009
-
-
Daniel Stenberg authored
curl_easy_duphandle did not necessarily duplicate the CURLOPT_COOKIEFILE option. It only enabled the cookie engine in the destination handle if data->cookies is not NULL (where data is the source handle). In case of a newly initialized handle which just had the cookie support enabled by a curl_easy_setopt(handle, CURL_COOKIEFILE, "")-call, handle->cookies was still NULL because the setopt-call only appends the value to data->change.cookielist, hence duplicating this handle would not have the cookie engine switched on. We also concluded that the slist-functionality would be suitable for being put in its own module rather than simply hanging out in lib/sendf.c so I created lib/slist.[ch] for them.
-
Daniel Stenberg authored
scripts to make it detect a bad checkout earlier. People with older checkouts who don't do cvs update with the -d option won't get the new dirs and then will get funny outputs that can be a bit hard to understand and fix.
-
- Mar 08, 2009
-
-
Daniel Stenberg authored
allocation of the memory BIO was not being properly checked.
-
Daniel Stenberg authored
in the gnutls code where we were checking for negative values for errors, when the man pages state that GNUTLS_E_SUCCESS is returned on success and other values indicate error conditions.
-
http://curl.haxx.se/bug/view.cgi?id=2671602Daniel Stenberg authored
curl didn't use sprintf() in a way that is documented to work in POSIX but since we use our own printf() code (from libcurl) that shouldn't be a problem. Nonetheless I modified the code to not rely on such particular features and to not cause further raised eyebrowse with no good reason.
-
- Mar 05, 2009
-
-
Dan Fandrich authored
more issues for authors to consider when writing robust libcurl-using applications.
-
Yang Tse authored
-
- Mar 04, 2009
-
-
Dan Fandrich authored
by Daniel Johnson.
-
- Mar 03, 2009
-
-
Daniel Stenberg authored
whenever you attempt to open a new connection.
-
- Mar 02, 2009
-
-
Daniel Stenberg authored
(http://curl.haxx.se/docs/adv_20090303.html also known as CVE-2009-0037) in which previous libcurl versions (by design) can be tricked to access an arbitrary local/different file instead of a remote one when CURLOPT_FOLLOWLOCATION is enabled. This flaw is now fixed in this release together this the addition of two new setopt options for controlling this new behavior: o CURLOPT_REDIR_PROTOCOLS controls what protocols libcurl is allowed to follow to when CURLOPT_FOLLOWLOCATION is enabled. By default, this option excludes the FILE and SCP protocols and thus you nee to explicitly allow them in your app if you really want that behavior. o CURLOPT_PROTOCOLS controls what protocol(s) libcurl is allowed to fetch using the primary URL option. This is useful if you want to allow a user or other outsiders control what URL to pass to libcurl and yet not allow all protocols libcurl may have been built to support.
-
- Feb 27, 2009
-
-
Daniel Stenberg authored
CURLOPT_LOCALPORT were used together (the local port bind failed), and Markus Koetter provided the fix!
-
- Feb 25, 2009
-
-
Daniel Stenberg authored
curl_global_init() function to properly maintain the performing functions thread-safe. We've previously (28 April 2007) moved the init to a later time just to avoid it to fail very early when libgcrypt dislikes the situation, but that move was bad and the fix should rather be in libgcrypt or elsewhere.
-
- Feb 24, 2009
-
-
Daniel Stenberg authored
It happened because the code used the struct for server-based auth all the time for both proxy and server auth which of course was wrong.
-
- Feb 23, 2009
-
-
Daniel Stenberg authored
CURLINFO_CONTENT_LENGTH_DOWNLOAD and CURLINFO_CONTENT_LENGTH_UPLOAD return -1 if the sizes aren't know. Previously these returned 0, make it impossible to detect the difference between actually zero and unknown.
-
Yang Tse authored
to build a Mac OS X fat ppc/i386 or ppc64/x86_64 libcurl.framework
-
Daniel Stenberg authored
to the proper 'libcurl' as clearly this caused confusion.
-
- Feb 20, 2009
-
-
Yang Tse authored
-
Daniel Stenberg authored
FTP with the multi interface: when a transfer fails, like when aborted by a write callback, the control connection was wrongly closed and thus not re-used properly. This change is also an attempt to cleanup the code somewhat in this area, as now the FTP code attempts to keep (better) track on pending responses necessary to get read in ftp_done().
-
- Feb 19, 2009
-
-
Daniel Stenberg authored
libcurl did a superfluous 1000ms wait when doing SFTP downloads! We read data with libssh2 while doing the "DO" operation for SFTP and then when we were about to start getting data for the actual file part, the "TRANSFER" part, we waited for socket action (in 1000ms) before doing a libssh2-read. But in this case libssh2 had already read and buffered the data so we ended up always just waiting 1000ms before we get working on the data!
-
- Feb 18, 2009
-
-
Patrick Monnerat authored
FTP downloads (i.e.: RETR) ending with code 550 now return error CURLE_REMOTE_FILE_NOT_FOUND instead of CURLE_FTP_COULDNT_RETR_FILE.
-
- Feb 17, 2009
-
-
Daniel Stenberg authored
-
Daniel Stenberg authored
leak like that fixed on the 14th. When zlib returns failure, we need to cleanup properly before returning error.
-
Daniel Stenberg authored
plain FTP connections, and it will then allow MKD to fail once and retry the CWD afterwards. This is especially useful if you're doing many simultanoes connections against the same server and they all have this option enabled, as then CWD may first fail but then another connection does MKD before this connection and thus MKD fails but trying CWD works! The numbers can (should?) now be set with the convenience enums now called CURLFTP_CREATE_DIR and CURLFTP_CREATE_DIR_RETRY. Tests has proven that if you're making an application that uploads a set of files to an ftp server, you will get a noticable gain in speed if you're using multiple connections and this option will be then be very useful.
-
- Feb 14, 2009
-
-
Daniel Stenberg authored
code, which could happen on libz errors.
-
- Feb 12, 2009
-
-
Dan Fandrich authored
-
Daniel Stenberg authored
-
- Feb 11, 2009
-
-
Daniel Stenberg authored
the condition in the previous request was unmet. This is typically a time condition set with CURLOPT_TIMECONDITION and was previously not possible to reliably figure out. From bug report #2565128 (http://curl.haxx.se/bug/view.cgi?id=2565128)
-
- Feb 05, 2009
-
-
Dan Fandrich authored
This couldn't ever overflow in curl, but might if the code were used elsewhere or under different conditions.
-
- Feb 04, 2009
-
-
Dan Fandrich authored
(respectively) when --with-ssl=/usr is used (patch based on FreeBSD).
-
- Feb 03, 2009
-
-
Daniel Stenberg authored
CURLINFO_CONTENT_LENGTH_DOWNLOAD size from file:// "transfers" with CURLOPT_NOBODY set true.
-
- Feb 02, 2009
-
-
Daniel Stenberg authored
interface and setting CURLMOPT_MAXCONNECTS to something less than the number of handles you add to the multi handle. All the connections that didn't fit in the cache would not be properly disconnected nor freed!
-
Daniel Stenberg authored
version 1.1 instead of 1.0 like before. This change also introduces the new proxy type for libcurl called 'CURLPROXY_HTTP_1_0' that then allows apps to switch (back) to CONNECT 1.0 requests. The curl tool also got a --proxy1.0 option that works exactly like --proxy but sets CURLPROXY_HTTP_1_0. I updated all test cases cases that use CONNECT and I tried to do some using --proxy1.0 and some updated to do CONNECT 1.1 to get both versions run.
-
- Jan 31, 2009
-
-
Daniel Stenberg authored
enabled, we can now take advantage of its brand new AF_UNSPEC support in ares_gethostbyname(). This makes test case 241 finally run fine for me wtih this setup since it now parses the "::1 ip6-localhost" line fine in my /etc/hosts file!
-
Daniel Stenberg authored
(http://curl.haxx.se/bug/view.cgi?id=2550061) mentioning that I failed to properly make sure that the VC9 makefiles got included in the latest release. I've now fixed the release script and verified it so next release will hopefully include them properly!
-
- Jan 30, 2009
-
-
Dan Fandrich authored
the problem.
-
- Jan 29, 2009
-
-
Yang Tse authored
Curl_sspi_global_init() and Curl_sspi_global_cleanup() which previously were named Curl_ntlm_global_init() and Curl_ntlm_global_cleanup() in http_ntlm.c Also adjusted socks_sspi.c to remove the link-time dependency on the Windows SSPI library using it now in the same way as it was done in http_ntlm.c.
-
- Jan 28, 2009
-
-
Daniel Stenberg authored
CURLOPT_SOCKS5_GSSAPI_SERVICE and CURLOPT_SOCKS5_GSSAPI_NEC to allow libcurl to do GSS-style authentication with SOCKS5 proxies. The curl tool got the options called --socks5-gssapi-service and --socks5-gssapi-nec to enable these.
-
- Jan 26, 2009
-
-
Daniel Stenberg authored
to set desired block size to use for TFTP transfers instead of the default 512 bytes.
-
Daniel Stenberg authored
disable "rfc4507bis session ticket support". rfc4507bis was later turned into the proper RFC5077 it seems: http://tools.ietf.org/html/rfc5077 The enabled extension concerns the session management. I wonder how often libcurl stops a connection and then resumes a TLS session. also, sending the session data is some overhead. .I suggest that you just use your proposed patch (which explicitly disables TICKET). If someone writes an application with libcurl and openssl who wants to enable the feature, one can do this in the SSL callback. Sharad Gupta brought this to my attention. Peter Sylvester helped me decide on the proper action.
-
Daniel Stenberg authored
(http://curl.haxx.se/bug/view.cgi?id=2535504) pointing out that realms with quoted quotation marks in HTTP Digest headers didn't work. I've now added test case 1095 that verifies my fix.
-