1. 27 Nov, 2017 1 commit
    • Jay Satiro's avatar
      url: fix alignment of ssl_backend_data struct · 9b5e12a5
      Jay Satiro authored
      - Align the array of ssl_backend_data on a max 32 byte boundary.
      
      8 is likely to be ok but I went with 32 for posterity should one of
      the ssl_backend_data structs change to contain a larger sized variable
      in the future.
      
      Prior to this change (since dev 70f1db32, release 7.56) the connectdata
      structure was undersized by 4 bytes in 32-bit builds with ssl enabled
      because long long * was mistakenly used for alignment instead of
      long long, with the intention being an 8 byte boundary. Also long long
      may not be an available type.
      
      The undersized connectdata could lead to oob read/write past the end in
      what was expected to be the last 4 bytes of the connection's secondary
      socket https proxy ssl_backend_data struct (the secondary socket in a
      connection is used by ftp, others?).
      
      Closes https://github.com/curl/curl/issues/2093
      
      CVE-2017-8818
      
      Bug: https://curl.haxx.se/docs/adv_2017-af0a.html
      9b5e12a5
  2. 25 Nov, 2017 1 commit
    • Daniel Stenberg's avatar
      ssh: remove check for a NULL pointer (!) · c79b2ca0
      Daniel Stenberg authored
      With this check present, scan-build warns that we might dereference this
      point in other places where it isn't first checked for NULL. Thus, if it
      *can* be NULL we have a problem on a few places. However, this pointer
      should not be possible to be NULL here so I remove the check and thus
      also three different scan-build warnings.
      
      Closes #2111
      c79b2ca0
  3. 24 Nov, 2017 6 commits
  4. 23 Nov, 2017 3 commits
  5. 22 Nov, 2017 2 commits
  6. 21 Nov, 2017 7 commits
  7. 20 Nov, 2017 1 commit
  8. 18 Nov, 2017 1 commit
  9. 17 Nov, 2017 1 commit
  10. 15 Nov, 2017 2 commits
  11. 14 Nov, 2017 4 commits
  12. 13 Nov, 2017 2 commits
  13. 12 Nov, 2017 1 commit
  14. 11 Nov, 2017 1 commit
  15. 10 Nov, 2017 4 commits
  16. 09 Nov, 2017 3 commits