- Dec 16, 2014
-
-
Patrick Monnerat authored
There was a confusion between these: this commit tries to disambiguate them. - Scope can be computed from the address itself. - Scope id is scope dependent: it is currently defined as 1-based local interface index for link-local scoped addresses, and as a site index(?) for (obsolete) site-local addresses. Linux only supports it for link-local addresses. The URL parser properly parses a scope id as an interface index, but stores it in a field named "scope": confusion. The field has been renamed into "scope_id". Curl_if2ip() used the scope id as it was a scope. This caused failures to bind to an interface. Scope is now computed from the addresses and Curl_if2ip() matches them. If redundantly specified in the URL, scope id is check for mismatch with the interface index. This commit should fix SF bug #1451.
-
Patrick Monnerat authored
-
Daniel Stenberg authored
Bug: http://curl.haxx.se/mail/lib-2014-12/0103.html Pathed-by: Marc Renault
-
Daniel Stenberg authored
As the former contruct apparently caused a compiler warning, mentioned in d8efde07.
-
Daniel Stenberg authored
-
Daniel Stenberg authored
There was a mix of GlobCode, CURLcode and ints and they were mostly passing around CURLcode errors. This change makes the functions use only CURLcode and removes the GlobCode type completely.
-
- Dec 15, 2014
-
-
Daniel Stenberg authored
The loop in glob_next_url() needs to be done backwards to maintain the logic. dc197894 caused test 1235 to fail.
-
Daniel Stenberg authored
-
Jay Satiro authored
Change CURLOPT_TIMEOUT doc to warn that if CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS are both set whichever one is set last is the one that will be used. Prior to this change that behavior was only noted in the CURLOPT_TIMEOUT_MS doc.
-
Nick Zitzmann authored
Commit b13923f0 changed an snprintf() to use aprintf(), but the API usage wasn't correct, and was causing a crash to occur. This fixes it.
-
- Dec 14, 2014
-
-
Steve Holme authored
-
Daniel Stenberg authored
By counting from 0 and up instead of backwards like before, we remove the need for the "funny" check of the unsigned variable when decreased passed zero. Easier to read and less risk for compiler warnings.
-
Marc Hoersken authored
-
Marc Hoersken authored
The >= 0 is actually not required, since i underflows and the for-loop is stopped using the < condition, but this makes the VS2012 compiler and code analysis happy.
-
Marc Hoersken authored
Fixes code analysis warning C6031: return value ignored: <function> could return unexpected value
-
Marc Hoersken authored
warning C28252: Inconsistent annotation for function: parameter has another annotation on this instance
-
Steve Holme authored
smb.c:320: warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Result may not be an expected value
-
Marc Hoersken authored
-
Steve Holme authored
Rather than testing against _WIN32 use the preferred HAVE_PROCESS_H pre-processor define when including process.h.
-
Daniel Stenberg authored
... to avoid using a fixed memory size that risks being too large or too small.
-
Marc Hoersken authored
- do not grow memory by doubling its size - do not leak previously allocated memory if reallocation fails - replace while-loop with a single check to make sure that the requested amount of data fits into the buffer Bug: http://curl.haxx.se/bug/view.cgi?id=1450 Reported-by: Warren Menzer
-
Steve Holme authored
-
Marc Hoersken authored
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
There is no need to set the 'state' and 'result' member variables to SMB_REQUESTING (0) and CURLE_OK (0) after the allocation via calloc() as calloc() initialises the contents to zero.
-
Steve Holme authored
Use CURLE_BAD_CONTENT_ENCODING for bad type-2 Target Info security buffers just like we do for bad decodes.
-
Steve Holme authored
I don't think both of my fix ups from yesterday were needed to fix the compilation warning, so remove the one that I think is unnecessary and let the next Android autobuild prove/disprove it.
-
- Dec 13, 2014
-
-
Steve Holme authored
curl_ntlm_msgs.c:170: warning: conversion to 'short unsigned int' from 'int' may alter its value
-
Guenter Knauf authored
-
Steve Holme authored
-
Steve Holme authored
curl_ntlm_msgs.c:169: warning: conversion to 'short unsigned int' from 'int' may alter its value
-
Guenter Knauf authored
-
Guenter Knauf authored
worldtimeserver.com seems also no longer available.
-
Guenter Knauf authored
For getting the date header its not necessary to access special pages or even CGI scripts - all pages including the main index reply with the date header, therefore shortened URLs to domain. Removed worldtime.com; added pool.ntp.org.
-
Steve Holme authored
ftp.c:819: warning: unused parameter 'lineno'
-
Steve Holme authored
For debugging purposes, and as per other protocols within curl, added state change functions rather than changing the states directly.
-
Steve Holme authored
-
- Dec 12, 2014
-
-
Steve Holme authored
-
Steve Holme authored
smtp.c:2357 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string smtp.c:2375 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string smtp.c:2386 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string Used array index notation instead.
-