- 31 Mar, 2017 2 commits
-
-
Daniel Stenberg authored
telnet.c(1427,21): warning: comparison of constant 268435456 with expression of type 'CURLcode' is always false telnet.c(1433,21): warning: comparison of constant 268435457 with expression of type 'CURLcode' is always false Reviewed-by: Jay Satiro Reported-by: Gisle Vanem Bug: https://github.com/curl/curl/issues/1225#issuecomment-290340890 Closes #1374
-
Daniel Stenberg authored
-
- 30 Mar, 2017 13 commits
-
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
Peter Wu authored
For some reason, CMake 2.8.12.2 did not expand the list argument in a single DEPENDS argument. Remove the quotes, so it gets expanded into multiple arguments for add_custom_command and add_custom_target. Fixes https://github.com/curl/curl/issues/1370 Closes #1372
-
Marcel Raad authored
'left' is used as time_t but declared as long. MinGW complains: error: conversion to 'long int' from 'time_t {aka long long int}' may alter its value [-Werror=conversion] Changed the declaration to time_t.
-
Marcel Raad authored
In release mode, MinGW complains: error: unused parameter 'lib_error_code' [-Werror=unused-parameter]
-
Hanno Böck authored
The function tool_debug_cb doesn't match curl_debug_callback in curl.h (unsigned vs. signed char* for 3rd param). Bug: https://curl.haxx.se/mail/lib-2017-03/0120.html
-
Alexis La Goutte authored
Closes #1371
-
Marcel Raad authored
If CURL_DISABLE_VERBOSE_STRINGS is defined, hostname is not used in schannel_connect_step3.
-
Marcel Raad authored
When CURL_DISABLE_VERBOSE_STRINGS is defined, the reason parameter in Curl_conncontrol is not used as the infof macro expands to nothing.
-
Marcel Raad authored
At least under Windows, there is no SIZEOF_LONG, so it evaluates to 0 even though sizeof(int) == sizeof(long). This should probably have been CURL_SIZEOF_LONG, but the type of timeout_ms changed from long to time_t anyway. This triggered MSVC warning C4668 about implicitly replacing undefined macros with '0'. Closes https://github.com/curl/curl/pull/1362
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
- 29 Mar, 2017 6 commits
-
-
Daniel Stenberg authored
-
Marcel Raad authored
Feature defines are normally checked with #ifdef instead of #if in the rest of the codebase. Additionally, some compilers warn when a macro is implicitly evaluated to 0 because it is not defined, which was the case here. Ref: https://github.com/curl/curl/pull/1362#discussion_r108605101 Closes https://github.com/curl/curl/pull/1367
-
Hanno Böck authored
As you can see the callback definition uses a char* for the first argument, while the function uses a void*. URL: https://curl.haxx.se/mail/lib-2017-03/0116.html
-
Daniel Stenberg authored
-
madblobfish authored
Closes #1364
-
Maksim Stsepanenka authored
Closes #1366
-
- 28 Mar, 2017 6 commits
-
-
Daniel Stenberg authored
... to make it much faster. Idea developed with primepie on IRC. Closes #1365
-
Kamil Dudka authored
If we use FTPS over CONNECT, the TLS handshake for the FTPS control connection needs to be initiated in the SENDPROTOCONNECT state, not the WAITPROXYCONNECT state. Otherwise, if the TLS handshake completed without blocking, the information about the completed TLS handshake would be saved to a wrong flag. Consequently, the TLS handshake would be initiated in the SENDPROTOCONNECT state once again on the same connection, resulting in a failure of the TLS handshake. I was able to observe the failure with the NSS backend if curl ran through valgrind. Note that this commit partially reverts curl-7_21_6-52-ge34131db.
-
Daniel Stenberg authored
When receiving chunked encoded data with trailers, and the write callback returns PAUSE, there might be both body and header to store to resend on unpause. Previously libcurl returned error for that case. Added test case 1540 to verify. Reported-by: Stephen Toub Fixes #1354 Closes #1357
-
Isaac Boukris authored
When using basic-auth, connections and proxy connections can be re-used with different Authorization headers since it does not authenticate the connection (like NTLM does). For instance, the below command should re-use the proxy connection, but it currently doesn't: curl -v -U alice:a -x http://localhost:8181 http://localhost/ --next -U bob:b -x http://localhost:8181 http://localhost/ This is a regression since refactoring of ConnectionExists() as part of: cb4e2be7 Fix the above by removing the username and password compare when re-using proxy connection at proxy_info_matches(). However, this fix brings back another bug would make curl to re-print the old proxy-authorization header of previous proxy basic-auth connection because it wasn't cleared. For instance, in the below command the second request should fail if the proxy requires authentication, but would succeed after the above fix (and before aforementioned commit): curl -v -U alice:a -x http://localhost:8181 http://localhost/ --next -x http://localhost:8181 http://localhost/ Fix this by clearing conn->allocptr.proxyuserpwd after use unconditionally, same as we do for conn->allocptr.userpwd. Also fix test 540 to not expect digest auth header to be resent when connection is reused. Signed-off-by:
Isaac Boukris <iboukris@gmail.com> Closes https://github.com/curl/curl/pull/1350
-
Jay Satiro authored
- Fix compile errors that occur in openssl.c when OpenSSL lib was built without DSA support. Bug: https://github.com/curl/curl/issues/1361 Reported-by:
<neheb@users.noreply.github.com>
-
Jay Satiro authored
-
- 27 Mar, 2017 3 commits
-
-
Marcel Raad authored
No need to redeclare the variable.
-
Marcel Raad authored
error: conversion to 'long int' from 'time_t {aka long long int}' may alter its value [-Werror=conversion]
-
Marcel Raad authored
If Makefile.am uses CRLF, buildconf in a Windows checkout fails with: ".ibtoolize: error: AC_CONFIG_MACRO_DIRS([m4]) conflicts with ACLOCAL_AMFLAGS=-I m4"
-
- 26 Mar, 2017 1 commit
-
-
klemens authored
Closes #1356
-
- 25 Mar, 2017 1 commit
-
-
Daniel Stenberg authored
Reported-by: Brian Carpenter Added test 1442 to verify
-
- 24 Mar, 2017 1 commit
-
-
Marcel Raad authored
curl must be built before building the tests. Closes https://github.com/curl/curl/pull/1352
-
- 23 Mar, 2017 6 commits
-
-
Daniel Stenberg authored
-
Edward Kimmel authored
Send curl_socket_t to event_cb and make sure it hasn't been closed yet. Closes https://github.com/curl/curl/pull/1318
-
Dan Fandrich authored
-
Jay Satiro authored
- If SSL_get_error is called but no extended error detail is available then show that SSL_ERROR_* as a string. Prior to this change there was some inconsistency in that case: the SSL_ERROR_* code may or may not have been shown, or may have been shown as unknown even if it was known. Ref: https://github.com/curl/curl/issues/1300 Closes https://github.com/curl/curl/pull/1348
-
Dan Fandrich authored
This is nowadays included with the base perl distribution, but wasn't prior to about perl 5.14
-
Anders Roxell authored
Signed-off-by:
Anders Roxell <anders.roxell@gmail.com> Closes #1342
-
- 22 Mar, 2017 1 commit
-
-
Daniel Stenberg authored
-