- Apr 08, 2013
-
-
Fabian Keil authored
Previously it only compared credentials if the requested needle connection wasn't using a proxy. This caused NTLM authentication failures when using proxies as the authentication code wasn't send on the connection where the challenge arrived. Added test 1215 to verify: NTLM server authentication through a proxy (This is a modified copy of test 67)
-
- Apr 07, 2013
-
-
Marc Hoersken authored
-
Marc Hoersken authored
Since qsort implementations vary with regards to handling the order of similiar elements, this change makes the internal sort function more deterministic by comparing path length first, then domain length and finally the cookie name. Spotted with testcase 62 on Windows.
-
Marc Hoersken authored
-
- Apr 06, 2013
-
-
Marc Hoersken authored
-
Marc Hoersken authored
-
Marc Hoersken authored
-
Marc Hoersken authored
-
Daniel Stenberg authored
When doing PORT and upload (STOR), this function needs to extract the file descriptor for both connections so that it will respond immediately when the server eventually connects back. This flaw caused active connections to become unnecessary slow but they would still often work due to the normal polling on a timeout. The bug also would not occur if the server connected back very fast, like when testing on local networks. Bug: http://curl.haxx.se/bug/view.cgi?id=1183 Reported by: Daniel Theron
-
Kim Vandry authored
I am using curl_easy_setopt(CURLOPT_INTERFACE, "if!something") to force transfers to use a particular interface but the transfer fails with CURLE_INTERFACE_FAILED, "Failed binding local connection end" if the interface I specify has no IPv6 address. The cause is as follows: The remote hostname resolves successfully and has an IPv6 address and an IPv4 address. cURL attempts to connect to the IPv6 address first. bindlocal (in lib/connect.c) fails because Curl_if2ip cannot find an IPv6 address on the interface. This is a fatal error in singleipconnect() This change will make cURL try the next IP address in the list. Also included are two changes related to IPv6 address scope: - Filter the choice of address in Curl_if2ip to only consider addresses with the same scope ID as the connection address (mismatched scope for local and remote address does not result in a working connection). - bindlocal was ignoring the scope ID of addresses returned by Curl_if2ip . Now it uses them. Bug: http://curl.haxx.se/bug/view.cgi?id=1189
-
- Apr 05, 2013
-
-
Daniel Stenberg authored
At some point recently we lost the default value for the easy handle's connection cache, and this change puts it back to 5 - which is the former default value and it is documented in the curl_easy_setopt.3 man page.
-
- Apr 04, 2013
-
-
Yang Tse authored
-
Yang Tse authored
-
Linus Nielsen authored
Copy the CURLOPT_MAXCONNECTS option to CURLMOPT_MAXCONNECTS in curl_easy_perform(). Bug: http://curl.haxx.se/bug/view.cgi?id=1212 Reported-by: Steven Gu
-
Guenter Knauf authored
-
Guenter Knauf authored
-
- Apr 03, 2013
-
-
Yang Tse authored
-
Guenter Knauf authored
-
Guenter Knauf authored
-
Guenter Knauf authored
-
Guenter Knauf authored
Based on a patch posted to the list by Richard Michael.
-
- Apr 02, 2013
-
-
Yamada Yasuharu authored
Count up numcookies in Curl_cookie_add() only when cookie is new one
-
Daniel Stenberg authored
The Microsoft knowledge-base article http://support.microsoft.com/kb/823764 describes how to use SNDBUF to overcome a performance shortcoming in winsock, but it doesn't apply to Windows Vista and later versions. If the described SNDBUF magic is applied when running on those more recent Windows versions, it seems to instead have the reversed effect in many cases and thus make libcurl perform less good on those systems. This fix thus adds a run-time version-check that does the SNDBUF magic conditionally depending if it is deemed necessary or not. Bug: http://curl.haxx.se/bug/view.cgi?id=1188 Reported by: Andrew Kurushin Tested by: Christian Hägele
-
Nick Zitzmann authored
(This doesn't need to appear in the release notes.)
-
- Mar 31, 2013
-
-
Daniel Stenberg authored
-
Daniel Stenberg authored
Patch by: Robert Wruck Bug: http://curl.haxx.se/bug/view.cgi?id=1209
-
- Mar 29, 2013
-
-
Daniel Stenberg authored
The last remaining code piece that still used FTPSENDF now uses PPSENDF. In the problematic case, a PREQUOTE series was done on a re-used connection when Curl_pp_init() hadn't been called so it had messed up pointers. The init call is done properly from Curl_pp_sendf() so this change fixes this particular crash. Bug: http://curl.haxx.se/mail/lib-2013-03/0319.html Reported by: Sam Deane
-
- Mar 25, 2013
-
-
Yang Tse authored
-
Yang Tse authored
As of 25-mar-2013 wcsdup() _wcsdup() and _tcsdup() are only used in WIN32 specific code, so tracking of these has not been extended for other build targets. Without this fix, memory tracking system on WIN32 builds, when using these functions, would provide misleading results. In order to properly extend this support for all targets curl.h would have to define curl_wcsdup_callback prototype and consequently wchar_t should be visible before that in curl.h. IOW curl_wchar_t defined in curlbuild.h and this pulling whatever system header is required to get wchar_t definition. Additionally a new curl_global_init_mem() function that also receives user defined wcsdup() callback would be required.
-
Yang Tse authored
reverts unreleased invalid memory leak fix
-
- Mar 23, 2013
-
-
Martin Jansen authored
Proxy servers tend to add their own headers at the beginning of responses. The size of these headers was not taken into account by CURLINFO_HEADER_SIZE before this change. Bug: http://curl.haxx.se/bug/view.cgi?id=1204
-
- Mar 21, 2013
-
-
Steve Holme authored
Corrected some incorrectly positioned pointer variable declarations to be "char *" rather than "char* ".
-
Steve Holme authored
Corrected some incorrectly positioned pointer variable declarations to be "type *" rather than "type* ".
-
Steve Holme authored
warning: an enumerated type is mixed with another type
-
- Mar 20, 2013
-
-
Steve Holme authored
warning: conversion from enumeration type to different enumeration type
-
- Mar 19, 2013
-
-
Nick Zitzmann authored
I found out that ECC doesn't work as of OS X 10.8.3, so those ciphers are turned off until the next point release of OS X.
-
- Mar 18, 2013
-
-
Oliver Schindler authored
After having done a POST over a CONNECT request, the 'rewindaftersend' boolean could be holding the previous value which could lead to badness. This should be tested for in a new test case! Bug: https://groups.google.com/d/msg/msysgit/B31LNftR4BI/KhRTz0iuGmUJ
-
- Mar 17, 2013
-
-
Steve Holme authored
Fixed incorrect initial response generation for the NTLM and LOGIN SASL authentication mechanisms when the SASL-IR was detected. Introduced in commit: 6da7dc02.
-
- Mar 15, 2013
-
-
Daniel Stenberg authored
curl has been accepting URLs using slightly wrong syntax for a long time, such as when completely missing as slash "http://example.org" or missing a slash when a query part is given "http://example.org?q=foobar". curl would translate these into a legitimate HTTP request to servers, although as was shown in bug #1206 it was not adjusted properly in the cases where a HTTP proxy was used. Test 1213 and 1214 were added to the test suite to verify this fix. The test HTTP server was adjusted to allow us to specify test number in the host name only without using any slashes in a given URL. Bug: http://curl.haxx.se/bug/view.cgi?id=1206 Reported by: ScottJi
-
- Mar 14, 2013
-
-
Yang Tse authored
This commit alone does not fix anything nor modifies existing interfaces or behaviors, although it is a prerequisite for other fixes.
-