Commit 74467f8e authored by Nick Zitzmann's avatar Nick Zitzmann
Browse files

darwinssl: additional descriptive messages of SSL handshake errors 

(This doesn't need to appear in the release notes.)
parent cfb7e809

lib/curl_darwinssl.c

+13 −1
Original line number Diff line number Diff line
@@ -995,6 +995,10 @@ darwinssl_connect_step2(struct connectdata *conn, int sockindex) 
        failf(data, "SSL certificate problem: Certificate chain had an "

              "expired certificate");

        return CURLE_SSL_CACERT;

      case errSSLBadCert:

        failf(data, "SSL certificate problem: Couldn't understand the server "

              "certificate format");

        return CURLE_SSL_CONNECT_ERROR;



      /* This error is raised if the server's cert didn't match the server's

         host name: */
@@ -1010,10 +1014,18 @@ darwinssl_connect_step2(struct connectdata *conn, int sockindex) 
      case errSSLClosedAbort:

        failf(data, "Server aborted the SSL handshake");

        return CURLE_SSL_CONNECT_ERROR;

      case paramErr: /* if you're getting this, it could be a cipher problem */

      case errSSLNegotiation:

        failf(data, "Could not negotiate an SSL cipher suite with the server");

        return CURLE_SSL_CONNECT_ERROR;

      /* Sometimes paramErr happens with buggy ciphers: */

      case paramErr: case errSSLInternal:

        failf(data, "Internal SSL engine error encountered during the "

              "SSL handshake");

        return CURLE_SSL_CONNECT_ERROR;

      case errSSLFatalAlert:

        failf(data, "Fatal SSL engine error encountered during the SSL "

              "handshake");

        return CURLE_SSL_CONNECT_ERROR;

      default:

        failf(data, "Unknown SSL protocol error in connection to %s:%d",

              conn->host.name, err);