Skip to content
  1. Nov 14, 2016
  2. Nov 13, 2016
  3. Nov 11, 2016
  4. Nov 10, 2016
  5. Nov 09, 2016
  6. Nov 07, 2016
  7. Nov 04, 2016
  8. Nov 03, 2016
  9. Nov 02, 2016
  10. Nov 01, 2016
  11. Oct 28, 2016
  12. Oct 27, 2016
  13. Oct 26, 2016
    • Jim Jagielski's avatar
      Merge r1764040 from trunk: · 6d57c7e3
      Jim Jagielski authored
      mod_dav: Fix a potential cause of unbounded memory usage or incorrect
      behavior in a routine that sends <DAV:response>'s to the output filters.
      
      The dav_send_one_response() function accepts the current head of the output
      filter list as an argument, but the actual head can change between calls to
      ap_pass_brigade().  This can happen with self-removing filters, e.g., with
      the filter from mod_headers or mod_deflate.  Consequently, executing an
      already removed filter can either cause unwanted memory usage or incorrect
      behavior.
      
      This patch changes the signature of the existing mod_dav's public API,
      dav_send_one_response(), because this API is not yet a part of any 2.4.x
      release.
      
      * modules/dav/main/mod_dav.c
        (dav_send_one_response): Accept a request_rec instead of an ap_filter_t.
         Write the response to r->output_filters.
        (dav_send_multistatus, dav_stream_response): Update these calling sites
         of dav_send_one_response().
      
      * modules/dav/main/mod_dav.h
        (dav_send_one_response): Adjust definition.
      
      Submitted by: kotkov
      Reviewed/backported by: jim
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1766683 13f79535-47bb-0310-9956-ffa450edef68
      6d57c7e3