Revert this patch.  It indicates some fundamental brokenness with the
  apr_filepath_root() fn, which should simply return '/' for an absolute
  path on (most) unix, and advance the path pointer to the first non-'/'
  character  [if only Win32 and others were so simple ;-]


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90605 13f79535-47bb-0310-9956-ffa450edef68

work better right now.  httpd-test is much much happier with this patch
(ie, we can serve pages again :)  I'm still seeing issues with mod_include,
but that's probably a different problem... will investigate.

Submitted by:	Doug MacEachern


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90603 13f79535-47bb-0310-9956-ffa450edef68

  I'm still not 100% certain on this test.  Regardless, it doesn't impact
  Unix, and this was the bug that Jeff's (none the less correct) fix masked.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90601 13f79535-47bb-0310-9956-ffa450edef68

split_and_pass_pretag_buckets(): the retcode is not
specified on one of the paths


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90600 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90599 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90598 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90597 13f79535-47bb-0310-9956-ffa450edef68

ap_strchr_c instead of strchr (which == ap_strchr on my system).

Submitted by:	Ryan Bloom


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90595 13f79535-47bb-0310-9956-ffa450edef68

  Fix my typo (I invented the silly constant, you would expect me to recall it.)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90594 13f79535-47bb-0310-9956-ffa450edef68

  Increase security in core.c by testing (as we merge the path) that the
  URI does not go above the DocumentRoot (as defined by the OS, not by
  the URI specification), and give us the true name.

  When we are done, note the name is canonical for directory_walk.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90593 13f79535-47bb-0310-9956-ffa450edef68

  Whoops.  To explain, we won't dup filename unless it really didn't match
  in the first place.  We are about to abuse test_filename, so don't try
  using that copy.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90592 13f79535-47bb-0310-9956-ffa450edef68

  Start with the presumption that canonical_filename is not likely to be set.
  Therefore we will canonicalize it when it doesn't match filename.

  The next optimization should take the path common to canonical_filename
  and filename, and start merging filename from there for canonicalization.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90591 13f79535-47bb-0310-9956-ffa450edef68

  Another spot we are certain of the canonical_filename


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90590 13f79535-47bb-0310-9956-ffa450edef68

  We already extract e for subprocess_env, and set SECURE_SERVER_PORT
  for real.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90589 13f79535-47bb-0310-9956-ffa450edef68

  Why two ifdef blocks?  This is simpler to read


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90588 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90587 13f79535-47bb-0310-9956-ffa450edef68

  Two cases we are certain of canonical correctness


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90586 13f79535-47bb-0310-9956-ffa450edef68

  Add a canonical_filename value (should remain the r->filename identity)
  so we can tell if a 3rd party module broke the canonical form of the
  filename by not calling apr_filepath_merge().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90585 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90584 13f79535-47bb-0310-9956-ffa450edef68

  Better doc of ap_server_root_relative()


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90583 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90582 13f79535-47bb-0310-9956-ffa450edef68

a note about why it is commented out would be appropriate too


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90581 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90580 13f79535-47bb-0310-9956-ffa450edef68

change the module variable from tcache_module to cache_module

clear up various gcc warnings

don't segfault when the silly user (me) configures CACHE_OUT
manually


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90579 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90578 13f79535-47bb-0310-9956-ffa450edef68

  Add some appropriate constness to the config


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90577 13f79535-47bb-0310-9956-ffa450edef68

requested


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90576 13f79535-47bb-0310-9956-ffa450edef68

  Silly compiler, const char* is for text :)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90575 13f79535-47bb-0310-9956-ffa450edef68

  I _like_ malloca(), but it needs an include


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90574 13f79535-47bb-0310-9956-ffa450edef68

  Rather than continuing to canonicalize within directory_walk (very time
  consuming on all but *nix systems) we temporarily canonicalize to compare
  the results of the many merges, and fail on a mismatch.

  The apr_filepath_merge and ap_server_root_relative calls now merge the
  file _by canonicalizing it_.  That includes resolving all /../, /./,
  and // misnomers.

  A minor effort is required to figure out who all munges the r->filename
  in an inappropriate manner.

  The final (return to optimized state) probably involves setting an
  r->goodname argument to r->filename, every time we properly merge
  through ap_server_root_relative or apr_filepath_merge().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90573 13f79535-47bb-0310-9956-ffa450edef68

  Eliminated ap_os_[systemcase|[case_]canonical]_filename() and
  changes for ap_os_is_path_absolute (moved to util.c).


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90572 13f79535-47bb-0310-9956-ffa450edef68

  Overhauled ap_server_root_relative, so that it now changes any path
  to canonical form through apr.  Also assures that a change to the
  ServerRoot through a -C option takes effect before locating the
  httpd.conf file.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90571 13f79535-47bb-0310-9956-ffa450edef68

  Eliminated ap_os_[systemcase|[case_]canonical]_filename() and
  changes for ap_os_is_path_absolute


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90570 13f79535-47bb-0310-9956-ffa450edef68

  New ap_os_is_path_absolute() semantics


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90569 13f79535-47bb-0310-9956-ffa450edef68

The existing faq will be deleted soon.

Discussion to follow on docs list.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90568 13f79535-47bb-0310-9956-ffa450edef68

  Eliminated ap_os_[systemcase|[case_]canonical]_filename() and
  move ap_os_is_path_absolute() into util.c (now relies on apr.)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90567 13f79535-47bb-0310-9956-ffa450edef68

  Canonicalization will now occur on all sub_req_lookup_file() calls,
  and the ap_server_root_relative() will handle canonicalization as well.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90566 13f79535-47bb-0310-9956-ffa450edef68

  ap_server_root_relative will take care of this canonical_file call.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90565 13f79535-47bb-0310-9956-ffa450edef68

  Performance death notices.  Note that we shouldn't have EVER coded a
  module with a fixed path ... the config phase should take the proxy/
  path and ap_server_root_relative() it at startup.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90564 13f79535-47bb-0310-9956-ffa450edef68

  Optimize out what is a very expensive in-request call to
  ap_server_root_relative (and is becoming more expensive).
  Now the call happens in the config phase where it belongs.
  Note someone can hop in and transpose the stat and open
  with an open and getfileinfo if you are a performance hound.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90563 13f79535-47bb-0310-9956-ffa450edef68