- Nov 14, 2003
-
-
Richard Levitte authored
-
- Nov 13, 2003
-
-
Geoff Thorpe authored
generally a more efficient comparison than comparing two integers, and the first of these two loops was off-by-one (copying one too many values). This change also removes a superfluous assignment that would set an unused word to zero (and potentially allow an overrun in some cases). Submitted by: Nils Larsch Reviewed by: Geoff Thorpe
-
- Nov 10, 2003
-
-
Geoff Thorpe authored
(where it was impossible to create an EC certificate with a compressed public key), and has some style improvements based on some comments from Steve Henson about use of the ASN1 macros. Submitted by: Nils Larsch Reviewed by: Geoff Thorpe
-
Geoff Thorpe authored
Submitted by: Nils Larsch Reviewed by: Geoff Thorpe
-
Dr. Stephen Henson authored
-
- Nov 07, 2003
-
-
Ulf Möller authored
-
Ulf Möller authored
-
- Nov 06, 2003
-
-
Geoff Thorpe authored
bn_correct_top(), previously only bn_check_top() did this.
-
Geoff Thorpe authored
before.
-
Geoff Thorpe authored
-
- Nov 05, 2003
-
-
Geoff Thorpe authored
constant BIGNUMs. It turns out that this trips up different but equally useful compiler warnings to -Wcast-qual, and so wasn't worth the ugliness it created. (Thanks to Ulf for the forehead-slap.)
-
Ulf Möller authored
-
Ulf Möller authored
-
Ulf Möller authored
-
- Nov 04, 2003
-
-
Geoff Thorpe authored
is itself experimental, and in addition may cause execution to break on existing openssl "bugs" that previously were harmless or at least invisible.
-
Geoff Thorpe authored
Submitted by: Nils Larsch
-
Geoff Thorpe authored
and structures as constant without having to cast away const at any point. There is still plenty of other code that makes gcc's "-Wcast-qual" unhappy, but crypto/bn/ is now ok. Purists are welcome to suggest alternatives.
-
- Oct 31, 2003
-
-
Richard Levitte authored
rather than OPENSSLDIR.
-
Richard Levitte authored
-
Geoff Thorpe authored
constructing BIGNUM structures with pointers offset into other bignums (among other things). This corrects some of it that is too plainly insane, and tries to ensure that bignums are normalised when passed to other functions.
-
- Oct 30, 2003
-
-
Geoff Thorpe authored
left in an inconsistent state when they are released for later reuse. This change resets the BIGNUMs when they are released back to the context.
-
Geoff Thorpe authored
input to a function.
-
- Oct 29, 2003
-
-
Geoff Thorpe authored
-
Geoff Thorpe authored
-
Geoff Thorpe authored
Obtained from: Stephen Henson <steve@openssl.org>
-
Geoff Thorpe authored
callback structure just before it is needed.
-
Geoff Thorpe authored
requires -DPEDANTIC and was hidden at the bottom of the file. This moves it to the top and removes the redundant declaration.
-
Geoff Thorpe authored
Obtained from: Andy Polyakov <appro@openssl.org>
-
Geoff Thorpe authored
structures being passed in to or out of API functions, and this corrects a couple of cases found so far. Also, lop off a couple of bytes of white-space.
-
Geoff Thorpe authored
I have tried to convert 'len' type variable declarations to unsigned as a means to address these warnings when appropriate, but when in doubt I have used casts in the comparisons instead. The better solution (that would get us all lynched by API users) would be to go through and convert all the function prototypes and structure definitions to use unsigned variables except when signed is necessary. The proliferation of (signed) "int" for strictly non-negative uses is unfortunate.
-
Geoff Thorpe authored
except internally to the allocator BN_CTX_new(), as such this deprecates the use of BN_CTX_init() in the API. Moreover, the structure definition of BN_CTX is taken out of bn_lcl.h and moved into bn_ctx.c itself. NDEBUG should probably only be "forced" in the top-level configuration, but until it is I will avoid removing it from bn_ctx.c which might surprise people with massive slow-downs in their keygens. So I've left it in bn_ctx.c but tidied up the preprocessor logic a touch and made it more tolerant of debugging efforts.
-
Richard Levitte authored
be the same. Therefore, the removed memcpy()s need to be restored.
-
Geoff Thorpe authored
-
Geoff Thorpe authored
confusion. Also silence a couple of signed/unsigned warnings.
-
Geoff Thorpe authored
-
Geoff Thorpe authored
choice but to have to cast away "const" qualifiers from their prototypes. This does not remove constification restrictions from hash/compare callbacks, but allows destructor commands to be run over a tables' elements without bad casts.
-
Geoff Thorpe authored
-
Geoff Thorpe authored
-
Geoff Thorpe authored
linux system (namely mine) chokes on our definitions and uses of the "HZ" symbol in crypto/tmdiff.[ch] and apps/speed.c as a "bad function cast" (when in fact there is no function casting involved at all). In both cases, it is easily worked around by not defining a cast into the macro and jiggling the expressions slightly. In addition - this highlights some cruft in openssl that needs sorting out. The tmdiff.h header is exported as part of the openssl API despite the fact that it is ugly as the driven sludge and not used anywhere in the library, applications, or utilities. More weird still, almost identical code exists in apps/speed.c though it looks to be slightly tweaked - so either tmdiff should be updated and used by speed.c, or it should be dumped because it's obviously not useful enough. Rather than removing it for now, I've changed the API for tmdiff to at least make sense. This involves taking the object type (MS_TM) from the implementation and using it in the header rather than using "char *" in the API and casting mercilessly in the code (ugh). If someone doesn't like "MS_TM" and the "ms_time_***" naming, by all means change it. This should be a harmless improvement, because the existing API is clearly not very useful (eg. we reimplement it rather than using it in our own utils). However, someone still needs to take a hack at consolidating speed.c and tmdiff.[ch] somehow.
-
Geoff Thorpe authored
and links with OPENSSL_NO_DEPRECATED defined.
-