- 27 May, 2016 10 commits
-
-
Matt Caswell authored
When closing down the socket in s_client Windows will close it immediately even if there is data in the write buffer still waiting to be sent. This was causing tests to fail in Msys/Mingw builds because TLSProxy doesn't see the final CloseNotify. I have experimented with various ways of doing this "properly" (e.g. shutting down the socket before closing, setting SO_LINGER etc). I can't seem to find the "magic" formula that will make Windows do this. Inserting a short 50ms sleep seems to do the trick...but its not very "nice" so I've inserted a TODO on this item. Perhaps someone else will have better luck in figuring this out. RT#4255 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
On Windows we were using the function _kbhit() to determine whether there was input waiting in stdin for us to read. Actually all this does is work out whether there is a keyboard press event waiting to be processed in the input buffer. This only seems to work in a standard Windows console (not Msys console) and also doesn't work if you redirect the input from some other source (as we do in TLSProxy tests). This commit changes things to work differently depending on whether we are on the Windows console or not. RT#4255 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
In s_server we call BIO_sock_should_retry() to determine the state of the socket and work out whether we should retry an operation on it or not. However if you leave it too long to call this then other operations may have occurred in the meantime which affect the result. Therefore we should call it early and remember the result for when we need to use it. This fixes a test problem on Windows. Another issue with s_server on Windows is that some of output to stdout does not get displayed immediately. Apparently more liberal use of BIO_flush is required. RT#4255 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
Clang was complaining about some variables possibly being uninitialized when used. The warnings are bogus, but clang can't figure that out. This silences the warnings. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
Previous commits fixed the implementation of the %e and %g format specifiers as well as other issues. This commit adds a test. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
We convert the integer part of the float to a long. We should check it fits first. Issue reported by Guido Vranken. GitHub Issue #1102 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
The previous commit which "fixed" the "e" and "g" floating point formats just printed them in the same way as "f". This is wrong. This commit provides the correct formatting. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
Convert assert to OPENSSL_assert(), add some documentation, add the calls to fmtfp() for the "e" and "g" floating point formats which were missing. Based on a patch provided by Ger Hobbelt <ger@hobbelt.com>. RT#2270 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
huangqinjin authored
Reviewed-by:
Kurt Roeckx <kurt@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
huangqinjin authored
Reviewed-by:
Kurt Roeckx <kurt@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
- 26 May, 2016 3 commits
-
-
Matt Caswell authored
Windows was complaining about a unary minus operator being applied to an unsigned type. It did seem to go on and do the right thing anyway, but the code does look a little suspect. This fixes it. Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
Matt Caswell authored
The ssl3_digest_cached_records() function was failing to handle errors that might be returned from EVP_DigestSignInit() and EVP_DigestSignUpdate(). RT#4180 Reviewed-by:
Stephen Henson <steve@openssl.org>
-
Dr. Stephen Henson authored
RT#2369 Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 25 May, 2016 8 commits
-
-
Richard Levitte authored
Visual C version from version 2003 complain about certain function names, for example: apps\apps.c(2572) : warning C4996: 'open': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _open. See online help for details. This adds preprocessor aliases for them in e_os.h. Additionally, crypto/conf/conf_lib.c needs to include e_os.h to catch those aliases. RT#4488 RT#4489 Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Andy Polyakov authored
At earlier point 'which' was replaced with IPC::Cmd::can_run call. Unfortunately on RPM-based systems it is a separate package and it's not given that it's installed. Resurrected 'which' provides poor-man fallback for IPC::Cmd::can_run. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
Configurations/50-haiku.conf reuses gnu-shared rules and doesn't require dedicated targets. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Kurt Roeckx authored
Found by tis-interpreter Reviewed-by:
Rich Salz <rsalz@openssl.org> GH: #1122
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
As it was until now, crypto-mdebug-backtrace was enabled by default and only disabled if crypto-mdebug was disabled. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
RT#4492 Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Richard Levitte authored
For parsing build.info files. RT#4492 Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
- 24 May, 2016 6 commits
-
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Add Configure generated header files to $unified_info{generate}. This makes sure the build files will pick them up with the rest for the GENERATED macro, and thereby make sure they get cleaned away by 'make clean' Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Kurt Roeckx authored
Found by tis-interpreter Reviewed-by:
Richard Levitte <levitte@openssl.org> GH: #1115
-
Rich Salz authored
Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Todd Short authored
This compiles correctly, but depending on what may be defined, it's possible that this could fail compilation. The braces are mismatched, and it's possible to end up with an else followed by another else. This presumes the indentation is mostly correct and indicative of intent. Found via static analysis. Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1118)
-
Todd Short authored
When RAND_pseudo_bytes() was replaced with RAND_bytes(), this case was not reduced to a simple RAND_bytes() call. Reviewed-by:
Matt Caswell <matt@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1117)
-
- 23 May, 2016 13 commits
-
-
Matt Caswell authored
If lh_OBJ_NAME_insert() fails then the allocated |onp| value is leaked. RT#2238 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
The functions SRP_Calc_client_key() and SRP_Calc_server_key() were incorrectly returning a valid pointer in the event of error. Issue reported by Yuan Jochen Kang Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
The OPENSSL_INIT_set_config_filename() function can fail so ensure that it provides a suitable error code. GitHub Issue #920 Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Matt Caswell authored
The function strerror() is not thread safe. We should use strerror_r() where possible, or strerror_s() on Windows. RT#2267 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
J Mohan Rao Arisankala authored
ossl_hmac_cleanup, pkey_hmac_cleanup: - allow to invoke with NULL data - using EVP_PKEY_CTX_[get|set]_data EVP_DigestInit_ex: - remove additional check for ‘type’ and doing clear free instead of free Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Especially on Windows, the .pl suffix is associated with the perl interpreter, and therefore make those scripts usable as commands of their own. On VMS, it simply looks better. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Todd Short authored
The buf-freelists option was removed in master. There may be some things that try to disable it, so don't error out. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Rich Salz authored
Add script to find unused err/reason codes Remove unused reason codes. Remove entries for unused functions Reviewed-by:
Matt Caswell <matt@openssl.org>
-