Skip to content
  1. May 23, 2016
  2. May 22, 2016
  3. May 21, 2016
  4. May 20, 2016
    • Matt Caswell's avatar
      Fix Windows 64 bit crashes · fcb318c6
      Matt Caswell authored
      The function InitOnceExceuteOnce is the best way to support the
      implementation of CRYPTO_THREAD_run_once() on Windows. Unfortunately
      WinXP doesn't have it. To get around that we had two different
      implementations: one for WinXP and one for later versions. Which one was
      used was based on the value of _WIN32_WINNT.
      
      This approach was starting to cause problems though because other parts of
      OpenSSL assume _WIN32_WINNT is going to be 0x0501 and crashes were
      occurring dependant on include file ordering. In addition a conditional
      based on _WIN32_WINNT had made its way into a public header file through
      commit 5c4328f0
      
      . This is problematic because the value of this macro can
      vary between OpenSSL build time and application build time.
      
      The simplest solution to this mess is just to always use the WinXP version
      of CRYPTO_THREAD_run_once(). Its perhaps slightly sub-optimal but probably
      not noticably.
      
      GitHub Issue #1086
      
      Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
      fcb318c6
    • Rich Salz's avatar
      Rename lh_xxx,sk_xxx tp OPENSSL_{LH,SK}_xxx · 739a1eb1
      Rich Salz authored
      
      
      Rename sk_xxx to OPENSSL_sk_xxx and _STACK to OPENSSL_STACK
      Rename lh_xxx API to OPENSSL_LH_xxx and LHASH_NODE to OPENSSL_LH_NODE
      Make lhash stuff opaque.
      Use typedefs for function pointers; makes the code simpler.
      Remove CHECKED_xxx macros.
      Add documentation; remove old X509-oriented doc.
      Add API-compat names for entire old API
      
      Reviewed-by: default avatarDr. Stephen Henson <steve@openssl.org>
      739a1eb1
    • Richard Levitte's avatar
    • Richard Levitte's avatar
      VMS: setbuf() only takes 32-bit pointers · 8ff889c2
      Richard Levitte authored
      
      
      Giving setbuf() a 64-bit pointer isn't faulty, as the argument is
      passed by a 64-bit register anyway, so you only get a warning
      (MAYLOSEDATA2) pointing out that only the least significant 32 bits
      will be used.
      
      However, we know that a FILE* returned by fopen() and such really is a
      32-bit pointer (a study of the system header files make that clear),
      so we temporarly turn off that warning when calling setbuf().
      
      Reviewed-by: default avatarAndy Polyakov <appro@openssl.org>
      8ff889c2