- 25 Feb, 2016 1 commit
-
-
Emilia Kasper authored
The SRP user database lookup method SRP_VBASE_get_by_user had confusing memory management semantics; the returned pointer was sometimes newly allocated, and sometimes owned by the callee. The calling code has no way of distinguishing these two cases. Specifically, SRP servers that configure a secret seed to hide valid login information are vulnerable to a memory leak: an attacker connecting with an invalid username can cause a memory leak of around 300 bytes per connection. Servers that do not configure SRP, or configure SRP but do not configure a seed are not vulnerable. In Apache, the seed directive is known as SSLSRPUnknownUserSeed. To mitigate the memory leak, the seed handling in SRP_VBASE_get_by_user is now disabled even if the user has configured a seed. Applications are advised to migrate to SRP_VBASE_get1_by_user. However, note that OpenSSL makes no strong guarantees about the indistinguishability of valid and invalid logins. In particular, computations are currently not carried out in constant time. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 22 Feb, 2016 3 commits
-
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
We were kinda sorta using a mix of $disabled{"static-engine" and $disabled{"dynamic-engine"} in Configure. Let's avoid confusion, choose one of them and stick to it. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 20 Feb, 2016 1 commit
-
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 17 Feb, 2016 1 commit
-
-
Rich Salz authored
Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 12 Feb, 2016 1 commit
-
-
Richard Levitte authored
INSTALL_PREFIX is a confusing name, as there's also --prefix. Instead, tag along with the rest of the open source world and adopt the Makefile variable DESTDIR to designate the desired staging directory. The Configure option --install_prefix is removed, the only way to designate a staging directory is with the Makefile variable (this is also implemented for VMS' descrip.mms et al). Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 11 Feb, 2016 2 commits
-
-
Rich Salz authored
To enable heartbeats for DTLS, configure with enable-heartbeats. Heartbeats for TLS have been completely removed. This addresses RT 3647 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Rich Salz authored
Add utility macros REF_ASSERT_NOT and REF_PRINT_COUNT This is also RT 4181 Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
- 10 Feb, 2016 2 commits
-
-
Matt Caswell authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 09 Feb, 2016 1 commit
-
-
Matt Caswell authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
- 05 Feb, 2016 2 commits
-
-
FdaSilvaYY authored
Signed-off-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Matt Caswell authored
The DTLSv1_listen function exposed details of the underlying BIO abstraction and did not properly allow for IPv6. This commit changes the "peer" argument to be a BIO_ADDR and makes it a first class function (rather than a ctrl) to ensure proper type checking. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
- 03 Feb, 2016 3 commits
-
-
Richard Levitte authored
Reviewed-by:
Kurt Roeckx <kurt@openssl.org>
-
Emilia Kasper authored
Accept leading 0-byte in PKCS1 type 1 padding. Internally, the byte is stripped by BN_bn2bin but external callers may have other expectations. Reviewed-by:
Kurt <Roeckx<kurt@openssl.org>
-
Emilia Kasper authored
CRIME protection: disable compression by default, even if OpenSSL is compiled with zlib enabled. Applications can still enable compression by calling SSL_CTX_clear_options(ctx, SSL_OP_NO_COMPRESSION), or by using the SSL_CONF library to configure compression. SSL_CONF continues to work as before: SSL_CONF_cmd(ctx, "Options", "Compression") enables compression. SSL_CONF_cmd(ctx, "Options", "-Compression") disables compression (now no-op by default). The command-line switch has changed from -no_comp to -comp. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 01 Feb, 2016 1 commit
-
-
Emilia Kasper authored
PACKET contents should be read-only. To achieve this, also - constify two user callbacks - constify BUF_reverse. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 30 Jan, 2016 1 commit
-
-
Rich Salz authored
There was an unused macro in ssl_locl.h that used an internal type, so I removed it. Move bio_st from bio.h to ossl_type.h Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
- 29 Jan, 2016 1 commit
-
-
Emilia Kasper authored
The use of the uninitialized buffer in the RNG has no real security benefits and is only a nuisance when using memory sanitizers. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 28 Jan, 2016 2 commits
-
-
Matt Caswell authored
Add details about the latest issues fixed in the forthcoming release. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Rich Salz authored
Many options for supporting optimizations for legacy crypto on legacy platforms have been removed. This simplifies the source code and does not really penalize anyone. DES_PTR (always on) DES_RISC1, DES_RISC2 (always off) DES_INT (always 'unsigned int') DES_UNROLL (always on) BF_PTR (always on) BF_PTR2 (removed) MD2_CHAR, MD2_LONG (always 'unsigned char') IDEA_SHORT, IDEA_LONG (always 'unsigned int') RC2_SHORT, RC2_LONG (always 'unsigned int') RC4_LONG (only int and char (for assembler) are supported) RC4_CHUNK (always long), RC_CHUNK_LL (removed) RC4_INDEX (always on) And also make D_ENCRYPT macro more clear (@appro) This is done in consultation with Andy. Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
- 25 Jan, 2016 1 commit
-
-
Richard Levitte authored
Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 21 Jan, 2016 1 commit
-
-
Richard Levitte authored
--prefix is now exclusively used for software and manual installation. --openssldir is not exclusively used as a default location for certs, keys and the default openssl.cnf. This change is made to bring clarity, to have the two less intertwined, and to be more compatible with the usual ways of software installation. Please change your habits and scripts to use --prefix rather than --openssldir for installation location now. Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 19 Jan, 2016 1 commit
-
-
Matt Caswell authored
The GOST engine is now out of date and is removed by this commit. An up to date GOST engine is now being maintained in an external repository. See: https://wiki.openssl.org/index.php/Binaries Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
- 15 Jan, 2016 1 commit
-
-
Rich Salz authored
Reviewed-by:
Matt Caswell <matt@openssl.org>
-
- 14 Jan, 2016 1 commit
-
-
Benjamin Kaduk authored
The entropy-gathering daemon is used only on a small number of machines. Provide a configure knob so that EGD support can be disabled by default but re-enabled on those systems that do need it. Reviewed-by:
Dr. Stephen Henson <steve@openssl.org>
-
- 12 Jan, 2016 3 commits
-
-
Rich Salz authored
Create Makefile's from Makefile.in Rename Makefile.org to Makefile.in Rename Makefiles to Makefile.in Address review feedback from Viktor and Richard Reviewed-by:
Viktor Dukhovni <viktor@openssl.org> Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Stephen Henson <steve@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 11 Jan, 2016 1 commit
-
-
Rich Salz authored
Fix the docs, and refactor some common code. Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 08 Jan, 2016 2 commits
-
-
Viktor Dukhovni authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Viktor Dukhovni authored
Provide backwards-compatiblity for functions, macros and include files if OPENSSL_API_COMPAT is either not defined or defined less than the version number of the release in which the feature was deprecated. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
- 07 Jan, 2016 1 commit
-
-
Rich Salz authored
Only two macros CRYPTO_MDEBUG and CRYPTO_MDEBUG_ABORT to control this. If CRYPTO_MDEBUG is not set, #ifdef out the whole debug machinery. (Thanks to Jakob Bohm for the suggestion!) Make the "change wrapper functions" be the only paradigm. Wrote documentation! Format the 'set func' functions so their paramlists are legible. Format some multi-line comments. Remove ability to get/set the "memory debug" functions at runtme. Remove MemCheck_* and CRYPTO_malloc_debug_init macros. Add CRYPTO_mem_debug(int flag) function. Add test/memleaktest. Rename CRYPTO_malloc_init to OPENSSL_malloc_init; remove needless calls. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
- 02 Jan, 2016 2 commits
-
-
Viktor Dukhovni authored
The protocol selection code is now consolidated in a few consecutive short functions in a single file and is table driven. Protocol-specific constraints that influence negotiation are moved into the flags field of the method structure. The same protocol version constraints are now applied in all code paths. It is now much easier to add new protocol versions without reworking the protocol selection logic. In the presence of "holes" in the list of enabled client protocols we no longer select client protocols below the hole based on a subset of the constraints and then fail shortly after when it is found that these don't meet the remaining constraints (suiteb, FIPS, security level, ...). Ideally, with the new min/max controls users will be less likely to create "holes" in the first place. Reviewed-by:
Kurt Roeckx <kurt@openssl.org>
-
Kurt Roeckx authored
Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 15 Dec, 2015 2 commits
-
-
Rich Salz authored
Reviewed-by:
Ben Laurie <ben@openssl.org>
-
Matt Caswell authored
s_server was trying to set the ECDH curve when no-ec was defined. This also highlighted the fact that the -no_ecdhe option to s_server is broken, and doesn't make any sense any more (ECDHE is on by default and the only way it can be disabled is through the cipherstring). Therefore this commit removes the option. Reviewed-by:
Kurt Roeckx <kurt@openssl.org>
-
- 13 Dec, 2015 1 commit
-
-
Rich Salz authored
(Documentation update was in the MR but not the commit. Oops.) Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 11 Dec, 2015 1 commit
-
-
Matt Caswell authored
The link to the OCB patent pdf changed, so the link in CHANGES needs to be updated. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-