1. 01 Mar, 2016 10 commits
  2. 29 Feb, 2016 1 commit
    • Matt Caswell's avatar
      Fix BN_hex2bn/BN_dec2bn NULL ptr/heap corruption · 8f651326
      Matt Caswell authored
      
      
      In the BN_hex2bn function the number of hex digits is calculated using
      an int value |i|. Later |bn_expand| is called with a value of |i * 4|.
      For large values of |i| this can result in |bn_expand| not allocating any
      memory because |i * 4| is negative. This leaves ret->d as NULL leading
      to a subsequent NULL ptr deref. For very large values of |i|, the
      calculation |i * 4| could be a positive value smaller than |i|. In this
      case memory is allocated to ret->d, but it is insufficiently sized
      leading to heap corruption. A similar issue exists in BN_dec2bn.
      
      This could have security consequences if BN_hex2bn/BN_dec2bn is ever
      called by user applications with very large untrusted hex/dec data. This is
      anticipated to be a rare occurrence.
      
      All OpenSSL internal usage of this function uses data that is not expected
      to be untrusted, e.g. config file data or application command line
      arguments. If user developed applications generate config file data based
      on untrusted data then it is possible that this could also lead to security
      consequences. This is also anticipated to be a rare.
      
      Issue reported by Guido Vranken.
      
      CVE-2016-0797
      
      Reviewed-by: default avatarAndy Polyakov <appro@openssl.org>
      (cherry picked from commit c1753084)
      8f651326
  3. 27 Feb, 2016 1 commit
  4. 25 Feb, 2016 2 commits
    • Matt Caswell's avatar
      Fix memory issues in BIO_*printf functions · a801bf26
      Matt Caswell authored
      
      
      The internal |fmtstr| function used in processing a "%s" format string
      in the BIO_*printf functions could overflow while calculating the length
      of a string and cause an OOB read when printing very long strings.
      
      Additionally the internal |doapr_outch| function can attempt to write to
      an OOB memory location (at an offset from the NULL pointer) in the event of
      a memory allocation failure. In 1.0.2 and below this could be caused where
      the size of a buffer to be allocated is greater than INT_MAX. E.g. this
      could be in processing a very long "%s" format string. Memory leaks can also
      occur.
      
      These issues will only occur on certain platforms where sizeof(size_t) >
      sizeof(int). E.g. many 64 bit systems. The first issue may mask the second
      issue dependent on compiler behaviour.
      
      These problems could enable attacks where large amounts of untrusted data
      is passed to the BIO_*printf functions. If applications use these functions
      in this way then they could be vulnerable. OpenSSL itself uses these
      functions when printing out human-readable dumps of ASN.1 data. Therefore
      applications that print this data could be vulnerable if the data is from
      untrusted sources. OpenSSL command line applications could also be
      vulnerable where they print out ASN.1 data, or if untrusted data is passed
      as command line arguments.
      
      Libssl is not considered directly vulnerable. Additionally certificates etc
      received via remote connections via libssl are also unlikely to be able to
      trigger these issues because of message size limits enforced within libssl.
      
      CVE-2016-0799
      
      Issue reported by Guido Vranken.
      
      Reviewed-by: default avatarAndy Polyakov <appro@openssl.org>
      (cherry picked from commit 578b956f)
      a801bf26
    • Emilia Kasper's avatar
      CVE-2016-0798: avoid memory leak in SRP · 59a908f1
      Emilia Kasper authored
      
      
      The SRP user database lookup method SRP_VBASE_get_by_user had confusing
      memory management semantics; the returned pointer was sometimes newly
      allocated, and sometimes owned by the callee. The calling code has no
      way of distinguishing these two cases.
      
      Specifically, SRP servers that configure a secret seed to hide valid
      login information are vulnerable to a memory leak: an attacker
      connecting with an invalid username can cause a memory leak of around
      300 bytes per connection.
      
      Servers that do not configure SRP, or configure SRP but do not configure
      a seed are not vulnerable.
      
      In Apache, the seed directive is known as SSLSRPUnknownUserSeed.
      
      To mitigate the memory leak, the seed handling in SRP_VBASE_get_by_user
      is now disabled even if the user has configured a seed.
      
      Applications are advised to migrate to SRP_VBASE_get1_by_user. However,
      note that OpenSSL makes no strong guarantees about the
      indistinguishability of valid and invalid logins. In particular,
      computations are currently not carried out in constant time.
      
      Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
      59a908f1
  5. 23 Feb, 2016 1 commit
  6. 19 Feb, 2016 1 commit
  7. 12 Feb, 2016 1 commit
  8. 11 Feb, 2016 1 commit
  9. 10 Feb, 2016 1 commit
  10. 28 Jan, 2016 9 commits
  11. 19 Jan, 2016 3 commits
  12. 17 Jan, 2016 1 commit
  13. 14 Jan, 2016 1 commit
  14. 10 Jan, 2016 2 commits
  15. 05 Jan, 2016 1 commit
  16. 28 Dec, 2015 1 commit
  17. 27 Dec, 2015 3 commits