Skip to content
  1. Sep 22, 2015
  2. Sep 21, 2015
    • David Woodhouse's avatar
      RT3479: Add UTF8 support to BIO_read_filename() · ff03599a
      David Woodhouse authored
      
      
      If we use BIO_new_file(), on Windows it'll jump through hoops to work
      around their unusual charset/Unicode handling. it'll convert a UTF-8
      filename to UCS-16LE and attempt to use _wfopen().
      
      If you use BIO_read_filename(), it doesn't do this. Shouldn't it be
      consistent?
      
      It would certainly be nice if SSL_use_certificate_chain_file() worked.
      
      Also made BIO_C_SET_FILENAME work (rsalz)
      
      Signed-off-by: default avatarRich Salz <rsalz@akamai.com>
      Reviewed-by: default avatarAndy Polyakov <appro@openssl.org>
      ff03599a
    • Gunnar Kudrjavets's avatar
      RT3823: Improve the robustness of event logging · 4cd94416
      Gunnar Kudrjavets authored
      
      
      There are a couple of minor fixes here:
      
      1) Handle the case when RegisterEventSource() fails (which it may for
      various reasons) and do the work of logging the event only if it succeeds.
      
      2) Handle the case when ReportEvent() fails and do our best in debug builds
      to at least attempt somehow indicate that something has gone wrong. The
      typical situation would be someone running tools like DbMon, DBWin32,
      DebugView or just having the debugger attached. The intent is to make sure
      that at least some data will be captured so that we can save hours and days
      of debugging time.
      
      3) Minor fix to change the MessageBox() flag to MB_ICONERROR. Though the
      value of MB_ICONERROR is the same value as MB_ICONSTOP, the intent is
      better conveyed by using MB_ICONERROR.
      
      Testing performed:
      
      1) Clean compilation for debug-VC-WIN32 and VC-WIN32.
      
      2) Good test results (nmake -f ms\ntdll.mak test) for debug-VC-WIN32 and
      VC-WIN32.
      
      3) Stepped through relevant changes using WinDBG and exercised the impacted
      code paths.
      
      Signed-off-by: default avatarRich Salz <rsalz@akamai.com>
      Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
      4cd94416
    • Matt Caswell's avatar
      GOST PKCS12 support · 77886387
      Matt Caswell authored
      
      
      Changes required to add GOST support to PKCS12
      
      Based on a patch provided by Dmitry Belyavsky <beldmit@gmail.com>
      
      Reviewed-by: default avatarStephen Henson <steve@openssl.org>
      77886387
    • Matt Caswell's avatar
      Add GOST extensions to PKCS#5 · eeb1c397
      Matt Caswell authored
      
      
      GOST extends PKCS5 PBES2/PBKDF2 with some additional GOST specific PRFs.
      
      Based on a patch provided by Dmitry Belyavsky <beldmit@gmail.com>
      
      Reviewed-by: default avatarStephen Henson <steve@openssl.org>
      eeb1c397
    • Matt Caswell's avatar
      Fix SRP memory leaks · bf95cde2
      Matt Caswell authored
      
      
      There were some memory leaks in the creation of an SRP verifier (both on
      successful completion and also on some error paths).
      
      Reviewed-by: default avatarEmilia Käsper <emilia@openssl.org>
      bf95cde2
    • Matt Caswell's avatar
      Fix -srpvfile option in srp command line · dfd6211c
      Matt Caswell authored
      
      
      The -srpvfile option was broken in the srp command line app. Using it would
      always result in "-dbfile and -configfile cannot be specified together."
      The error message is also wrong because the option is "-srpvfile" not
      "-dbfile", so that has been fixed too.
      
      Reviewed-by: default avatarEmilia Käsper <emilia@openssl.org>
      dfd6211c
  3. Sep 20, 2015
  4. Sep 19, 2015
  5. Sep 18, 2015
  6. Sep 17, 2015
    • Matt Caswell's avatar
      Make sure OPENSSL_cleanse checks for NULL · 020d8fc8
      Matt Caswell authored
      
      
      In master we have the function OPENSSL_clear_free(x,y), which immediately
      returns if x == NULL. In <=1.0.2 this function does not exist so we have to
      do:
      OPENSSL_cleanse(x, y);
      OPENSSL_free(x);
      
      However, previously, OPENSSL_cleanse did not check that if x == NULL, so
      the real equivalent check would have to be:
      if (x != NULL)
          OPENSSL_cleanse(x, y);
      OPENSSL_free(x);
      
      It would be easy to get this wrong during cherry-picking to other branches
      and therefore, for safety, it is best to just ensure OPENSSL_cleanse also
      checks for NULL.
      
      Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
      020d8fc8