- 22 Jun, 2018 9 commits
-
-
Matt Caswell authored
Reviewed-by:
Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/6550)
-
Nicola Tuveri authored
These headers are internal and never exposed to a cpp compiler, hence no need for the preamble. Reviewed-by:
Matt Caswell <matt@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/6554)
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/6515)
-
Andy Polyakov authored
Reviewed-by:
-
Andy Polyakov authored
Reviewed-by:
-
Andy Polyakov authored
This makes AIX build procedure behave more like e.g. Solaris. Most notably this makes it possible to pass -Wl,-R,'$(LIBRPATH)' at config time to embed installation destination as library search path into openssl binary. This doesn't imply that other applications have to be linked with -bsvr4, they are free to choose whatever appropriate for given circumstances. Reviewed-by:
-
Andy Polyakov authored
AIX treats its shared libraries in unique manner, by placing multiple shared objects of different versions and bitnesses, into .a file. So far we have been naively linking with version-less libcrypto|ssl.so, which poses long-term maintenance problems. One could choose to link straight with libcrypto.so.X.Y [or libcrypto.X.Y.so], but it would be inconsistent with the way AIX [or Unix] does things. Reviewed-by:
-
Andy Polyakov authored
Reviewed-by:
-
Nicola Tuveri authored
Fix prototype warnings triggered by -Wstrict-prototypes when configuring with `enable-ec_nistp_64_gcc_128` Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> Reviewed-by:
-
- 21 Jun, 2018 18 commits
-
-
Dr. Matthias St. Pierre authored
(introduced by commit 91860165 , which added -Wstrict-prototypes) Reviewed-by:
-
Shane Lontis authored
Fixed range of random produced in BN_is_prime_fasttest_ex() to be 1 < rand < w-1. It was using 1<= rand < w (which is wrong by 1 on both ends) Reviewed-by:
-
David von Oheimb authored
Reviewed-by:
-
Nicola Tuveri authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
-
Billy Brumley authored
Reviewed-by:
-
Billy Brumley authored
Reviewed-by:
-
Billy Brumley authored
Reviewed-by:
-
Bernd Edlinger authored
[extended tests] Reviewed-by:
-
FdaSilvaYY authored
Small simplification by skipping effectively redundant step and not resuming search from point past deletion. Reviewed-by:
-
Andy Polyakov authored
Add irix-common template that covers even irix-shared from shared-info.pl. Reviewed-by:
-
Andy Polyakov authored
The goal is to minimize maintenance burden by eliminating somewhat obscure platform-specific tweaks that are not viewed as critical for contemporary applications. This affects Camellia and digest implementations that rely on md32_common.h, MD4, MD5, SHA1, SHA256. SHA256 is the only one that can be viewed as critical, but given the assembly coverage, the omission is considered appropriate. Reviewed-by:
-
Billy Brumley authored
Reviewed-by:
-
Matt Caswell authored
An alpn_selected value containing NUL bytes in it will result in ext.alpn_selected_len having a larger value than the number of bytes allocated in ext.alpn_selected. Issue found by OSS-fuzz. Reviewed-by:
-
Nicola Tuveri authored
Reviewed-by:
-
Matt Caswell authored
This extends the recently added ECDSA signature blinding to blind DSA too. This is based on side channel attacks demonstrated by Keegan Ryan (NCC Group) for ECDSA which are likely to be able to be applied to DSA. Normally, as in ECDSA, during signing the signer calculates: s:= k^-1 * (m + r * priv_key) mod order In ECDSA, the addition operation above provides a sufficient signal for a flush+reload attack to derive the private key given sufficient signature operations. As a mitigation (based on a suggestion from Keegan) we add blinding to the operation so that: s := k^-1 * blind^-1 (blind * m + blind * r * priv_key) mod order Since this attack is a localhost side channel only no CVE is assigned. This commit also tweaks the previous ECDSA blinding so that blinding is only removed at the last possible step. Reviewed-by:
-
Matt Caswell authored
Reviewed-by:
-
Richard Levitte authored
Fixes #6544 Reviewed-by:
-
Pauli authored
Also fix some clumsy wording. [skip_ci] Reviewed-by:
-
- 20 Jun, 2018 7 commits
-
-
Richard Levitte authored
Hopefully, this will make it more clear that it isn't only ELF specific, even though there is a part that is (or even more restrictively GNU ld.so specific). Reviewed-by:
-
Matt Caswell authored
Reviewed-by: -
Matt Caswell authored
Reviewed-by: -
Matt Caswell authored
Reviewed-by:
-
Paul Kehrer authored
Reviewed-by:
-
Matt Caswell authored
Fixes #6525 Reviewed-by:
-
Bernd Edlinger authored
[extended tests] Reviewed-by:
-
- 19 Jun, 2018 6 commits
-
-
Matt Caswell authored
Commit 4aa5a566 accidentally missed off the catch all case of ignoring all warning alerts that are otherwise unhandled. This breaks the SSLv3 tests which send a "no certificate" warning alert. Fixes #6496 [extended tests] Reviewed-by:
Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/6509)
-
Dr. Matthias St. Pierre authored
- Print positive feedback in the case when 'make doc-nits' finds no errors. - Other than before, keep the 'doc-nits' output file only in case of errors and remove it if it is empty. - Declare 'doc-nits' as a phony make target to facilitate rerunning 'make doc-nits' without having to remove the output file first. Reviewed-by:
-
Nicola Tuveri authored
Reviewed-by:
Ben Kaduk <kaduk@mit.edu> Reviewed-by:
-
Sohaib ul Hassan authored
This commit implements coordinate blinding, i.e., it randomizes the representative of an elliptic curve point in its equivalence class, for prime curves implemented through EC_GFp_simple_method, EC_GFp_mont_method, and EC_GFp_nist_method. This commit is derived from the patch https://marc.info/?l=openssl-dev&m=131194808413635 by Billy Brumley. Coordinate blinding is a generally useful side-channel countermeasure and is (mostly) free. The function itself takes a few field multiplicationss, but is usually only necessary at the beginning of a scalar multiplication (as implemented in the patch). When used this way, it makes the values that variables take (i.e., field elements in an algorithm state) unpredictable. For instance, this mitigates chosen EC point side-channel attacks for settings such as ECDH and EC private key decryption, for the aforementioned curves. For EC_METHODs using different coordinate representations this commit does nothing, but the corresponding coordinate blinding function can be easily added in the future to extend these changes to such curves. Co-authored-by:
Nicola Tuveri <nic.tuv@gmail.com> Co-authored-by:
Billy Brumley <bbrumley@gmail.com> Reviewed-by:
-
Jack Lloyd authored
Use EVP_PKEY_set_alias_type to access Reviewed-by:
-
Jack Lloyd authored
Reviewed-by:
-
