Commit 991f0355 authored by FdaSilvaYY's avatar FdaSilvaYY Committed by Andy Polyakov
Browse files

apps/ca: fix useless get before delete. 



Small simplification by skipping effectively redundant step and
not resuming search from point past deletion.

Reviewed-by: default avatarAndy Polyakov <appro@openssl.org>
Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6195)
parent 1b712f3f

apps/ca.c

+3 −3
Original line number Diff line number Diff line
@@ -1706,11 +1706,11 @@ static int do_body(X509 **xret, EVP_PKEY *pkey, X509 *x509, 
            BIO_printf(bio_err, "Memory allocation failure\n");

            goto end;

        }

        i = -1;

        while ((i = X509_NAME_get_index_by_NID(dn_subject,

                                               NID_pkcs9_emailAddress,

                                               -1)) >= 0) {

            tmpne = X509_NAME_get_entry(dn_subject, i);

            X509_NAME_delete_entry(dn_subject, i);

                                               i)) >= 0) {

            tmpne = X509_NAME_delete_entry(dn_subject, i--);

            X509_NAME_ENTRY_free(tmpne);

        }