- Feb 28, 2013
-
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
Following commit ad3177da corrected the debug message in state() from AUTH to AUTH_FINAL.
-
Steve Holme authored
Following commit afad1ce7 corrected the debug message in state() from AUTH to AUTH_FINAL.
-
Steve Holme authored
Following commit 13006f3d corrected the debug message in state() from AUTHENTICATE to AUTHENTICATE_FINAL.
-
Jiri Hruska authored
If the FETCH command does not result in an untagged response the the UID is probably invalid. As such do not return CURLE_OK.
-
Jiri Hruska authored
Not processing the final FETCH responses was not optimal, not only because the response code would be ignored but it would also leave data unread on the socket which would prohibit connection reuse.
-
Jiri Hruska authored
A typical FETCH response can be broken down into four parts: 1) "* <uid> FETCH (<what> {<size>}\r\n", using continuation syntax 2) <size> bytes of the actual message 3) ")\r\n", finishing the untagged response 4) "<tag> OK ...", finishing the command Part 1 is read in imap_fetch_resp(), part 2 is consumed in the PERFORM phase by the transfer subsystem, parts 3 and 4 are currently ignored.
-
Steve Holme authored
Removed whitespace from imap_perform()
-
Steve Holme authored
error: declaration of 'imap' shadows a previous local
-
- Feb 27, 2013
-
-
Steve Holme authored
Changed the final SMTP_AUTH constant to SMTP_AUTH_FINAL for consistency with the response function.
-
Steve Holme authored
Changed the final POP3_AUTH constant to POP3_AUTH_FINAL for consistency with the response function.
-
Steve Holme authored
Changed the final IMAP_AUTHENTICATE constant to IMAP_AUTHENTICATE_FINAL for consistency with the response function.
-
Steve Holme authored
Updated the coding style, in this function, to be consistant with other response functions rather then performing a hard return on failure.
-
Steve Holme authored
Reversed the logic of the unsuccessful vs successful tagged SELECT response in imap_state_select_resp() to be more logical to read.
-
Steve Holme authored
Reversed the logic of the unsuccessful vs successful tagged CAPABILITY response in imap_state_capability_resp() to be more logical to read.
-
Steve Holme authored
Corrected char* references made in commit: 709b3506.
-
Jiri Hruska authored
Added a loop to imap_statemach_act() in which Curl_pp_readresp() is called until the cache is drained. Without this multiple responses received in a single packet could result in a hang or delay.
-
Jiri Hruska authored
Added storage and checking of the last mailbox userd to prevent unnecessary switching.
-
Jiri Hruska authored
Added the mailbox variable to the per-connection structure in preparation for checking for an already selected mailbox.
-
- Feb 26, 2013
-
-
Steve Holme authored
Reordered the state and ssl_done variables in order to provide more consistency between the email protocols as well as for for an upcoming change.
-
Steve Holme authored
-
Steve Holme authored
-
Jiri Hruska authored
Added support for checking the UIDVALIDITY, and aborting the request, if it has been specified in the URL and the server response is different.
-
Jiri Hruska authored
Added support for parsing the UIDVALIDITY property from the SELECT response and storing it in the per-connection structure.
-
Jiri Hruska authored
Added the mailbox_uidvalidity variable to the per-connection structure in preparation for checking the UIDVALIDITY mailbox attribute.
-
Steve Holme authored
-
Steve Holme authored
-
Jiri Hruska authored
Only responses that contain "CAPABILITY" and "FETCH", respectively, will be sent to their response handler.
-
Jiri Hruska authored
RFC 3501 states that "the client MUST be prepared to accept any response at all times" yet we assume anything received with "* " at the beginning is the untagged response we want. Introduced a helper function that checks whether the input looks like a response to specified command, so that we may filter the ones we are interested in according to the current state.
-
Jiri Hruska authored
Introduced similar handling to the FETCH responses, where even the untagged data responses are handled by the response handler of the individual state.
-
Linus Nielsen authored
-
- Feb 25, 2013
-
-
Steve Holme authored
-
Steve Holme authored
Removed this pointer to a downloaded bytes counter because it was set in smtp_init() to point to the same variable the transfer functions keep the count in (k->bytecount), effectively making the code in transfer.c "*k->bytecountp = k->bytecount" a no-op.
-
Steve Holme authored
Removed this pointer to a downloaded bytes counter because it was set in pop3_init() to point to the same variable the transfer functions keep the count in (k->bytecount), effectively making the code in transfer.c "*k->bytecountp = k->bytecount" a no-op.
-
Jiri Hruska authored
Removed this pointer to a downloaded bytes counter because it was set in imap_init() to point to the same variable the transfer functions keep the count in (k->bytecount), effectively making the code in transfer.c "*k->bytecountp = k->bytecount" a no-op.
-
Jiri Hruska authored
Moved imap_select() and imap_fetch() to be grouped with the other perform functions.
-
Jiri Hruska authored
Exchanged the position of these states in the switch statements to match the state enum, execution and function order.
-
Steve Holme authored
Tidy up of comments before next round of imap changes.
-
Steve Holme authored
Corrected the comparison type in addition to commit 1dac29fa.
-